Hi,
this is a topic I want to start in order to help the development of more intelligent brightness control for Galaxy S (probably regional variants of it will benefit as well).
It began with my PM to some of kernel DEVs that I've noticed brownish color instead of black on ONE brightness setting. My idea was to omit that one brightness level.
Overnight, I already got two responses. One that it should be no problem and one that the link I sent might lead to fixing the problem I mentioned as well (color correction).
The other, connected to brightness topic, thing I've noticed is that auto control of it is retarded. First, it's too jumpy without any reason (like let's say change of outside brightness) and second it likes to set level that burn the eyeballs. I've never had such problem on my CM Hero.
Here's my original PM:
embrion said:
Hi,
I'm PMing you as the most popular kernels coders.
Long story short: SAMOLED screens like to make black or similar colors brownish at low brightness. I've (and not only me) noticed that there's a step just about min. when it starts to be brown and a next step after that it magically stops. The idea is to omit this step at all or just in auto brightness table. I believe It's doable by using those methods.
The original story begins here from the first half of #522 post
Like I've wrote there, this problem exists in all kernels and all color temperature variants of them + stock one.
If you're interested, please respond me. If not, also respond as I'd like to know if I can count on anything.
Thanks
Click to expand...
Click to collapse
Some links that might help:
[SOLUTION] Fix for minimum screen brightness! [10/13 - adjustable]
Kernel makers, please add the ability to adjust auto brightness.
[APP] Different auto-brightness
Gizmodo - Why iPhone 4 and Android Brightness Controls Are Effectively Useless
My random thoughts:
One option would be fooling the sensor that it is less bright than it is
Another, more proper I believe, it to modify some brightness tables to leave extreme brightness levels to extreme outside light situations. This one would also help skipping this "brown" brightness level as like I said, it looks to be only one level
Color correction MIGHT fix "brown" problem too, but I'm not sure as COLD and WARM kernel variants didn't changed this brown problem (unless colors are optimized only for some of the levels like I've read at VOODOO site)
CM 6 already has such brightness level options in Settings-> CM Settings - > User interface -> Automatic backlight -> Use custom(just checked on my Hero) so probably lot of code can be reused (as I believe there is CM for Galaxy S)
Kernel DEVs, fell free to hijack this thread. It is to help your cooperation (unless each one of you prefer to solve problems on they own ) Btw. don't be offended if I didn't included you in the DEVs list I've sent my PM. It was late and I PMed only those I've noticed that they kernels I've used. All of you are more than welcomed.
Other, please don't post "I cannot see any brown", and those one that can see it, please stop posting about info after first 5 people do
I'm so happy to read this threat. I had posted questions about display and auto brightness a couple of months ago in the questions section but never received any credible responses.
My problem is that when I turn auto brightness on, not only does my display get exceptionally dark, but it becomes very noticeable that e.g. grey turns more brownish. Comparing my display to yet another Galaxy S confirmed my suspicions that this is not they way the display is supposed operate, i.e. compared to mine the other Galaxy stayed a lot brighter in equal lighting conditions and the grey remained grey (instead of brownish-grey like mine). I compared the grey tones of the numeric buttons in the stock Dialer APP to conclude this.
I suspectED the light sensor might be defective, but I have run the test menu on a couple of Galaxies (*#0589#) and the units always display the same values when put next to mine.
You might see why this is bugging me so much, it seems my galaxy's display is not using less battery even though I get less brightness than the others on auto brightness. Unless I manually bump up the brightness to full the colors on my screen look dull (grey turns Brownish, and over all it looks not as alive) as compared to other units. Simply bumping the brightness up is of course not an option, this drain the battery like crazy.
EDIT: I too have tried the various Kernels, hardcore warm and cold, voodoo w/ color fix sadly all to no avail
EDIT2: @embrion The above all doesn't explain why our phones have this problem, but the far majority of Galaxy S phones doesn't. Of course I cannot statistically back this up, but I have not physically seen any other device that gets brown on autobrightness like ours. Any Ideas?
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
embrion said:
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
Click to expand...
Click to collapse
It does not turn brown and appears much brighter in equal lighting w/ auto brightness ON. I edited my post above, please read again if it was unclear before. Thank you!!
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
embrion said:
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
Click to expand...
Click to collapse
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
(Auto)brightness corrections
Original Auto Brightness level is too high & sluggish.
It 's need to fix like a voodoo Brightness level fix (2.1 only).
schiphol said:
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
Click to expand...
Click to collapse
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
embrion said:
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
Click to expand...
Click to collapse
Which CSC code do you have? I mine was originally XEN (Netherlands). The units I tested that did not have the problem were all DBT (german Sim free). Just asked my brother and he says his phone also gets brownish (also XEN). Have to check product codes later, will update then.
Mine is XEE (Orange, Poland)
Supercurio did some tinkering with those settings:
https://github.com/project-voodoo/l...a2/Kernel/drivers/video/samsung/s3cfb_mdnie.c
I suspect this is the file we need to modify;
Code:
mDNIe_data_type mDNIe_UI[]=
{
#ifdef CONFIG_VOODOO_MDNIE
// Voodoo color: optimized UI mode
// reduce the sharpness filter radius to make it much closer
// to the real fuzzyness introduced by the SAMOLED Pentile pattern
// color saturation boost on everything is also disabled because
// it causes harm on stock settings (exaggerated colors)
0x0084, 0x0040,
0x0090, 0x0000,
0x0094, 0x0FFF,
0x0098, 0x005C,
0x009C, 0x0613,
0x00AC, 0x0000,
0x00B4, 0x0A00,
0x00C0, 0x0400,
0x00C4, 0x7200,
0x00C8, 0x008D,
0x00D0, 0x00C0,
END_SEQ, 0x0000,
Any thoughts and datasheet quotations on this? Because seriously I see just random numbers in this.
Some interesting code begins around line 315, but seriously I'm clueless
Another interesting file:
https://github.com/project-voodoo/l...2/Kernel/drivers/video/samsung/s3cfb_tl2796.c
My screen has brownish/reddish deep grays on brightness settings under 16-17%. However when I set it over 17% and use screen filter app deep grays are NOT brownish/reddish, this means there is definitely something with lower brightness settings.
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
embrion said:
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
Click to expand...
Click to collapse
@embrion so did you pm Supercurio? What did he say? It's too bad this color/sharpness fixing will probably be put on a back burner what with Gingerbread and CM7 development. D*RN IT! I tried an app in the market that is more precise than the built-in slider. Try it out Adjbrightness (free). I punched in all values possible between 2-255. The tipping point (where the browness is gone) lies at when you go from 34 to 35. Is this the same for everyone suffering from this problem. Please remove all apps like e.g. 'screen filter' before you try!
For me crucial step is going from
/ # echo 53 > /sys/devices/platform/s3cfb/spi_gpio.3/spi3.0/backlight/s5p_bl/brightness
to 54, however I'm running trasig's voodoo.
While 54 and over looks ok, lower values are... reddish/pinkish.
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
embrion said:
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
Click to expand...
Click to collapse
No fix there, just a different behaviour...
Would like to see this in next voodoo, might even write some simple user interface for this.
I have an idea but its not quite clear yet, however if this patch will let most users 'calibrate' their screens.. I think I'll give simple GUI a shot.
@embrion
Could you perhaps upload the screenshots you talked about in R64's thread so I can replicate. Because of different kernels and settings I want to try and establish beyond a doubt that the problem we're having is of the same nature and root cause. Thanks
This wont be visible on screenshots. You need to make a photo, problably with DSLR and know how to do it
I'll try it today and let you know
According to Supercurio, this is Samsung's color profile deviation, not SAMOLED fault itself.
Anything software broken can be software fixed
@schiphol, xan: yes, it won't be noticed at screenshots, I've already compared R64's black notification bar screenshots and my brown ones. Color picker showed a little difference in color (R:24, G:24, B:24 or something VS RGB: 0, 0, 0 - true black). Such difference should'n be visible and is not visible from software screenshot point of view but Samsung color profile makes 24,24,24 brown IN REAL LIFE while 0,0,0 is still black. I repeat, they're both black at screenshots no matter which brightness level is set, but only 0,0,0 black doesn't look like brown when viewed by bare human eye. Samsung profile at this brightness treats 24,24,24 as brown while it should as black.
--edited--
You're right, Xan. It's just another, ( but 1337 ) method of changing the brightness. I thought there's a plaintext table with levels accessible to change by hand
Hi Ok I have kept the brightness at 2 clicks to the right from minimum to stop grey from looking grey-brown all through today. Now my display accounts for 95% of the battery usage, it has never been this high before. The battery is at 25% whilst I only used the display for 44 minutes.
Thats ridiculous battery drainage and should be taken into careful consideration when a fix is developed for this issue. Are you guys having a similar experience??
This is apparently NOT a problem. However, I would like to have some color fix on this.
I don't know if anyone knows what I meant
The One X screen compares to S3 or any other phone side by side, the one x had a slight warmer color tone, in other words, it's kinda yellowish.
it's truely visible on white screen.
I find this very disturbing, is there a way to fix this? I prefer a more natural and realistic color tone.
If you're gonna recommend an color fix app, can you tell me the input for primary color values to correctly fix it? I'm too lazy to fix it little by little lol.
dustin4vn said:
This is apparently NOT a problem. However, I would like to have some color fix on this.
I don't know if anyone knows what I meant
The One X screen compares to S3 or any other phone side by side, the one x had a slight warmer color tone, in other words, it's kinda yellowish.
it's truely visible on white screen.
I find this very disturbing, is there a way to fix this? I prefer a more natural and realistic color tone.
If you're gonna recommend an color fix app, can you tell me the input for primary color values to correctly fix it? I'm too lazy to fix it little by little lol.
Click to expand...
Click to collapse
It is going to be a colour fix app, but everybody has their own settings my cooler temp colour may be to warm for you or to cold. So you have to fiddle with it ti find your own settings that you like.
Give this one a try and see how it works: My Settings are alpha set to 8 and blue set to around 80ish or so.
https://play.google.com/store/apps/details?id=com.kovit.p.filteryourscreen&hl=en
It will go as the day pass
Sent from my HTC One X using Tapatalk 2
Hi,
I have this problem and I have a LGD panel. There is any permanent solution? I already know about changing colour parámetres.
Thanks.
Any solution?
Try one of these videos for several hours:
https://www.youtube.com/results?search_query=lcd+image+retention+
Basically there is no such thing as burn-in with LCD screens. But what can happen is that a colour is displayed too long which can make the molecules "get stuck" in it's current state. You can literally massage it to relax again with some colour flickering for a long period of time.
I have Mi5s with LG panel, and there is a solution for image retention problem. You do not need to play some videos with pixel shifting for hours
There are three ways to solve this issue, it depends what ROM are you using.
First one:
If you have stock ROM without root you need to shut down and cool down your phone for at least 24 hours. After that image retention will be gone, but will come back again, so this is only temporary solution.
Second:
If you have stock ROM and have root, install this app from play store: https://play.google.com/store/apps/details?id=eu.chainfire.lumen
Grant root permissions, in battery settings allow this app to run in background and to run on startup. Open the app and in Master filter mode set custom values at 0.9 for all, save and exit.
Third and best one:
If you have custom ROM like me ( Lineage 15.1 Oreo 8.1) , enter display settings, live display, color calibration, and set RGB values to 90% and press ok.
I am using this fix for 2 months and did not seen any image retention. You can check this on all grey image/background, this is the easiest way to spot image retention.
I know this is very annoying problem, I was thinking to return my phone for warranty, but it is very hard to find another Mi5s with another type of panel, so after some time new phone will have same issue again.
Thanks for the info, Mr. Nice.
I use Epic Rom (stable) but there is no RGB settings in display options. Any alternative way to proceed?
Use can use CF Lumen app from the link above.
I tried it but the display shows burn-in as before.
None of the solution I found solve the problem. Any sugestion?
LCD panels can't have burn-in effect. But if you have that then time to buy a new phone.
i am changing my huaweip10lite just becouse i'm sick of the horrible blur when i scroll up and down text espescially on dark backgrounds, maybe it's just a issue with mine but i found someone that buy my phone and so i can change it.
Really guys, can you tell me if there are long lines of blur/ghosting/smearing maybe when you scroll in nova launcher's options, that has a dark background with white text? Becouse mine screen is horrible.
I read some threads where people say that is just amoled display issue but i tried other amoleds and it is totally not as mine issue, and the huaweip10 lite doesen't have an amoled display so it make no sense for me.
I just want to check if oneplus5t doesen't have this issue becouse i see it a lot when it happens.
I think this issue is called smearing, or ghosting, or blur while scrolling. I don't know what is.
https://www.youtube.com/watch?v=ZCCRf08IGlw
i think my issue is similar to this
Thanks for any helps guys! Peace.
asnachan said:
I think this issue is called smearing, or ghosting, or blur while scrolling. I don't know what is.
Click to expand...
Click to collapse
Tested on my AppGeek - there's no blurred scrolling on the 5T.
And the scroll is far smoother than whatever is on that video!
thanks!
i'm going to buy the op5t or the pixel 2
I had same issues on mine when i open a lot of popup settings or just scroll down the screen blur goes crazy
Sent from my OnePlus5T using XDA Labs
Oneplus 5t also has this blur when scrolling... Not so much, but it has. Is something normal on an Amoled display...