Hi,
this is a topic I want to start in order to help the development of more intelligent brightness control for Galaxy S (probably regional variants of it will benefit as well).
It began with my PM to some of kernel DEVs that I've noticed brownish color instead of black on ONE brightness setting. My idea was to omit that one brightness level.
Overnight, I already got two responses. One that it should be no problem and one that the link I sent might lead to fixing the problem I mentioned as well (color correction).
The other, connected to brightness topic, thing I've noticed is that auto control of it is retarded. First, it's too jumpy without any reason (like let's say change of outside brightness) and second it likes to set level that burn the eyeballs. I've never had such problem on my CM Hero.
Here's my original PM:
embrion said:
Hi,
I'm PMing you as the most popular kernels coders.
Long story short: SAMOLED screens like to make black or similar colors brownish at low brightness. I've (and not only me) noticed that there's a step just about min. when it starts to be brown and a next step after that it magically stops. The idea is to omit this step at all or just in auto brightness table. I believe It's doable by using those methods.
The original story begins here from the first half of #522 post
Like I've wrote there, this problem exists in all kernels and all color temperature variants of them + stock one.
If you're interested, please respond me. If not, also respond as I'd like to know if I can count on anything.
Thanks
Click to expand...
Click to collapse
Some links that might help:
[SOLUTION] Fix for minimum screen brightness! [10/13 - adjustable]
Kernel makers, please add the ability to adjust auto brightness.
[APP] Different auto-brightness
Gizmodo - Why iPhone 4 and Android Brightness Controls Are Effectively Useless
My random thoughts:
One option would be fooling the sensor that it is less bright than it is
Another, more proper I believe, it to modify some brightness tables to leave extreme brightness levels to extreme outside light situations. This one would also help skipping this "brown" brightness level as like I said, it looks to be only one level
Color correction MIGHT fix "brown" problem too, but I'm not sure as COLD and WARM kernel variants didn't changed this brown problem (unless colors are optimized only for some of the levels like I've read at VOODOO site)
CM 6 already has such brightness level options in Settings-> CM Settings - > User interface -> Automatic backlight -> Use custom(just checked on my Hero) so probably lot of code can be reused (as I believe there is CM for Galaxy S)
Kernel DEVs, fell free to hijack this thread. It is to help your cooperation (unless each one of you prefer to solve problems on they own ) Btw. don't be offended if I didn't included you in the DEVs list I've sent my PM. It was late and I PMed only those I've noticed that they kernels I've used. All of you are more than welcomed.
Other, please don't post "I cannot see any brown", and those one that can see it, please stop posting about info after first 5 people do
I'm so happy to read this threat. I had posted questions about display and auto brightness a couple of months ago in the questions section but never received any credible responses.
My problem is that when I turn auto brightness on, not only does my display get exceptionally dark, but it becomes very noticeable that e.g. grey turns more brownish. Comparing my display to yet another Galaxy S confirmed my suspicions that this is not they way the display is supposed operate, i.e. compared to mine the other Galaxy stayed a lot brighter in equal lighting conditions and the grey remained grey (instead of brownish-grey like mine). I compared the grey tones of the numeric buttons in the stock Dialer APP to conclude this.
I suspectED the light sensor might be defective, but I have run the test menu on a couple of Galaxies (*#0589#) and the units always display the same values when put next to mine.
You might see why this is bugging me so much, it seems my galaxy's display is not using less battery even though I get less brightness than the others on auto brightness. Unless I manually bump up the brightness to full the colors on my screen look dull (grey turns Brownish, and over all it looks not as alive) as compared to other units. Simply bumping the brightness up is of course not an option, this drain the battery like crazy.
EDIT: I too have tried the various Kernels, hardcore warm and cold, voodoo w/ color fix sadly all to no avail
EDIT2: @embrion The above all doesn't explain why our phones have this problem, but the far majority of Galaxy S phones doesn't. Of course I cannot statistically back this up, but I have not physically seen any other device that gets brown on autobrightness like ours. Any Ideas?
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
embrion said:
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
Click to expand...
Click to collapse
It does not turn brown and appears much brighter in equal lighting w/ auto brightness ON. I edited my post above, please read again if it was unclear before. Thank you!!
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
embrion said:
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
Click to expand...
Click to collapse
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
(Auto)brightness corrections
Original Auto Brightness level is too high & sluggish.
It 's need to fix like a voodoo Brightness level fix (2.1 only).
schiphol said:
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
Click to expand...
Click to collapse
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
embrion said:
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
Click to expand...
Click to collapse
Which CSC code do you have? I mine was originally XEN (Netherlands). The units I tested that did not have the problem were all DBT (german Sim free). Just asked my brother and he says his phone also gets brownish (also XEN). Have to check product codes later, will update then.
Mine is XEE (Orange, Poland)
Supercurio did some tinkering with those settings:
https://github.com/project-voodoo/l...a2/Kernel/drivers/video/samsung/s3cfb_mdnie.c
I suspect this is the file we need to modify;
Code:
mDNIe_data_type mDNIe_UI[]=
{
#ifdef CONFIG_VOODOO_MDNIE
// Voodoo color: optimized UI mode
// reduce the sharpness filter radius to make it much closer
// to the real fuzzyness introduced by the SAMOLED Pentile pattern
// color saturation boost on everything is also disabled because
// it causes harm on stock settings (exaggerated colors)
0x0084, 0x0040,
0x0090, 0x0000,
0x0094, 0x0FFF,
0x0098, 0x005C,
0x009C, 0x0613,
0x00AC, 0x0000,
0x00B4, 0x0A00,
0x00C0, 0x0400,
0x00C4, 0x7200,
0x00C8, 0x008D,
0x00D0, 0x00C0,
END_SEQ, 0x0000,
Any thoughts and datasheet quotations on this? Because seriously I see just random numbers in this.
Some interesting code begins around line 315, but seriously I'm clueless
Another interesting file:
https://github.com/project-voodoo/l...2/Kernel/drivers/video/samsung/s3cfb_tl2796.c
My screen has brownish/reddish deep grays on brightness settings under 16-17%. However when I set it over 17% and use screen filter app deep grays are NOT brownish/reddish, this means there is definitely something with lower brightness settings.
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
embrion said:
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
Click to expand...
Click to collapse
@embrion so did you pm Supercurio? What did he say? It's too bad this color/sharpness fixing will probably be put on a back burner what with Gingerbread and CM7 development. D*RN IT! I tried an app in the market that is more precise than the built-in slider. Try it out Adjbrightness (free). I punched in all values possible between 2-255. The tipping point (where the browness is gone) lies at when you go from 34 to 35. Is this the same for everyone suffering from this problem. Please remove all apps like e.g. 'screen filter' before you try!
For me crucial step is going from
/ # echo 53 > /sys/devices/platform/s3cfb/spi_gpio.3/spi3.0/backlight/s5p_bl/brightness
to 54, however I'm running trasig's voodoo.
While 54 and over looks ok, lower values are... reddish/pinkish.
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
embrion said:
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
Click to expand...
Click to collapse
No fix there, just a different behaviour...
Would like to see this in next voodoo, might even write some simple user interface for this.
I have an idea but its not quite clear yet, however if this patch will let most users 'calibrate' their screens.. I think I'll give simple GUI a shot.
@embrion
Could you perhaps upload the screenshots you talked about in R64's thread so I can replicate. Because of different kernels and settings I want to try and establish beyond a doubt that the problem we're having is of the same nature and root cause. Thanks
This wont be visible on screenshots. You need to make a photo, problably with DSLR and know how to do it
I'll try it today and let you know
According to Supercurio, this is Samsung's color profile deviation, not SAMOLED fault itself.
Anything software broken can be software fixed
@schiphol, xan: yes, it won't be noticed at screenshots, I've already compared R64's black notification bar screenshots and my brown ones. Color picker showed a little difference in color (R:24, G:24, B:24 or something VS RGB: 0, 0, 0 - true black). Such difference should'n be visible and is not visible from software screenshot point of view but Samsung color profile makes 24,24,24 brown IN REAL LIFE while 0,0,0 is still black. I repeat, they're both black at screenshots no matter which brightness level is set, but only 0,0,0 black doesn't look like brown when viewed by bare human eye. Samsung profile at this brightness treats 24,24,24 as brown while it should as black.
--edited--
You're right, Xan. It's just another, ( but 1337 ) method of changing the brightness. I thought there's a plaintext table with levels accessible to change by hand
Hi Ok I have kept the brightness at 2 clicks to the right from minimum to stop grey from looking grey-brown all through today. Now my display accounts for 95% of the battery usage, it has never been this high before. The battery is at 25% whilst I only used the display for 44 minutes.
Thats ridiculous battery drainage and should be taken into careful consideration when a fix is developed for this issue. Are you guys having a similar experience??
Hello,
I have a Nexus 5X and I was having issues with the Android N beta and some apps, so I decided to do a Factory Reset and fix the app issues (it did) BUT the screen got dull, colors are not bright. The Play Music icon looks almost brown.
I have tried multiple factory resets, I even rolled back to Android M, then applied the OTA Update to N to no avail.
I attached some pictures to detail the issue. I checked the entire internet and I can't seem to find a similar issue.
Turn on developer options and select cool color temperature.
elfrisi said:
Hello,
I have a Nexus 5X and I was having issues with the Android N beta and some apps, so I decided to do a Factory Reset and fix the app issues (it did) BUT the screen got dull, colors are not bright. The Play Music icon looks almost brown.
I have tried multiple factory resets, I even rolled back to Android M, then applied the OTA Update to N to no avail.
I attached some pictures to detail the issue. I checked the entire internet and I can't seem to find a similar issue.
Click to expand...
Click to collapse
You can root your device and try to fix it using apps like franco.Kernel Updater where you can adjust RGB colors and even apply different color profiles
sfhub said:
Turn on developer options and select cool color temperature.
Click to expand...
Click to collapse
Sadly that doesn't work, makes the whole screen blue.
doggie13_ said:
You can root your device and try to fix it using apps like franco.Kernel Updater where you can adjust RGB colors and even apply different color profiles
Click to expand...
Click to collapse
I thought of doing that, but that would be last resort if Google doesn't somehow apply the warranty. :/
Not even Google could tell what it is. They sent a new device, waiting for it now.
Hi Volks,
I have a strange problem with my A70s Always On Display (AOD). When I set the color of the clock (regardless of the clocks face) to light grey (upper leftmost color in the color selection screen) it shows the correct color in the preview picture in settings but actually displays the parts of the clocks face that should be grey in BLUE!!? Has anyone else faced this issue? Does anyone know where AOD reads its settings from?
sameeeeeeeeeeee
Swordfishx86 said:
Hi Volks,
I have a strange problem with my A70s Always On Display (AOD). When I set the color of the clock (regardless of the clocks face) to light grey (upper leftmost color in the color selection screen) it shows the correct color in the preview picture in settings but actually displays the parts of the clocks face that should be grey in BLUE!!? Has anyone else faced this issue? Does anyone know where AOD reads its settings from?
Click to expand...
Click to collapse
same here. i learned to live with it. if i remember correctly i posted about this quite some time ago but no one helped me.
so here i am living a blue amoled. sucks.:crying::crying:
but for me this happens only when i flash twrp n root using magisk.
if i stay unrooted the display remains OK.
i have the FN model.
though some times the display starts working properly but only till next lock
Same here, but it disappeared all of a sudden after some time. Now on November update (manually flashed), and AOD works like it should
Captain Beretta said:
Now on November update (manually flashed), and AOD works like it should
Click to expand...
Click to collapse
You flashed 4ASK6, TWRP to recovery and rooted with Magisk?
// update:
I flashed the November Update (4ASK6) and rooted with Magisk using the vanilla method of patching the AF-file. It seems like the version of TWRP by Grarak is no longer able to decrypt the data partition. AOD is back to normal.
May be its off topic, try this AOD+ on https://forum.xda-developers.com/android/apps-games/app-6-0-aod-display-rooted-rooted-t4082935
Just my two cents
Try to adjust display tone towards warm if it's too. Blue.
Besides the general low quality of this piece of software, here are some specific pains:
1. SafetyNet test fails (no root) - WTF? Can't use any of my work applications because of that.
2. Status bar notification icons don't appear (except for Gmail, for some reason)
3. About device shows there's an update available but I can't update because I'm not the "owner" of the device (there is only 1 user configured, no multiple users) - screenshot attached.
Please share your experience and whether or not you're seeing the same issues (or more).
Thanks!
Another botched update from oneplus scams
Well, it's a good thing I decided that the OP9P would be my last OP smartphone. I'm gona stick with Pixel phone from now on. Finally release A12 and no phone or data works. Really OP???
- Phone stuck in 60hz like 99% of the time.
- Keyboard doesn't have this convenient padding anymore. (On botttom to make typing easier.)
- [Launcher] Can't search apps with a single up swipe anymore, will have to find some hacky solution again. Usually I put a KISS launcher shortcut on other phones. But why ruin it when they had it ....
- [Launcher] Folders open on the middle of screen. Makes no sensse.
- [Launcher] The whole launcher experience is just way worse.
- Battery Management is a mess, now there are other options per app. The previous settings were reset.
- Rooting with Canary Magsik can soft brick. Managed to fix it but it took me a while and I consider myself a veteran.
Honestly, tons of great features are missing. I wish they would just give us a lean AOSP instead like the ASUS Android and call it a day. This feels like a botched, budget Android on a cheap Chinese phone.
App drawers can only display 4 icons per row. Anyone knows how to change it to 5 per row or more?
it is no longer possible to film and in 21:9... or I am blind.
Like a say h8Aramex Phone stuck in 60hz like 99% of the time.
anhtin said:
App drawers can only display 4 icons per row. Anyone knows how to change it to 5 per row or more?
Click to expand...
Click to collapse
it's possible. settings --> home screen and lock screen
purpleman2k said:
Status bar notification icons don't appear (except for Gmail, for some reason)
Click to expand...
Click to collapse
That's not actually a bug, that's feature. Go to notification settings for particular app and you can set to show notification icon on status bar. Disabled by default for all apss (I think it should be enabled by default), except Gmail, Dialer and a few others.
Bug I found:
- font size issues. I want to set small fonts and dpi. But some apps, like default camera app, power menu, google feeds when swipe etc has still default large font, experience is terrible
- custom dpi set in developer settings will be reverted after reboot. If you set smaller dpi in phone settings, it will be applied a few seconds after boot, phone starts with default dpi
- AOD does not work, even if enabled, screen will turn off when inactive
I installed via built in ota from Oxygen 11 Global, I got update to ColorOS 12
Just got my first 1+ yesterday and was really impressed with the OOS 11 experience.
All day long. All the magic has gone after the update.
In addition to what was already said, the AOD is flickering terribly.
Perhaps it is caused by the pwm of low frequency.
Lol, I paid 1000 euros for this phone because the software was supposed to be good...
Oh yeah, the CLOCK. What is WRONG with that CLOCK!? LMAO.
I mean look at this ABOMINATION.
WHO DRAWS A CLOCK LIKE THAT? SATAN?!?!??!
Like wtf lol.
I have a new problem. I listen to music while walking with my wireless headphones. The phone is in my pocket. Unknown reason causes the phone to crash.
I feel it's going to be complicated.... At least I have 5G working.
Why would they remove the seconds on the clock feature. This update is horrible all around
anhtin said:
App drawers can only display 4 icons per row. Anyone knows how to change it to 5 per row or more?
Click to expand...
Click to collapse
Get Nova launcher and don't look back?
I'm not even going to upgrade A12, I deleted the 4gig update I got from Oxygen Updater. Oneplus just shoot them self in the foot and will not recover from this. I'll be suprise if they sell 1k Oneplus 10 phone next month.
h8Aramex said:
Oh yeah, the CLOCK. What is WRONG with that CLOCK!? LMAO.
I mean look at this ABOMINATION.
WHO DRAWS A CLOCK LIKE THAT? SATAN?!?!??!
Like wtf lol.
View attachment 5476711
Click to expand...
Click to collapse
Is your phone in 24-hour format? Mine looks normal in 12-hour format but like yours in 24-hour format. I don't use the stock clock app so I hadn't noticed.
ddizzy81 said:
Why would they remove the seconds on the clock feature. This update is horrible all around
Click to expand...
Click to collapse
They didn't. This is only when setting an alarm in the clock app.
Camera goes bananas when zoomed beyond 10x.. See attached
Any custom DPI set in developer options is completely lost after reboot.
Reported by me multiple times and was also seen in previous phones/Android versions.
Hi all, i can't open the icon option in the Launcher and and in the settings too it simply crash and nothing. Anyone as an idea? I just wipe launcher data but nothing.
h8Aramex said:
- Phone stuck in 60hz like 99% of the time.
Click to expand...
Click to collapse
Did you select "High" refresh rate in settings? Mine is at 120hz the vast majority of the time.
I have issues with screen brightness not adjusting to low-light conditions. When setting my phone on my dash mount I have to manually adjust the screen brightness down or go blind, even in dark mode. Worked fine with Oxygen OS 11. Fairly disappointed with the overall quality of this update, and I usually love getting the shiny new OS version update.