Hi,
this is a topic I want to start in order to help the development of more intelligent brightness control for Galaxy S (probably regional variants of it will benefit as well).
It began with my PM to some of kernel DEVs that I've noticed brownish color instead of black on ONE brightness setting. My idea was to omit that one brightness level.
Overnight, I already got two responses. One that it should be no problem and one that the link I sent might lead to fixing the problem I mentioned as well (color correction).
The other, connected to brightness topic, thing I've noticed is that auto control of it is retarded. First, it's too jumpy without any reason (like let's say change of outside brightness) and second it likes to set level that burn the eyeballs. I've never had such problem on my CM Hero.
Here's my original PM:
embrion said:
Hi,
I'm PMing you as the most popular kernels coders.
Long story short: SAMOLED screens like to make black or similar colors brownish at low brightness. I've (and not only me) noticed that there's a step just about min. when it starts to be brown and a next step after that it magically stops. The idea is to omit this step at all or just in auto brightness table. I believe It's doable by using those methods.
The original story begins here from the first half of #522 post
Like I've wrote there, this problem exists in all kernels and all color temperature variants of them + stock one.
If you're interested, please respond me. If not, also respond as I'd like to know if I can count on anything.
Thanks
Click to expand...
Click to collapse
Some links that might help:
[SOLUTION] Fix for minimum screen brightness! [10/13 - adjustable]
Kernel makers, please add the ability to adjust auto brightness.
[APP] Different auto-brightness
Gizmodo - Why iPhone 4 and Android Brightness Controls Are Effectively Useless
My random thoughts:
One option would be fooling the sensor that it is less bright than it is
Another, more proper I believe, it to modify some brightness tables to leave extreme brightness levels to extreme outside light situations. This one would also help skipping this "brown" brightness level as like I said, it looks to be only one level
Color correction MIGHT fix "brown" problem too, but I'm not sure as COLD and WARM kernel variants didn't changed this brown problem (unless colors are optimized only for some of the levels like I've read at VOODOO site)
CM 6 already has such brightness level options in Settings-> CM Settings - > User interface -> Automatic backlight -> Use custom(just checked on my Hero) so probably lot of code can be reused (as I believe there is CM for Galaxy S)
Kernel DEVs, fell free to hijack this thread. It is to help your cooperation (unless each one of you prefer to solve problems on they own ) Btw. don't be offended if I didn't included you in the DEVs list I've sent my PM. It was late and I PMed only those I've noticed that they kernels I've used. All of you are more than welcomed.
Other, please don't post "I cannot see any brown", and those one that can see it, please stop posting about info after first 5 people do
I'm so happy to read this threat. I had posted questions about display and auto brightness a couple of months ago in the questions section but never received any credible responses.
My problem is that when I turn auto brightness on, not only does my display get exceptionally dark, but it becomes very noticeable that e.g. grey turns more brownish. Comparing my display to yet another Galaxy S confirmed my suspicions that this is not they way the display is supposed operate, i.e. compared to mine the other Galaxy stayed a lot brighter in equal lighting conditions and the grey remained grey (instead of brownish-grey like mine). I compared the grey tones of the numeric buttons in the stock Dialer APP to conclude this.
I suspectED the light sensor might be defective, but I have run the test menu on a couple of Galaxies (*#0589#) and the units always display the same values when put next to mine.
You might see why this is bugging me so much, it seems my galaxy's display is not using less battery even though I get less brightness than the others on auto brightness. Unless I manually bump up the brightness to full the colors on my screen look dull (grey turns Brownish, and over all it looks not as alive) as compared to other units. Simply bumping the brightness up is of course not an option, this drain the battery like crazy.
EDIT: I too have tried the various Kernels, hardcore warm and cold, voodoo w/ color fix sadly all to no avail
EDIT2: @embrion The above all doesn't explain why our phones have this problem, but the far majority of Galaxy S phones doesn't. Of course I cannot statistically back this up, but I have not physically seen any other device that gets brown on autobrightness like ours. Any Ideas?
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
embrion said:
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
Click to expand...
Click to collapse
It does not turn brown and appears much brighter in equal lighting w/ auto brightness ON. I edited my post above, please read again if it was unclear before. Thank you!!
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
embrion said:
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
Click to expand...
Click to collapse
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
(Auto)brightness corrections
Original Auto Brightness level is too high & sluggish.
It 's need to fix like a voodoo Brightness level fix (2.1 only).
schiphol said:
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
Click to expand...
Click to collapse
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
embrion said:
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
Click to expand...
Click to collapse
Which CSC code do you have? I mine was originally XEN (Netherlands). The units I tested that did not have the problem were all DBT (german Sim free). Just asked my brother and he says his phone also gets brownish (also XEN). Have to check product codes later, will update then.
Mine is XEE (Orange, Poland)
Supercurio did some tinkering with those settings:
https://github.com/project-voodoo/l...a2/Kernel/drivers/video/samsung/s3cfb_mdnie.c
I suspect this is the file we need to modify;
Code:
mDNIe_data_type mDNIe_UI[]=
{
#ifdef CONFIG_VOODOO_MDNIE
// Voodoo color: optimized UI mode
// reduce the sharpness filter radius to make it much closer
// to the real fuzzyness introduced by the SAMOLED Pentile pattern
// color saturation boost on everything is also disabled because
// it causes harm on stock settings (exaggerated colors)
0x0084, 0x0040,
0x0090, 0x0000,
0x0094, 0x0FFF,
0x0098, 0x005C,
0x009C, 0x0613,
0x00AC, 0x0000,
0x00B4, 0x0A00,
0x00C0, 0x0400,
0x00C4, 0x7200,
0x00C8, 0x008D,
0x00D0, 0x00C0,
END_SEQ, 0x0000,
Any thoughts and datasheet quotations on this? Because seriously I see just random numbers in this.
Some interesting code begins around line 315, but seriously I'm clueless
Another interesting file:
https://github.com/project-voodoo/l...2/Kernel/drivers/video/samsung/s3cfb_tl2796.c
My screen has brownish/reddish deep grays on brightness settings under 16-17%. However when I set it over 17% and use screen filter app deep grays are NOT brownish/reddish, this means there is definitely something with lower brightness settings.
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
embrion said:
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
Click to expand...
Click to collapse
@embrion so did you pm Supercurio? What did he say? It's too bad this color/sharpness fixing will probably be put on a back burner what with Gingerbread and CM7 development. D*RN IT! I tried an app in the market that is more precise than the built-in slider. Try it out Adjbrightness (free). I punched in all values possible between 2-255. The tipping point (where the browness is gone) lies at when you go from 34 to 35. Is this the same for everyone suffering from this problem. Please remove all apps like e.g. 'screen filter' before you try!
For me crucial step is going from
/ # echo 53 > /sys/devices/platform/s3cfb/spi_gpio.3/spi3.0/backlight/s5p_bl/brightness
to 54, however I'm running trasig's voodoo.
While 54 and over looks ok, lower values are... reddish/pinkish.
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
embrion said:
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
Click to expand...
Click to collapse
No fix there, just a different behaviour...
Would like to see this in next voodoo, might even write some simple user interface for this.
I have an idea but its not quite clear yet, however if this patch will let most users 'calibrate' their screens.. I think I'll give simple GUI a shot.
@embrion
Could you perhaps upload the screenshots you talked about in R64's thread so I can replicate. Because of different kernels and settings I want to try and establish beyond a doubt that the problem we're having is of the same nature and root cause. Thanks
This wont be visible on screenshots. You need to make a photo, problably with DSLR and know how to do it
I'll try it today and let you know
According to Supercurio, this is Samsung's color profile deviation, not SAMOLED fault itself.
Anything software broken can be software fixed
@schiphol, xan: yes, it won't be noticed at screenshots, I've already compared R64's black notification bar screenshots and my brown ones. Color picker showed a little difference in color (R:24, G:24, B:24 or something VS RGB: 0, 0, 0 - true black). Such difference should'n be visible and is not visible from software screenshot point of view but Samsung color profile makes 24,24,24 brown IN REAL LIFE while 0,0,0 is still black. I repeat, they're both black at screenshots no matter which brightness level is set, but only 0,0,0 black doesn't look like brown when viewed by bare human eye. Samsung profile at this brightness treats 24,24,24 as brown while it should as black.
--edited--
You're right, Xan. It's just another, ( but 1337 ) method of changing the brightness. I thought there's a plaintext table with levels accessible to change by hand
Hi Ok I have kept the brightness at 2 clicks to the right from minimum to stop grey from looking grey-brown all through today. Now my display accounts for 95% of the battery usage, it has never been this high before. The battery is at 25% whilst I only used the display for 44 minutes.
Thats ridiculous battery drainage and should be taken into careful consideration when a fix is developed for this issue. Are you guys having a similar experience??
Hello, I'm looking for a way to reduce the screen brightness even more than currently possible. It is too bright for me to read at night at the moment.
Is there some way?
Check the market. There are way too many apps out there to do the task you wanted.
via xda app
I already have but none of the applications on the market allow me to make the screen really dark. It's still pretty bright even after using programs like AdjBrightness or ScreenDim.
I'm curently using Screen Filter but that only puts a grey overlay over the Displayed Applications.
Try this one: https://market.android.com/details?id=mobi.pruss.superdim
I haven't tested it though.
Please use the Q&A Forum for questions Thanks
Moving to Q&A
Already tried that, it is no darker than the lowest setting from the built in menu. Other Android devices can go much darker. I was hoping, that it is just a kernel issue or something like this.
How is it that sreec filter doesn't do exactly what you want? It gets very dark, doesn't it?
One other possibility would be to use Cyanogenmod or any other Rom that lets you set the light sensor levels manually. In my experience, this feature seems to save lots of energy. IF you manually set those levels to very dark, you may get what you are looking for ...
I know this is possible in CM9's display settings, but I'm currently running AOKP. Is there any other way to lower the minimum screen brightness?
I've given Tasker root permissions, approved it as a device administrator, and approved it as an accessibility service. Still, when I use a task to lower the brightness to very low levels, the brightness will only hold for a fraction of a second before it ramps up to the factory minimum.
So is there some system component I can modify to allow lower brightness, or is this only available as a ROM control like in CM9?
byrong said:
So is there some system component I can modify to allow lower brightness, or is this only available as a ROM control like in CM9?
Click to expand...
Click to collapse
FWIW the lowest possible brightness setting can't be altered via the CM9 settings, only the auto brightness levels, both sensor input levels ("bins") and the brightness level associated with that input/bin. The minimum value of 19 for the lowest slot can't be lowered further. There are other display parameters (related to brightness) that can also be altered in the CM9 settings, but it won't accept a value less than 19.
Edit: I see from a link in your sig that you're familiar with the custom levels
Yes we can do it in the frameworks to go lower than 19. I did it on other phones. I'm not sure why it hasnt been done yet for nexus, and ive been too lazy myself.
But we can even take it down to zero or 4-5 etc so its much dimmer at night. Its on my to do list.
Also i posted some kernel code in a similar thread where this question was already asked. But mod the framework is much quicker.
RogerPodacter said:
Yes we can do it in the frameworks to go lower than 19. I did it on other phones. I'm not sure why it hasnt been done yet for nexus, and ive been too lazy myself.
But we can even take it down to zero or 4-5 etc so its much dimmer at night. Its on my to do list.
Also i posted some kernel code in a similar thread where this question was already asked. But mod the framework is much quicker.
Click to expand...
Click to collapse
I should have clarified more clearly that my post above was regarding doing it via the CM settings.
I'll mod mine...at some point...but like you, too lazy for something that won't blow me away.
You want this app, works great https://play.google.com/store/apps/...yZy5wcm9qZWN0dm9vZG9vLmRpc3BsYXlmaWx0ZXIiXQ..
Sent from my Galaxy Nexus GSM using Tapatalk expect possible typos
I'm an idiot; I just found it in AOKP. It's in the custom backlight settings.
My experience does not mirror you guys. When I decrease the "screen dim level" in the custom brightness settings, it applies globally. I just did it in AOKP the same way I used to in CM9 and now with Tasker I've taken the screen all the way down to 1
Is there any way to decrease the minimum brightness on stock?
aidanbree said:
Is there any way to decrease the minimum brightness on stock?
Click to expand...
Click to collapse
Yes with above linked app. I confirm it works on stock
Sent from my Galaxy Nexus using Tapatalk
I've used a similar app called Screen Filter. My only problem with these types of apps is that I find the black/gray filter they use greatly decreases contrast at low brightness levels (more so than a "true" brightness level at an equivalent setting). Still, if you are running a setup in which they are your only option, they certainly beat having nothing.
The problem with using a screen filter is that it limits the maximum brightness when in sunlight.
I only want to affect the minimum as it is too bright.
Has anyone been able to do this on a stock rom? I too think that the minimum brightness is too high, but I don't want to use the above linked program because it also affects the maximum brightness too. I would like to be able to set custom light levels as per cm9/cm10 and pretty much any custom ROM right now, albeit with my stock ROM. Any flashable zips out there?
Cheers,
Dan
Hey all,
In my eternal quest to get my Nexus running right and lag free i've been playing with Roms and Kernels for weeks now, and have settled on AOKP which is brilliant, and the GlaDOS kernel which has some extra options I like.
The thing that's got me stumped is the colour multipliers.
I have tried searching for definitive answers but all the threads mentioning this are confusing for someone as thick as me.
In AOKP it has Color Gamma tuning set at RGB 60 60 60, and Color Multipliers set at RGB 0.46 0.46 0.46. Now I like increasing these as that makes the screen readable in sunlight, but have read some disturbing threads suggesting that by raising them, I am risking damaging or degrading my screen.
This brings me onto GlaDOS kernel. The settings on that are Color Multipliers set at RGB 2.0 2.0 2.0 and are even brighter than the AOKP kernel.
Can anyone explain in simple terms how these settings will affect my screen and whether there is an accepted safe norm to these settings that wont kill my screen in a matter of months.
Appreciate any and all advice, and any tips on how I could maybe set up a higher setting for outdoors and lower for indoors maybe which I could set up on a widget or shortcut?
Cheers,
Biff.
I also have been wondering why there is such a huge variation in the way multipliers/offsets/gammas are set, different kernels and roms use a variety of different values for each setting that I'm slightly confused by these differences, however, I like the way leankernel with lean tweaks sets these values and have gotten used to how it works on that.
Really like this thread, can't wait to see some more in depth explanations on this and the differences
Sent from my Galaxy Nexus using Tapatalk 2
Cheers for the reply
I might have to try Lean Kernel see how that pans out.
Just figured it would be good to get some informed opinions on what and what not to do when it comes to colour and gamma settings to help people get to grips with the settings.
Also figured it would be good to get advice from those in the know to save on people like me buffering up my screen lol
Fingers crossed we get some discussion going
Hi Guys,
Not sure if this is covered anywhere or if it's even an issue or maybe Percieved issue.
Between Flashing Cooked ROM's and Stock ROM's etc it always seems that the display while using stock ROM's doesn't seem as bright / vibrant - it always seems a bit duller at max Brightness, the Whites dont 'Pop' off the screen as much.
Is there any truth to this or is it just me? If it is the case what are the Chef's doing to make this so and can i do it to a Stock ROM?
Cheers
Paul
it can depend on 2 things
- kernel used -> some kernels disable or can disable "adaptive brightness" and modify color values
- the value set for auto-brightness in framework-res.apk. Most devs keep the standard values from google, I usually find them "too boring and dark" so i modify them.
So not your perception - you are quite correct
Thyrus said:
it can depend on 2 things
- kernel used -> some kernels disable or can disable "adaptive brightness" and modify color values
- the value set for auto-brightness in framework-res.apk. Most devs keep the standard values from google, I usually find them "too boring and dark" so i modify them.
So not your perception - you are quite correct
Click to expand...
Click to collapse
Ah thanks for the response. Though if i understand correctly this just affects the 'level' at which the brightness will be set at certain detected light levels on the Auto Brightness settings?
What i mean is that if i just go in and turn off Auto Brightness and slide it up to the Max - the Cooked ROM's always seem more vibrant and brighter.
Also is there anything that i'd be able to do to a Stock (rooted) ROM to get this extra Brightness?
Cheers
Paul
Thyrus said:
it can depend on 2 things
- kernel used -> some kernels disable or can disable "adaptive brightness" and modify color values
- the value set for auto-brightness in framework-res.apk. Most devs keep the standard values from google, I usually find them "too boring and dark" so i modify them.
So not your perception - you are quite correct
Click to expand...
Click to collapse
More details on this please?
Edit: nevermind, found it.
Mind Sharing Your findings MS? Or could someone else please help?
Cheers
Paul
Here's something about content adaptive brightness:
http://forum.xda-developers.com/showthread.php?p=28126141
You can turn it off with Franco's kernel app or with Supercurio's Voodoo display app, available in his thread here on xda.
paulrgod said:
Mind Sharing Your findings MS? Or could someone else please help?
Click to expand...
Click to collapse
Here it is. I had no chance yet to try it, but i believe it should work.
Thanks guys - went for Francos Kernel and can now adjust the levels with the tool