Related
Hi,
this is a topic I want to start in order to help the development of more intelligent brightness control for Galaxy S (probably regional variants of it will benefit as well).
It began with my PM to some of kernel DEVs that I've noticed brownish color instead of black on ONE brightness setting. My idea was to omit that one brightness level.
Overnight, I already got two responses. One that it should be no problem and one that the link I sent might lead to fixing the problem I mentioned as well (color correction).
The other, connected to brightness topic, thing I've noticed is that auto control of it is retarded. First, it's too jumpy without any reason (like let's say change of outside brightness) and second it likes to set level that burn the eyeballs. I've never had such problem on my CM Hero.
Here's my original PM:
embrion said:
Hi,
I'm PMing you as the most popular kernels coders.
Long story short: SAMOLED screens like to make black or similar colors brownish at low brightness. I've (and not only me) noticed that there's a step just about min. when it starts to be brown and a next step after that it magically stops. The idea is to omit this step at all or just in auto brightness table. I believe It's doable by using those methods.
The original story begins here from the first half of #522 post
Like I've wrote there, this problem exists in all kernels and all color temperature variants of them + stock one.
If you're interested, please respond me. If not, also respond as I'd like to know if I can count on anything.
Thanks
Click to expand...
Click to collapse
Some links that might help:
[SOLUTION] Fix for minimum screen brightness! [10/13 - adjustable]
Kernel makers, please add the ability to adjust auto brightness.
[APP] Different auto-brightness
Gizmodo - Why iPhone 4 and Android Brightness Controls Are Effectively Useless
My random thoughts:
One option would be fooling the sensor that it is less bright than it is
Another, more proper I believe, it to modify some brightness tables to leave extreme brightness levels to extreme outside light situations. This one would also help skipping this "brown" brightness level as like I said, it looks to be only one level
Color correction MIGHT fix "brown" problem too, but I'm not sure as COLD and WARM kernel variants didn't changed this brown problem (unless colors are optimized only for some of the levels like I've read at VOODOO site)
CM 6 already has such brightness level options in Settings-> CM Settings - > User interface -> Automatic backlight -> Use custom(just checked on my Hero) so probably lot of code can be reused (as I believe there is CM for Galaxy S)
Kernel DEVs, fell free to hijack this thread. It is to help your cooperation (unless each one of you prefer to solve problems on they own ) Btw. don't be offended if I didn't included you in the DEVs list I've sent my PM. It was late and I PMed only those I've noticed that they kernels I've used. All of you are more than welcomed.
Other, please don't post "I cannot see any brown", and those one that can see it, please stop posting about info after first 5 people do
I'm so happy to read this threat. I had posted questions about display and auto brightness a couple of months ago in the questions section but never received any credible responses.
My problem is that when I turn auto brightness on, not only does my display get exceptionally dark, but it becomes very noticeable that e.g. grey turns more brownish. Comparing my display to yet another Galaxy S confirmed my suspicions that this is not they way the display is supposed operate, i.e. compared to mine the other Galaxy stayed a lot brighter in equal lighting conditions and the grey remained grey (instead of brownish-grey like mine). I compared the grey tones of the numeric buttons in the stock Dialer APP to conclude this.
I suspectED the light sensor might be defective, but I have run the test menu on a couple of Galaxies (*#0589#) and the units always display the same values when put next to mine.
You might see why this is bugging me so much, it seems my galaxy's display is not using less battery even though I get less brightness than the others on auto brightness. Unless I manually bump up the brightness to full the colors on my screen look dull (grey turns Brownish, and over all it looks not as alive) as compared to other units. Simply bumping the brightness up is of course not an option, this drain the battery like crazy.
EDIT: I too have tried the various Kernels, hardcore warm and cold, voodoo w/ color fix sadly all to no avail
EDIT2: @embrion The above all doesn't explain why our phones have this problem, but the far majority of Galaxy S phones doesn't. Of course I cannot statistically back this up, but I have not physically seen any other device that gets brown on autobrightness like ours. Any Ideas?
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
embrion said:
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
Click to expand...
Click to collapse
It does not turn brown and appears much brighter in equal lighting w/ auto brightness ON. I edited my post above, please read again if it was unclear before. Thank you!!
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
embrion said:
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
Click to expand...
Click to collapse
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
(Auto)brightness corrections
Original Auto Brightness level is too high & sluggish.
It 's need to fix like a voodoo Brightness level fix (2.1 only).
schiphol said:
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
Click to expand...
Click to collapse
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
embrion said:
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
Click to expand...
Click to collapse
Which CSC code do you have? I mine was originally XEN (Netherlands). The units I tested that did not have the problem were all DBT (german Sim free). Just asked my brother and he says his phone also gets brownish (also XEN). Have to check product codes later, will update then.
Mine is XEE (Orange, Poland)
Supercurio did some tinkering with those settings:
https://github.com/project-voodoo/l...a2/Kernel/drivers/video/samsung/s3cfb_mdnie.c
I suspect this is the file we need to modify;
Code:
mDNIe_data_type mDNIe_UI[]=
{
#ifdef CONFIG_VOODOO_MDNIE
// Voodoo color: optimized UI mode
// reduce the sharpness filter radius to make it much closer
// to the real fuzzyness introduced by the SAMOLED Pentile pattern
// color saturation boost on everything is also disabled because
// it causes harm on stock settings (exaggerated colors)
0x0084, 0x0040,
0x0090, 0x0000,
0x0094, 0x0FFF,
0x0098, 0x005C,
0x009C, 0x0613,
0x00AC, 0x0000,
0x00B4, 0x0A00,
0x00C0, 0x0400,
0x00C4, 0x7200,
0x00C8, 0x008D,
0x00D0, 0x00C0,
END_SEQ, 0x0000,
Any thoughts and datasheet quotations on this? Because seriously I see just random numbers in this.
Some interesting code begins around line 315, but seriously I'm clueless
Another interesting file:
https://github.com/project-voodoo/l...2/Kernel/drivers/video/samsung/s3cfb_tl2796.c
My screen has brownish/reddish deep grays on brightness settings under 16-17%. However when I set it over 17% and use screen filter app deep grays are NOT brownish/reddish, this means there is definitely something with lower brightness settings.
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
embrion said:
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
Click to expand...
Click to collapse
@embrion so did you pm Supercurio? What did he say? It's too bad this color/sharpness fixing will probably be put on a back burner what with Gingerbread and CM7 development. D*RN IT! I tried an app in the market that is more precise than the built-in slider. Try it out Adjbrightness (free). I punched in all values possible between 2-255. The tipping point (where the browness is gone) lies at when you go from 34 to 35. Is this the same for everyone suffering from this problem. Please remove all apps like e.g. 'screen filter' before you try!
For me crucial step is going from
/ # echo 53 > /sys/devices/platform/s3cfb/spi_gpio.3/spi3.0/backlight/s5p_bl/brightness
to 54, however I'm running trasig's voodoo.
While 54 and over looks ok, lower values are... reddish/pinkish.
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
embrion said:
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
Click to expand...
Click to collapse
No fix there, just a different behaviour...
Would like to see this in next voodoo, might even write some simple user interface for this.
I have an idea but its not quite clear yet, however if this patch will let most users 'calibrate' their screens.. I think I'll give simple GUI a shot.
@embrion
Could you perhaps upload the screenshots you talked about in R64's thread so I can replicate. Because of different kernels and settings I want to try and establish beyond a doubt that the problem we're having is of the same nature and root cause. Thanks
This wont be visible on screenshots. You need to make a photo, problably with DSLR and know how to do it
I'll try it today and let you know
According to Supercurio, this is Samsung's color profile deviation, not SAMOLED fault itself.
Anything software broken can be software fixed
@schiphol, xan: yes, it won't be noticed at screenshots, I've already compared R64's black notification bar screenshots and my brown ones. Color picker showed a little difference in color (R:24, G:24, B:24 or something VS RGB: 0, 0, 0 - true black). Such difference should'n be visible and is not visible from software screenshot point of view but Samsung color profile makes 24,24,24 brown IN REAL LIFE while 0,0,0 is still black. I repeat, they're both black at screenshots no matter which brightness level is set, but only 0,0,0 black doesn't look like brown when viewed by bare human eye. Samsung profile at this brightness treats 24,24,24 as brown while it should as black.
--edited--
You're right, Xan. It's just another, ( but 1337 ) method of changing the brightness. I thought there's a plaintext table with levels accessible to change by hand
Hi Ok I have kept the brightness at 2 clicks to the right from minimum to stop grey from looking grey-brown all through today. Now my display accounts for 95% of the battery usage, it has never been this high before. The battery is at 25% whilst I only used the display for 44 minutes.
Thats ridiculous battery drainage and should be taken into careful consideration when a fix is developed for this issue. Are you guys having a similar experience??
Hey guys, does anyone know if there is an option to change the color temp of the screen? I remember hearing the sgs2 had a feature to change it built-in. The color temp is a little too warm in my opinion. It might be on purpose to conserve battery but I would prefer it to be cooler (the whites are too yellow).
On my SGS2 I had an app called Screen Adjuster. It would let you change RGB settings. That might help, if it works with ICS. Other than that I know some ROMs for the SGS2 had different screen "modes" like Dynamic, Movie, etc.
Did the app work well for you? I'll give it shot man, thx.
On the SGS2 it worked amazingly well. Made the colors less saturated and more realistic. Of course, that's with the SAMOLED+ screen I think. I'm not sure how it will work with the Nexus screen. Different technologies, right? If you search the SGS2 threads for "screen adjuster" you can see some people's recommended settings for the SGS2. Maybe you can use that as a starting point and work from there? Good luck.
Yea I'm not sure how it'll react since the nexus uses a pentile arrangement while the sgs2 uses rgb. I've actually gotten used to it and don't mind it at all now. Haha go figure right. I guess my eyes just needed to adjust from switching from my vibrant with voodoo color which looked noticeably cooler.
5/10
Darthbull said:
On my SGS2 I had an app called Screen Adjuster. It would let you change RGB settings. That might help, if it works with ICS. Other than that I know some ROMs for the SGS2 had different screen "modes" like Dynamic, Movie, etc.
Click to expand...
Click to collapse
Sorry to resurrect a dead thread, but I thought it was worth nothing that I tried the Screen Adjuster app, and while it worked for adjusting the calibration/color temp of my screen, it seemed to make my phone VERY laggy. Does anyone know of another app that will do the same thing but apply the settings permanently in some way without having the run the app in the background? Maybe with root?
Well, after 5 months of looking out for the best values, I've experimented and all and found out these to be the best. Even at lowest brightness, the screen is crisp and clear just like it's supposed to be.
People who have the Purple Screen issue, I highly recommend you use these values.
Requirements -
1. Franco Kernel Updater (TKT wouldn't give that much brightness/crispyness to the screen)
2. ICS Gradient Fix (Check Signature)
3. Franco Kernel
First up, flash Franco's latest kernel.
Secondly, make sure you don't have any 2 or more applications which have Color Control options (Like, Franco Kernel Updater and TKT - Remove TKT and stay with Franco). If you do have 2 or more installed, please set all values to default on all applications including Franco's. (In TKT, click on menu and select reset preferences and reboot).
Third, fire up Franco Kernel Updater and get to the CC options and set these :
Color Multipliers -
Red - 280
Green - 292
Blue - 350
Gamma -
Red - 4
Green - 0
Blue - 9
Disable Contrast Adaptive Brightness - Yes (Tick)
Contrast Control : -24
OMAP Gamma - 1.2
These values work BEST with MoDaCo's JB Build. Tested on Jr1, Jr.1.1, Jr2.
Please note : This is simply a band aid, not a total fix. The purple screen and grain issue is probably a hardware issue. This settings are extremely crisp on my device. You need to get adapted to them.
Thanks to -
1. Franco for his amazing kernel and application.
2. Morfic for introducing contrast control into the kernel world and of course for his kindness. (You're the sweetest developer I've talked to).
Best of luck with these settings guys!
Please, don't forget to click "Thanks"!
It made everything look over-saturated for me.. plus, is it safe to jack up the settings like this?
It did improve the grainy screen on low brightness problem, though.
Well, i think the best values i've EVER Seen.
Oh dear, so f****ng awesome.
via Google Galaxy Nexus
Made my eyes hurt.. Too cold.. I'm trying to get my screen as close to 6500k as possible.
Sent from my Galaxy Nexus using Tapatalk 2
Thank you for this! By far the best optimization of colors I've ever seen. Maybe colors are a bit over-saturated but thats how Super AMOLED should produce.
Doesn't lacking the values up that high create burn in???
Sent from my Galaxy Nexus using xda premium
craigbailey1986 said:
Doesn't lacking the values up that high create burn in???
Sent from my Galaxy Nexus using xda premium
Click to expand...
Click to collapse
Try reducing every multiplier value by 40. 280 to 240, 292 to 252 and 300 to 260.
This can never be an all-in-one "fix" because of the way screen technology works. Everyone's screen will have different degrees of the problem itself (purple tint & grain), on top of that they will all have a slightly different color temperature, contrast level, saturation etc. By providing the values that worked for you, you're just going to have a thread where half the people think it looks great, half think it looks awful, and everyone thinks everyone else is crazy.
A better idea might be to describe the steps you took to arrive at your own numbers, things you looked for, how you tweaked them to get to the best values.
Look Excellent to me - Screen absolutely Pops, so vivid and the gradient issues are not visible.
Thanks so much!
Those high values are gonna kill your screen
OP settings work well for me (similar to my 200 215 280, -2 0 10, -23, CAB off), but OMAP always makes things worse IMO. With OMAP at 1.2 I instantly see banding again where with it off the gradients are smooth. OP settings with OMAP 1.0 are excellent however, reducing the magenta and yellowing I was seeing with my others. I am worried about the burn-in though..
What's this about burn in? Do these settings cause it?
I sort-of mispoke. Burn-in is possible, but high multipliers are more worried to wear out those pixels/degrade them faster.
Edit: I'm going for more of a "Trinity Blue" sort of solution now: 215 235 280, -2 0 15, -24, CAD off, OMAP unset. Still trying to find that balance that gets rid of the magenta/yellow at all points.
Okay guys try out 180,192 and 250 as the color multipliers. No burn issues then. I'm on it right now. Its great!
I'm using Trinity kernel, TKT, and Display Tester Pro for calibration. The gamma test shows that my particular settings should be red=2, green=3, blue=2. The color gamma settings are not relative to one another and are not "mixed together" for adjusting color. Each one is a separate adjustment for that color's correct level of brightness for midtones, relative to darkest and lightest levels. Together, the three settings add up to correct gray brightness levels, not to correct gray colorlessness.
If you look at a chart containing only black, 50% gray, and white, the color multipliers should be adjusted to remove any trace of color tint from the gray. The easiest way to do it is set the weakest color to 200 and reduce the other two colors until the gray has no color tint at all. The properly set color gamma settings, on the other hand, should make the 50% gray have the correct lightness level.
If you have yellow tint, there's not enough blue. Magenta tint means not enough green. Cyan tint, not enough red.
The color multipliers, unlike the gamma settings, are relative to one another. Once you have them set correctly relative to one another, moving them all up or all down together pnly changes the overall brightness of the display. The wrong overall brightness level will remove detail from either the black end or the white end. Too much brightness is also bad for the screen, not to mention battery drain.
So anyway I'll shut up now and I hope everyone gets their screens looking perfect.
gsm gnex / cm9 / trinity / 1420 MHz
for whatever reason trinity seems to be giving me better screen color, but im sure I could do the same with franco, anyways, my gamma settings are untouched, I found that modifying the color to these values makes the purple tint go away for me:
Red:135
Green:135
Blue:190
Trinity Contrast -15 to -25
Have you tried adjusting it for 18% gray? I can nail it pretty close with 180,150,190 and 8,0,8 but gamma is a complete ***** on this display...
strumcat said:
I'm using Trinity kernel, TKT, and Display Tester Pro for calibration. The gamma test shows that my particular settings should be red=2, green=3, blue=2. The color gamma settings are not relative to one another and are not "mixed together" for adjusting color. Each one is a separate adjustment for that color's correct level of brightness for midtones, relative to darkest and lightest levels. Together, the three settings add up to correct gray brightness levels, not to correct gray colorlessness.
If you look at a chart containing only black, 50% gray, and white, the color multipliers should be adjusted to remove any trace of color tint from the gray. The easiest way to do it is set the weakest color to 200 and reduce the other two colors until the gray has no color tint at all. The properly set color gamma settings, on the other hand, should make the 50% gray have the correct lightness level.
If you have yellow tint, there's not enough blue. Magenta tint means not enough green. Cyan tint, not enough red.
The color multipliers, unlike the gamma settings, are relative to one another. Once you have them set correctly relative to one another, moving them all up or all down together pnly changes the overall brightness of the display. The wrong overall brightness level will remove detail from either the black end or the white end. Too much brightness is also bad for the screen, not to mention battery drain.
So anyway I'll shut up now and I hope everyone gets their screens looking perfect.
gsm gnex / cm9 / trinity / 1420 MHz
Click to expand...
Click to collapse
arzbhatia said:
Okay guys try out 180,192 and 250 as the color multipliers. No burn issues then. I'm on it right now. Its great!
Click to expand...
Click to collapse
It's been discussed few times already - going above 200 can lead to screen burn in. On SAMOLED screens blue color wear out first and peeps really shouldn't touch this setting. Better set lower red/green values. Screen will look a bit darker so don't cranck up contrast too much, -10 should be good enough.
herzzreh said:
Made my eyes hurt.. Too cold.. I'm trying to get my screen as close to 6500k as possible.
Sent from my Galaxy Nexus using Tapatalk 2
Click to expand...
Click to collapse
look at the graphs.
http://forum.xda-developers.com/showpost.php?p=29037317&postcount=1
herzzreh said:
Have you tried adjusting it for 18% gray? I can nail it pretty close with 180,150,190 and 8,0,8 but gamma is a complete ***** on this display...
Click to expand...
Click to collapse
You can see where your gamma should by by installing the free version of Display Tester from the Play Store. Go to Color, Gamma, and slide the gray screen to the left to see the red page. Find the vertical bar that most closely matches the red bacground. The number on that bar is where your gamma should be set for that color. Mine is spot on at 2.3. Then slide to green page and do the same. Then the blue page. My green gamma reading is 2.8, meaning it isn't quite as bright as the red or blue, so I have to turn it up a hair. My blue is good at 2.3. The adjustment sliders in TKT only give me whole-number choices, so I get as close as possible with 2, 3, 2. I'm just guessing there, since TKT doesn't have normal gamma increments. Anyway good luck taming your gamma.
galaxy nexus (gsm) / cm9 / trinity @ 1.4GHz
can somebody share their CM10 setting for the display light control please.
i find that is it to bright when in a dark room,what setting should i change to lower the screen auto brightness ?
thanx
I am also interested as I would like to decrease the screen's battery usage.
every setting will be personal, as testing conditions and displays always differ. experiment yourself, dont go over the stock limits and if you don't like your experiment's result, reset to default and start over.
search about gamma color control to know what it does.
and there's a sticky on a colorabotive effort to find the best setting in general subforum, i think. no need to start a new thread over this.
sent from my i9250
A friend of mine got a little problem.
His screen went "crazy" , it displayed a "negative" effect on colours (I think like the negative effect that photos editor have) for a while, and then turn back by default (not the values he set in the first time through trickster mod).
My question is, what problemi is this? Do someone have encoutered this? Is it a good idea to lower the values of the screen?
he got
-15
0
-4,0,5
240 245 275
Xenon Hd and Lean Kernel
AkaGrey said:
A friend of mine got a little problem.
His screen went "crazy" , it displayed a "negative" effect on colours (I think like the negative effect that photos editor have) for a while, and then turn back by default (not the values he set in the first time through trickster mod).
My question is, what problemi is this? Do someone have encoutered this? Is it a good idea to lower the values of the screen?
he got
-15
0
-4,0,5
240 245 275
Xenon Hd and Lean Kernel
Click to expand...
Click to collapse
Here is a post by marhensa that might help you decide regd colors.
Be careful with too high colors as warned below.
marhensa said:
actually, every device suffers different screen defect.. in its own degree.
some suffers the yellow which too strong.. (yellowish)
some suffers the purplish color..
at its own degree.
so my opinion is,
it's better to find out the correct RGB combination value of your device (and also it's up to your personal taste)
mine is R=140, G=136, B=200.
but, like i said, it may looks weird when it's applied to yours..
one thing for sure is,
do not set it too high.
200 is enough.
(at least it's what cm rom says when we tried to tune the color combination)
more than 200 and then your color could be "drained" faster,
also your screen could "burned" much faster, because it's amoled..
cmiiw.
---
Sent from Android Device
Click to expand...
Click to collapse
Hope this helps
If turn my individual color gamma values too low in trickster mod I get a completely green screen. I've never had it happen any other time and my screen looks amazing. I figure setting the values that low equates to being an invalid value. I don't think anything is wrong.