Develop Bugs

Still confused about how to install Magisk/Automagisk on my HTC 10

I have been trying to Google this but am a little confused on all the steps I need to (and don't need to) take at this point, especially since I am a little behind. So I wanted to ask for help on forums, if anyone is willing to give some advice on this.
First of all, I have a Sprint version of the HTC 10. I don't know if that matters or not (I recall back when I was trying to figure out the original Magisk, someone mentioned that a Sprint model HTC 10 could be an issue, but I am not sure why).
Also, so far all I have done in terms of rooting it is:
- Use the HTC Bootloader unlock
- Install TWRP Touch Recovery with the option of not modifying the system partition (From what I understand, this would cause it to be a temporary install that would go away after a reboot, but it seems to have stayed installed)
- Perform backups with TWRP
- Flash the SuperSU zip with TWRP
And... that's it, still on stock ROM and everything, didn't install anything else that depends on root like Xposed or whatever (That wasn't automatically installed by TWRP or SuperSU or something was it?). I am pretty sure root access is working because two of my apps (Titanium Backup and Chase) tried to request it, and I can see those requests in SuperSU, but other apps don't seem to act like I am rooted. Namely, Google Pay.
From what I understand, Google Pay is not supposed to work if you have root due to that SafetyNet API. However, when I start Google Pay, I see no error message or anything, it seems to work. Granted, I haven't added a credit card to it yet, does the error only happen when you try to make a payment or try to add a card or something? Or should I see it on starting the app? Did I somehow inadvertently setup my phone in a way where root is not being detected?
I also seem to be getting conflicting information on how I should install everything. The guide I followed for rooting my phone said to install SuperSU by flashing the zip, not through the app store.... but the guide for Magisk seems to claim to uninstall SuperSU and install phh's Superuser from the app store. Is there a reason I should do this one way, or another?
Also, all the guides for Magisk say that it is heavily recommended that I reset my phone to stock system, and I really can't reset the data on my phone. Can it be done without erasing anything? I am unclear what resetting to "stock system" would do exactly.
It sounds a little too simple: Uninstall SuperSU and install Superuser (though the method I should do it through is not clear), flash Magisk through TWRP, and then flash AutoMagisk through TWRP. I feel like I am definitely forgetting steps. That, and if somehow I am getting past SafetyNet with Android Pay I don't want to mess with something that might break however I managed to pull it off.
Another worry is breaking my cellular radio. I remember that SuperSU for a while did something (or rather, didn't do something with encryption that the HTC 10 needed which resulted in the cellular radio not working once it was flashed, and that for a while there was a special fork of SuperSU for HTC 10 phones to fix this until the main SuperSU app implemented it. I have no idea if Superuser or Magisk also could cause this issue. Does anyone have any idea?
Oh, and finally, my phone is complaining that an update is available, has been complaining for a while, update 1.80.651.6. Can I safely install this OTA update while rooted? Will it remove or break root if I do? And would it be recommended to install it now before I mess with Superuser and Magisk, or after?

Ummm, anyone?

Cyber Akuma said:
Ummm, anyone?
Click to expand...
Click to collapse
Its all there in the op of the magisk thread.

I read that thread, as I said, I still don't understand some parts.

Cyber Akuma said:
Ummm, anyone?
Click to expand...
Click to collapse
Have you tried posting in the dedicated Magisk thread?

Try installing leedroid nightly latest it has magisk available when you install rom

i did not try it, till now. I read something a few weeks ago.
But in the magisk thread the op said something that SuperSu is not the supported SU method? only phh superuser?!
I would ask the question in magisk thread.

Firstly: You ask a lot of semi-related questions, a lot of these are already answered, out there, in the appropriate threads.
Let me systematically try to answer your questions
What you have done:
- Use the HTC Bootloader unlock
- Install TWRP Touch Recovery with the option of not modifying the system partition (From what I understand, this would cause it to be a temporary install that would go away after a reboot, but it seems to have stayed installed)
- Perform backups with TWRP
- Flash the SuperSU zip with TWRP
Click to expand...
Click to collapse
When you install the TWRP recovery, you actually install it to the recovery partition of your device.
the option the "not modify system" has nothing to do with installing TWRP, but with installing other mods/roms
It's there so you can make a backup without modifying the system partition, that way you can go back to a working isntall if you do happen to mess something up.
And... that's it, still on stock ROM and everything, didn't install anything else that depends on root like Xposed or whatever (That wasn't automatically installed by TWRP or SuperSU or something was it?). I am pretty sure root access is working because two of my apps (Titanium Backup and Chase) tried to request it, and I can see those requests in SuperSU, but other apps don't seem to act like I am rooted. Namely, Google Pay.
From what I understand, Google Pay is not supposed to work if you have root due to that SafetyNet API. However, when I start Google Pay, I see no error message or anything, it seems to work. Granted, I haven't added a credit card to it yet, does the error only happen when you try to make a payment or try to add a card or something? Or should I see it on starting the app? Did I somehow inadvertently setup my phone in a way where root is not being detected?
Click to expand...
Click to collapse
SuperSu *should* break safetney and thus should break android pay, as Chainfire says in the following thread: http://forum.xda-developers.com/apps/supersu/supersu-safetynet-android-pay-t3298115
"In case any SuperSU-rooted device passes SafetyNet, that is a bug in SafetyNet, not a feature of SuperSU."
I also seem to be getting conflicting information on how I should install everything. The guide I followed for rooting my phone said to install SuperSU by flashing the zip, not through the app store.... but the guide for Magisk seems to claim to uninstall SuperSU and install phh's Superuser from the app store. Is there a reason I should do this one way, or another?
Click to expand...
Click to collapse
Installing SuperSu trough TWRP installs the dependencies (the actual root) and the application (which just manages the root access), the magisk guide tells you to first flash the preferred root (SuperSu or SuperUser phh's) trough recovery and then install the correct manager app trough the playstore.
This is probably so John doesn't have to keep on updating his zips everytime the makers of the manager apps update their apps, users can just download the latest version.
Also, all the guides for Magisk say that it is heavily recommended that I reset my phone to stock system, and I really can't reset the data on my phone. Can it be done without erasing anything? I am unclear what resetting to "stock system" would do exactly.
Click to expand...
Click to collapse
Resetting to stock is important for 2 reasons:
1. it cleans out all "old" root apps and methods
2. it cleans up a patched boot.img (kernel)
Then again, if you haven't flashed any other mods, you would probably be safe to install magisk on your rom.
One important thing everyone will always tell you: make a backup! (make a nandroid)
To do this, boot to TWRP and choose "backup" make sure to select: Boot, System and Data
It sounds a little too simple: Uninstall SuperSU and install Superuser (though the method I should do it through is not clear), flash Magisk through TWRP, and then flash AutoMagisk through TWRP. I feel like I am definitely forgetting steps. That, and if somehow I am getting past SafetyNet with Android Pay I don't want to mess with something that might break however I managed to pull it off.
Click to expand...
Click to collapse
The proper steps would be:
0. Make a nandroid backup in TWRP!!
1. Open SuperSU and choose to completly unroot (somewhere near the bottom of the settings menu)
2. Boot to TWRP and flash Magisk
3. Flash the phhh superuser zip file (from the magisk thread)
4. boot android and install the superuser app from the playstore
5. boot twrp and install AutoMagisk
That's it!
Another worry is breaking my cellular radio. I remember that SuperSU for a while did something (or rather, didn't do something with encryption that the HTC 10 needed which resulted in the cellular radio not working once it was flashed, and that for a while there was a special fork of SuperSU for HTC 10 phones to fix this until the main SuperSU app implemented it. I have no idea if Superuser or Magisk also could cause this issue. Does anyone have any idea?
Click to expand...
Click to collapse
Radio shouldn't be broken unless you flash very old zips, don't worry about it
Oh, and finally, my phone is complaining that an update is available, has been complaining for a while, update 1.80.651.6. Can I safely install this OTA update while rooted? Will it remove or break root if I do? And would it be recommended to install it now before I mess with Superuser and Magisk, or after?
Click to expand...
Click to collapse
I allmost enver use official OTA's so I can't say for certain buttttt as you used SuperSU, the root should be systemless so it should accept OTA updates..
What I would do:
1. make a nandroid
2. install OTA
3. See if everything works as expected
4. restore backup if something doesnt work properly =D
I would install the OTA before trying Magisk

Thank you, that was very helpful. I did try Googling all this, but couldn't find clear answers, which is why I am asking here.
And yes, I am definitely going to make a backup before messing with it. Is there any reason to make a Titanium backup too, or will the nandroid one be enough?
As for removing SuperSU, what would that system/boot stock reset delete? Would it delete any installed applications or application settings? Or undo updates to pre-installed system apps? Or reinstall apps that came with the phone that I uninstalled?

Got it working, thanks. (Though, AutoMagisk seems to only be available as an APK, not as a zip that can be installed from TWRP).
Seems like a few configuration settings got wiped due to the system partition being reset, but other than that most of my data seems perfectly intact.

Snapchat login fail on rooted device

Hi guys,
I bought a HTC One M9 from my friend but I discovered that it's rooted. That's not a big issue but I can't use Snapchat because the device has been rooted. I only know it's rooted with SuperSU.
I don't know anything about roots and ROMs so can anyone help me with this problem? I red some other threads but they didn't work out... The apps hidemyroot and Root Cloaker also didn't help me.
Thanks a lot!

You'd be best off either unrooting or flashing a fresh rom without any root, and using something like Titanium Backup to backup Snapchat, and whenever you re-root, restore from that backup. You won't have to login again. (Correct me if I'm wrong, as this process had worked in the past, however I am unsure if this is the case now.)

Andranoxi said:
You'd be best off either unrooting or flashing a fresh rom without any root, and using something like Titanium Backup to backup Snapchat, and whenever you re-root, restore from that backup. You won't have to login again. (Correct me if I'm wrong, as this process had worked in the past, however I am unsure if this is the case now.)
Click to expand...
Click to collapse
Thanks for your answer! I just don't know how you do everything with roots etc. Is it possible to get the root away? Would be the best solution for me because I never use it. Is there already a good thread which tells you how to unroot your HTC? My phone is S-On so they told me it was not possible...

If you desperately need snapchat that much then you'll have to flash the phone back to its stock state. There is a thread, by flippy, in the general section stickies that explains how to do that.
Beamed in by telepathy.

Don't listen to these guys, you can download a few things and be on your merry Snapchat. What you'll need (all can be found on XDA):
UnSU-signed.zip
SuperSU 2.79 SR3 zip
suhide zip
RootSwitch 1.3.3.2
xposed framework [optional] (I recommend version 86.2 by topjohnwu)
First reboot to recovery, flash UnSU zip, then reboot to system. Download SafetyNet Helper Test and check if you pass just without root, if it's green we're good to proceed. If it doesn't pass, blue or red, you'll want to flash a ROM and start fresh.
Reboot to recovery again, flash SuperSU zip, it should install as systemless automatically. After that you can install the suhide zip and if you want xposed, then wipe Dalvik and cache and reboot.
Once you're rebooted back in the system you'll want to install the RootSwitch apk and suhide GUI from the playstore. Once they are installed, open RootSwitch and select the options for Disable USB debugging and Stop all su daemons (I also have notification showing so I always know whether it's enabled or not). Open suhide GUI and make sure these items are checked off: Android Pay, Pokemon Go, SnapChat and SystemUI. Once those options are checked, go back to RootSwitch and hit Disable Root. Open SN Helper and test again; it should be green.
You now have a device with systemless root and xposed that can be disabled at any time without a reboot and used as a stock device, working with Android Pay and other apps that block rooted phones, including SnapChat. ?
Of course, if you don't want any of this and just want a stock HTC M9, I recommend downloading the RUU for your model direct from HTC and doing a full restore on it.
Hope this helps.

Pokemon go one oneplus3 rooted with supersu

Hello everyone,
I've recently wanted to come back and play the game, but it failed open it so i read a little and saw that pokemon go cant be opened on rooted phones.
Now I have oneplus3 with supersu, what do I need to know/do and how can I play it again?
Thanks in advance!
P.S, I'm new here, if I did'nt asked in the right place you can lock or delete it, i assume here its the spot.

SuperSU is your problem. Unroot your phone and use Magisk instead of SuperSU. Magisk has a feature called Magiskhide that allows you to hide root from certain apps.
You can find Magisk Manager on XDA.

FriendWithin said:
SuperSU is your problem. Unroot your phone and use Magisk instead of SuperSU. Magisk has a feature called Magiskhide that allows you to hide root from certain apps.
You can find Magisk Manager on XDA.
Click to expand...
Click to collapse
I went to the supersu and did a clean unroot, then i tried to flash magisk with twrp and i got this error:
"! please restore stock boot image
Updater process ended with ERROR: 1"
I checked and saw i need to flash my original stock boot image, but I have no clue if I have one like this or where it is. Where I can find it?
And will that cause a lost of my data or any other results like that?
Thanks in advance <3

Shaxib said:
I went to the supersu and did a clean unroot, then i tried to flash magisk with twrp and i got this error:
"! please restore stock boot image
Updater process ended with ERROR: 1"
I checked and saw i need to flash my original stock boot image, but I have no clue if I have one like this or where it is. Where I can find it?
And will that cause a lost of my data or any other results like that?
Thanks in advance <3
Click to expand...
Click to collapse
dirty flash the installed rom or flash stock boot.img
edit:no loss of data

Dupleshwar said:
dirty flash the installed rom or flash stock boot.img
edit:no loss of data
Click to expand...
Click to collapse
Where can I find them? I have no clue
And what is dirty flash?
Sorry for the ignorance, I'm new to this :crying:

Shaxib said:
Where can I find them? I have no clue
And what is dirty flash?
Sorry for the ignorance, I'm new to this :crying:
Click to expand...
Click to collapse
The boot image is part of the ROM that you are using. Find out which ROM you are using by going to Phone>Settings>About Phone. Then search for it in XDA.
The stock boot image is part of the stock ROM and it is available in OnePlus's website.
Dirty flash is when you flash something over what you already have, without wiping any of the partitions. Clean flash is when you flash something after wiping the partitions.
Edit: If you are this new to flashing, it is better that you learn some basics, especially about coming out of bootloops and saving your data, before you go about flashing.

tnsmani said:
The boot image is part of the ROM that you are using. Find out which ROM you are using by going to Phone>Settings>About Phone. Then search for it in XDA.
The stock boot image is part of the stock ROM and it is available in OnePlus's website.
Dirty flash is when you flash something over what you already have, without wiping any of the partitions. Clean flash is when you flash something after wiping the partitions.
Edit: If you are this new to flashing, it is better that you learn some basics, especially about coming out of bootloops and saving your data, before you go about flashing.
Click to expand...
Click to collapse
Thank you very much man, I downloaded a rom for my oxygen 4.1.3 and flashed it, and then the magisk worked perfectly fine.

Hey man, how is your GPS working while playing Pokemon GO or using any GPS based app?

Hi everyone, I would install Magisk and delete supersu, but i have a problem.
My OOS is unencrypted and every time i have to install a new version, i have to flash supersu for block the encryption. What happen if i delete supersu and i install magisk? Does magisk block encryption too?

You need magisk installed, and make sure you don't have any other mods installed as they can trigger safetynet.

[HELP] Root questions

Hello everyone!
I want to root my phone, but have some question before starting the process, because something maybe will not work as expected.
1. The main propose of my root is to install Cerberus as system app, wich will protect the app from a hard reset;
2. I want to remove some useless apps, like lens, google files, and others (I have found some posts with is safe to disable/remove);
3. I want to integrate the app's updates the phone receives after setting an account. I have used Link2SD on previous phones;
4. MAYBE I will install Butterfly For Daisy (the multitasking is annoying!!), so, maybe I'll install Kernel Auditior as system app.
5. I'll NOT use custom ROM, I'll keep Android One experience for now.
So, as far I read, to complete the root process, I have to disable encryption on phone. The problem is: i use 4 accounts on my phone, one of them is a Google App one, wich means when I configure it, it will ask to encrypt my phone. Google Apps accounts ALWAYS use encryption on my organization, is mandatory. So...
A. Can I root without disable encryption?
B. Can I just boot TWRP to root, without permanently install it?
C. I'll have phone updates problems with questions 1, 2, 3 and 4 above?
D. Will a Google App account work on a rooted phone with Magisk for Mi A2 Lite?
E. Magisk Manager will be installed as system app or user app? Because Cerberus will use root. If I reset the phone, I'll lose Magisk Manager if it is installed as user, so Cerberus will not get root permissions and will not work properly.
Thank you in advice, and sorry for tons of questions.

romulocarlos said:
A. Can I root without disable encryption?
B. Can I just boot TWRP to root, without permanently install it?
C. I'll have phone updates problems with questions 1, 2, 3 and 4 above?
D. Will a Google App account work on a rooted phone with Magisk for Mi A2 Lite?
E. Magisk Manager will be installed as system app or user app? Because Cerberus will use root. If I reset the phone, I'll lose Magisk Manager if it is installed as user, so Cerberus will not get root permissions and will not work properly.
Click to expand...
Click to collapse
A. Magisk/root works fine with encryption.
B. Don't use TWRP to root. But you can boot it without installing (fastboot boot image.img)
C. Follow the process in the Magisk guide thread to install OTAs.
D. No idea
E. User app. It gives itself root via Magisk.
If you modify the system image you'll have a much harder time doing OTAs. You must have unmodified partitions to install OTAs. I do this to get a dark bootanim, but for install/remove system apps you'd be much better off to use Magisk modules. There's modules for both systemizing apps and hiding system apps.

a1291762 said:
A. Magisk/root works fine with encryption.
B. Don't use TWRP to root. But you can boot it without installing (fastboot boot image.img)
C. Follow the process in the Magisk guide thread to install OTAs.
D. No idea
E. User app. It gives itself root via Magisk.
If you modify the system image you'll have a much harder time doing OTAs. You must have unmodified partitions to install OTAs. I do this to get a dark bootanim, but for install/remove system apps you'd be much better off to use Magisk modules. There's modules for both systemizing apps and hiding system apps.
Click to expand...
Click to collapse
Thank you.
A. OK, I'll try soon
B. Ok, I'll use it to take a full backup before start the process
C. You mean your guide or BubuXP's? In fact, BubuXP's seems easier to do!
D. Let's cross fingers...
E. Can I convert it to system? Like I sayed, Cerberus will need root after a reset. Without Manager, I'll not see the warning to grant root access, don't?
I'll search for these modules. Thank you.

romulocarlos said:
C. You mean your guide or BubuXP's?
E. Can I convert it to system? Like I sayed, Cerberus will need root after a reset. Without Manager, I'll not see the warning to grant root access, don't?
Click to expand...
Click to collapse
C. If you just have Magisk, use bubuxps guide. My guide is if you have magisk and twrp and want to do otas. It's mostly the same, with extra steps.
E. Magisk Manager does not need to be a system app. It won't help you if it lives on /system and Magisk gets removed.
Factory reset doesn't touch boot so I guess if you intend to do factory reset often it might be useful to put apps on system. But by doing so, you'll make it much harder to take OTAs.
To take an OTA you'll need to flash the original system, apply the ota then apply your system changes again. If you're upgrading to a release without fastboot images you'll want to take a backup of system before you modify it.
It might even be worthwhile only upgrading to fastboot releases because you'll have the backup and can modify the images before you flash them, avoiding booting without your customizations.

a1291762 said:
C. If you just have Magisk, use bubuxps guide. My guide is if you have magisk and twrp and want to do otas. It's mostly the same, with extra steps.
E. Magisk Manager does not need to be a system app. It won't help you if it lives on /system and Magisk gets removed.
Factory reset doesn't touch boot so I guess if you intend to do factory reset often it might be useful to put apps on system. But by doing so, you'll make it much harder to take OTAs.
To take an OTA you'll need to flash the original system, apply the ota then apply your system changes again. If you're upgrading to a release without fastboot images you'll want to take a backup of system before you modify it.
It might even be worthwhile only upgrading to fastboot releases because you'll have the backup and can modify the images before you flash them, avoiding booting without your customizations.
Click to expand...
Click to collapse
Thank you again. But...
C. I used BubuXP's guide. Works well. I just need an updated "Disable-Force-Encryption-Treble.zip", because it install an older version of Magisk, and I need encryption disabled to make backups, as TWRP can't make backup on /data.
E. Well, Magisk itself won't be removed after a reset, but if Magisk Manager is removed, how an app will get root permissions? The warning about the permissions comes from Magisk Manager, not from Magisk itself (the one on boot), don't?
And, yes, I want some apps on /system, as Cerberus, for example. I'll put the updates on /system, also. It makes easier to handle the phone after a reset. I don't mind too much to OTAs, as we can download the whole ROM and flash it as I need.
EDIT: don't need an updated "disable-force-encription". Just installed lastest Magisk version in TWRP after disable-force-encription.

HELP! OTA update created bootloop and doesnt recognize my PIN to decrypt data

Hello,
I'm runing lineageOS 16 on my pocophone f1 beryllium. with encryption enable, running Magisk latest version.
Not the first time i had a bootloop after an OTA update. Found out it was the ANXCamera Magisk Module giving problems. Disabling the module solved the bootloop.
I have other modules enable like Youtube Vanced and lately i installed the FDE.AI module. Because i dont use any more the ANXCamera module i decided to do the update within Lineage to the latest build.
After the updater flashed the latest build it reboots and goes to a bootloop. After some minutes goes into twrp recovery.
During this time i always had to put my Password/PIN to decrypt data every time i go to recovery or try to boot the system.
I installed Magisk Manager for recovery and was able to disable all the modules within Magisk but still, i has stuck in the bootloop.
I read that uninstalling Magisk could solve the bootloop. So within twrp i flashed the magisk-uninstaller.zip but still didn't solved the issue.
Without knowing what to do i decided to flash the build of lineage that i was using before.
The system reboots and asks me for my password/PIN and for my surprise, it says Wrong Password. I go to recovery and twrp also says wrong password to decrypt data
Don't know if my latest flash solved the bootloop because now my device doesn't recognize my password/PIN
I have a nandroid backup in my internal storage but now i can't access to it.
Can someone help me to be able at least to access my data?
Would love to find a way to go out of the bootloop but most important is to overcome the data encryption.
Wonder if it was the FDE.AI module that created the bootloop because until now i was doing ota updates with no problems.
Big Thanks.

So what have we learned? A backup is no backup, if it's kept only within the device.

kurtn said:
So what have we learned? A backup is no backup, if it's kept only within the device.
Click to expand...
Click to collapse
Actually, i had the backup on my laptop and i tried to use it but twrp says that can't restore the backup because my /data partition was made using ext4 file system and what is using now is different S always thought it only uses ext4)
I tried to restore all the partitions except Data but it didn't fix the wrong password.
I decided to Format my /data partition and install again the LineageOS16 latest build...Start from scratch.

From my searches it seems quite impossible to recover from this kind of situation of wrong password when you had encryption enable..it makes sense because that's the purpose of encryption the data.
So now i have already installed everything, including Magisk but i'm going to stop updating the device through the updater and doing it by recovery or ADB...
Thanks.