Develop Bugs

Modifying Android's built-in apps

Hi guys!
I'm wondering what I'd have to do if I wanted to modify the built in apps inside Android..
I've got a HTC Hero running FroydVillain 1.5.0. Let's say... I want to modify the messaging app that's included, MMS.apk. I wouldn't know how to go about this, and I have a few questions...
Firstly, what sources exactly are used for building the built in apps for a given ROM? The source code link in the FroydVillain post, for example, is just for the kernel. The rest of the OS isn't there.
Secondly, I hear that in order to modify a built in app, you need to build the entire OS. If I just download all the code from Google official repo, and compile that, will it just... work on my phone, provided I use a kernel that is specific to my phone?
Lastly, are there any tips anyone has for someone who just wants to modify a couple of the built in apps? Is it possible to build them as standalone apps? Or import them into Eclipse?
I've had a search around the forum and the internets in general, and people have asked similear questions, but I've yet to find a good answer. This thread comes to mind: http://forum.xda-developers.com/showthread.php?t=635197
If anyone could help me, or point me in the direction of any help, that'd be awesome! Thanks!!

FunkTrooper said:
Hi guys!
I'm wondering what I'd have to do if I wanted to modify the built in apps inside Android..
I've got a HTC Hero running FroydVillain 1.5.0. Let's say... I want to modify the messaging app that's included, MMS.apk. I wouldn't know how to go about this, and I have a few questions...
Firstly, what sources exactly are used for building the built in apps for a given ROM? The source code link in the FroydVillain post, for example, is just for the kernel. The rest of the OS isn't there.
Secondly, I hear that in order to modify a built in app, you need to build the entire OS. If I just download all the code from Google official repo, and compile that, will it just... work on my phone, provided I use a kernel that is specific to my phone?
Lastly, are there any tips anyone has for someone who just wants to modify a couple of the built in apps? Is it possible to build them as standalone apps? Or import them into Eclipse?
I've had a search around the forum and the internets in general, and people have asked similear questions, but I've yet to find a good answer. This thread comes to mind: http://forum.xda-developers.com/showthread.php?t=635197
If anyone could help me, or point me in the direction of any help, that'd be awesome! Thanks!!
Click to expand...
Click to collapse
1) The whole sources for everything are there
http://github.com/ninpo
2) You can import the sources to eclipse, but I think you will need to build the entire tree, as opposed to just what you change
3) Apktool lets you do smali and resource edits on an APK. Without knowing what you aim to do, it's hard to guide you specifically.

Most apps are based on the sources provided by google. I assume you are talking about Froyo Hero ROMs (i.e. FroydVillain), which apps are generally built from the source of CyanogenMod. Specifically for FroydVillain, if you look around ninpo github you will see some packages with some changes to their code, although it does seem that many of the changes in recent releases are not there. I have actually PMed ninpo about this and hopefully this is only a technicality.... I assume that the other packages and apps (most of them) he just compiled off the CM sources without changes.
In any case, if you compile an app either from the CM source or from google's original sources, it should work just to copy the apk file - just make sure you use an appropriate ROM (i.e. Froyo ROM if you built it from Froyo sources). The reason to want the CM sources, is that if they have incorporated further fixes (over the google sources) you may want them.
Finally, some more practical advice: I would start with the google sources: http://source.android.com/source/index.html since I have found these instructions and explanations easier to begin with - it should be quite straight forward to build these sources on a linux machine (or VM).
Then you can also try to tackle the cyanogen source: http://wiki.cyanogenmod.com/index.php?title=Building_from_source currently missing instructions on how to build for hero. But if you only want to copy apks out of it, you can just build a generic build (like in the google souce).
If you have specific problems, ask and I'll try to help you.
Good luck.

pulser_g2 said:
1) The whole sources for everything are there
http://github.com/ninpo
Click to expand...
Click to collapse
For example where are all the changes to the dalvik code? I do not follow closely enough the changes in Froyd to point out other things which might be missing (if at all), but there are relatively few committed changes to the CM code. Specifically the dalvik code, ninpo mentioned hundreds of changes which caught my interest and are definitively not there.
The kernel sources do seem to be up to date always - been following that one closely .

Thanks for the advice I love this forum!
What I'm trying to do, in case you're wondering, ultimately, is to modify the built-in messaging application to give the user the option of sending a message by the normal method, or by using their provider's free webtext service, something that all the carriers seem to offer here in Ireland.
So, for example, you'd press the Send button, and you'd be able to select one of those methods. (of course, you'd have to have a data connection for the webtext). There's also be an interface for entering your login credentials for your carrier's website.
I'm doing this party because it would be very useful. I also feel that it would give me a good introduction to how you'd go about modifying Android. I mean, from a programming point of view, it shouldn't be *too* hard to do. I already have a simple standalone app that I made which can send a text message via an Irish carrier's webtext service. But it's all good experience to try to modify other people big codebases.
I have a good bit of experience with web application development, but my experience with other programming is a little more limited. I usually use PHP, where there's none of this compiling nonsense. You just write scripts and off they go!
So I'm gonna go off and see if I can set up an environment where I can build.. the OS, I guess.
If I was to take the vanilla official Google sources, would they work on my phone? Or would I have to use an official Google developer phone... or the emulator? Or maybe if I stopped writing here and investigated those links you've provided, I'd know that by know.
Brb, investigating

Yeh investigating and just trying to do it is usually the best way
To clarify what I was trying to say above: All the java code is obvious very portable - one of the big advantages of java. In the case of android it is compiled to an .apk file and this file should be, at the very least, portable to all android "devices" running this android version. So the apk you build (for example from the vanilla 2.2 sources) should work on the emulator (good for initial debugging) and any 2.2 ROMs.

erasmux said:
For example where are all the changes to the dalvik code? I do not follow closely enough the changes in Froyd to point out other things which might be missing (if at all), but there are relatively few committed changes to the CM code. Specifically the dalvik code, ninpo mentioned hundreds of changes which caught my interest and are definitively not there.
The kernel sources do seem to be up to date always - been following that one closely .
Click to expand...
Click to collapse
I'm currently on "vacation" from any and all Android development for a week. I'll be back after the weekend, at which time my modifications will be cleaned up and committed to git. The kernel is always current with my latest kernel release due to GPL obligations. The extra time away has also highlighted some changes I need to make both to the kernel and to my Android modifications when I get back.

Hacre said:
I'm currently on "vacation" from any and all Android development for a week. I'll be back after the weekend, at which time my modifications will be cleaned up and committed to git. The kernel is always current with my latest kernel release due to GPL obligations. The extra time away has also highlighted some changes I need to make both to the kernel and to my Android modifications when I get back.
Click to expand...
Click to collapse
Thanks Ninpo

Kitkat 4.4 for Defy/Defy plus (MK44.2) Mokee ROM

Moderators Note about MoKee. These ROMs in the past were known for distributing adware/malware. As they claim to be "Open Source" now, you should still be cautious about flashing MoKee ROMs. Currently this ROM is under review by Moderation Staff.
Android 4.4 Kitkat for Defy and Defy+​
This is the latest Mokee ROM for our very own and never dying cell,Motorola Defy/Defy plus(Aka.jordan/jordanplus) based on the latest android OS Kitkat 4.4.
About MoKee OpenSource:
MoKee OpenSource is based on Google AOSP and CyanogenMod Android source development of a branch,
but also the country's first complete open-source Android project, users and developers around the home.
Google open source projects follow the rapid escalation, and for the user habits, improvements and enhancements.
Magic Fun Forum December 12, 2012 launch of the project, is committed to making this form of localization of open source CyanogenMod ROM.
Open source project, any interested technical experts who can participate in the development, its contribution to the force!
Project Address: http://www.mfunz.com
Click to expand...
Click to collapse
Mfunz/Mokee os Official page http://
www.mfunz.com/
Developers http://www.mfunz.com/contributors/
Forum: http://bbs.mfunz.com
Tutorial: http://bbs.mfunz.com/
thread-653126-1-1.html
Statistics: http://stats.mfunz.com
audit: http://review . mfunz.com
Github: https://github.com/MoKee
code tracking: http://issues.mfunz.com/
code tracking - Mobile: http://issues.mfunz.com/
mobi
Open source project, any interested technical
experts who can participate in the development of
its contribution to the force!
Project Address: http://www.mfunz.com
Update recovery first then flash this:
Download :http://pan.baidu.com/s/17YFiu
Gapps:?
Here is the link from the original post:
http://bbs.mfunz.com/thread-920983-1-1.html
Change Log :http://changelog.mfunz.com/
Screenshots :

As I can see you've post the 14.12 version and not the last 16.12 version which contains many bugs repaired. Can you post the last one? THX.

Guys, but why are you still using Mokee, aren't they including malware in every ROM now? :/

niksy+ said:
Guys, but why are you still using Mokee, aren't they including malware in every ROM now? :/
Click to expand...
Click to collapse
My solution is very simple Root Explorer and delete all parts of the MoKee from /system/app

niksy+ said:
Guys, but why are you still using Mokee, aren't they including malware in every ROM now? :/
Click to expand...
Click to collapse
Those Chinese apps is not exactly malware. Because is not useful for me I've uninstalled it with Titanium and recover some ROM. Also I replace the Mokee launcher and keyboard and make a very reliable and stable OS ( 4950 pts under Antutu 4.1.4).

deffyplus said:
My solution is very simple Root Explorer and delete all parts of the MoKee from /system/app
Click to expand...
Click to collapse
Those Chinese apps is not exactly malware. Because is not useful for me I've uninstalled it with Titanium and recover some ROM. Also I replace the Mokee launcher and keyboard and make a very reliable and stable OS ( 4950 pts under Antutu 4.1.4).
Click to expand...
Click to collapse
Exactly ! )
And i also use it as i dont get battery drops like in cm10.2

pgreed said:
As I can see you've post the 14.12 version and not the last 16.12 version which contains many bugs repaired. Can you post the last one? THX.
Click to expand...
Click to collapse
On the official site i am getting 14/12 build only....if u get some link do send me,i'll add it to the post

pgreed said:
Those Chinese apps is not exactly malware. Because is not useful for me I've uninstalled it with Titanium and recover some ROM. Also I replace the Mokee launcher and keyboard and make a very reliable and stable OS ( 4950 pts under Antutu 4.1.4).
Click to expand...
Click to collapse
And how is it that it's "not exactly malware"? Is it just partially malware? Almost malware? Maybe malware? Or is a "variant of Android/TrojanDownloader.Adload.B trojan" really just not that bad?
And then when people caught on to it they also modified the keyboard app too... but nah... can't be that bad, since they are actually fixing many bugs that aren't being taken cared of by serious developers that contribute directly to XDA, right? Oh wait, their change log doesn't really reflect anything different than what's already being taken care of by other developers who are actually compiling and programming for our Defy...
As a tip, you can and should delete those apps before flashing (with 7zip), that way they aren't ever run on your phone; once you flash the first thing that will start up will be the keyboard.

Antiga Prime said:
And how is it that it's "not exactly malware"? Is it just partially malware? Almost malware? Maybe malware? Or is a "variant of Android/TrojanDownloader.Adload.B trojan" really just not that bad?
And then when people caught on to it they also modified the keyboard app too... but nah... can't be that bad, since they are actually fixing many bugs that aren't being taken cared of by serious developers that contribute directly to XDA, right? Oh wait, their change log doesn't really reflect anything different than what's already being taken care of by other developers who are actually compiling and programming for our Defy...
As a tip, you can and should delete those apps before flashing (with 7zip), that way they aren't ever run on your phone; once you flash the first thing that will start up will be the keyboard.
Click to expand...
Click to collapse
that it is also possible

Antiga Prime said:
And how is it that it's "not exactly malware"? Is it just partially malware? Almost malware? Maybe malware? Or is a "variant of Android/TrojanDownloader.Adload.B trojan" really just not that bad? ... be the keyboard.
Click to expand...
Click to collapse
maybe the correct term is adware? For the rest: I found that ROM to be the most stable, battery efficient and with all the settings I need. 'till now the rest of 4.3 custom ROMs do not comply with the above needs and the 4.4.x is not enough mature. The only problem with Mokee 4.3 is that SistemUI slowly growing which suffocate the RAM and need periodical reboot -but that appear to be common to 4.3.x . Those grow seems to be closely related to apps installation and update.
---------- Post added at 08:09 PM ---------- Previous post was at 08:00 PM ----------
abhinavvaidya90 said:
On the official site i am getting 14/12 build only....if u get some link do send me,i'll add it to the post
Click to expand...
Click to collapse
Hm .. the 16.12 version seems not to be public yet!

pgreed said:
maybe the correct term is adware? For the rest: I found that ROM to be the most stable, battery efficient and with all the settings I need. 'till now the rest of 4.3 custom ROMs do not comply with the above needs and the 4.4.x is not enough mature. The only problem with Mokee 4.3 is that SistemUI slowly growing which suffocate the RAM and need periodical reboot -but that appear to be common to 4.3.x . Those grow seems to be closely related to apps installation and update.
Click to expand...
Click to collapse
Hardly the point. First of all, the fact that they have to hide it in an app most people will need to start up the ROM is shady at best. Second of all, regardless of how AV companies label the malicious software they find, a trojan downloader is essentially a backdoor for the app developer to open it and to deliver a payload that can behave differently than just "adware", without the user's consent or knowledge. That fact alone should make people think twice before installing/using this ROM, especially once people are aware that the developer's intentions are not necessarily intentions that promote the improvement and development of Android.
People can choose what they want, just my two cents on why we are tolerating malware, adware, trojans, or whatever you want to call it. There are a lot of people who also frequent these forums who won't know how to delete the malicious apps before flashing, regardless of whether they should be able to or not.
It's different when you have to mod things to your liking or to improve functionality, but hidden and persistent malware/adware placed by the developers themselves...?
We shouldn't have to tolerate that...

Antiga Prime said:
Hardly the point. First of all, the fact that they have to hide it in an app most people will need to start up the ROM is shady at best. Second of all, regardless of how AV companies label the malicious software they find, a trojan downloader is essentially a backdoor for the app developer to open it and to deliver a payload that can behave differently than just "adware", without the user's consent or knowledge. That fact alone should make people think twice before installing/using this ROM, especially once people are aware that the developer's intentions are not necessarily intentions that promote the improvement and development of Android.
People can choose what they want, just my two cents on why we are tolerating malware, adware, trojans, or whatever you want to call it. There are a lot of people who also frequent these forums who won't know how to delete the malicious apps before flashing, regardless of whether they should be able to or not.
It's different when you have to mod things to your liking or to improve functionality, but hidden and persistent malware/adware placed by the developers themselves...?
We shouldn't have to tolerate that...
Click to expand...
Click to collapse
Completely agree with you. Personally I think this ROM should be banned from XDA, where piracy and even promoting your paid themes isn't allowed. For me it is unimaginable that a trojanned ROM can be posted. discussions about how easy it is to remove don't matter, like you said. Hence I have reported to the mods.
@ others: Yes people can choose what they want, like antiga said, but on XDA the choice of installing trojans shouldn't even exist. There are shadier websites one can visit to get their trojan fixes.

Thread currently closed
Ok, 2 things.
1) Thread moved to General, as it's just links to the MoKee site, as it appears the OP is not an official maintainer, and just posted links. As such it does not qualify as development.
2) Thread is currently closed pending investigation of current MoKee practices.
In the past MoKee had been known to included adware in their apps. Did they include Malware? Depends who you talk to. However, MoKee was discouraged at XDA, along with MIUI ROMs which also operate under a similar principle.
However, MoKee claims to be "Open Source" and their github seems to reflect that.
It is advisable however, to remove any suspicious apk's just to be safe until a disposition is made. And considering it's a Chinese ROM with a past reputation, might want to change keyboard apk's as well
Thread closed for the time being.
MD

[IDEA] One-click .apk app for rooting Nokia X (and X+/XL)

I've finally managed to root my Nokia X, which is a prerequisite for installing the Xposed Framework and some modules for it (which is something I've been wanting to do for a while). After trying out various tools, starting with the more open-source ones (like Kernelchopper), I ended up using Framaroot. Why? Because Framaroot doesn't require a computer and is extremely simple to use (and it works ); personally I don't mind if a rooting method requires the usage of a PC, but ideally all you'd need to do would be to download and execute an .apk.
Now, Framaroot is hardly the ideal solution, because it's not (free and) open source and not even source-available (reference). What's more, the superuser app that Framaroot installs -- SuperSU -- is not free and open source software either. There are open-source alternatives, such as Koush's Superuser.
I'm sure some of you are thinking, "but Framaroot's/SuperSU's developer is a great and trustworthy person!"; while I don't have a good reason to doubt that, I still have a reason to be wary of what code I execute on my mobile device; it's not like you go clicking around every single .exe on a Windows computer either. When the source code is free and open, people are able to see what it does, compile it and submit improvements to it.
I therefore propose that we create an easy-to-use, one-click rooting app for devices like the Nokia X family (Qualcomm chipset, Android 4.1.2 or otherwise vulnerable to CVE-2013-2595). How? From what I've gathered, the "Framaroot Gandalf exploit" source is on GitHub (also see this Tweet by Pau Oliva), so it shouldn't be too hard for an expert Android developer -- which I'm sure we have plenty of in this forum -- write a graphical front-end for it and have it drop Koush's Superuser onto the device after a successful exploit (instead of SuperSU or $your_favorite_proprietary_superuser_app).
Thoughts?

towelroot is opensourced
https://github.com/f0go/Towelroot-by-Geohot

Jack Phoenix said:
I've finally managed to root my Nokia X, which is a prerequisite for installing the Xposed Framework and some modules for it (which is something I've been wanting to do for a while). After trying out various tools, starting with the more open-source ones (like Kernelchopper), I ended up using Framaroot. Why? Because Framaroot doesn't require a computer and is extremely simple to use (and it works ); personally I don't mind if a rooting method requires the usage of a PC, but ideally all you'd need to do would be to download and execute an .apk.
Now, Framaroot is hardly the ideal solution, because it's not (free and) open source and not even source-available (reference). What's more, the superuser app that Framaroot installs -- SuperSU -- is not free and open source software either. There are open-source alternatives, such as Koush's Superuser.
I'm sure some of you are thinking, "but Framaroot's/SuperSU's developer is a great and trustworthy person!"; while I don't have a good reason to doubt that, I still have a reason to be wary of what code I execute on my mobile device; it's not like you go clicking around every single .exe on a Windows computer either. When the source code is free and open, people are able to see what it does, compile it and submit improvements to it.
I therefore propose that we create an easy-to-use, one-click rooting app for devices like the Nokia X family (Qualcomm chipset, Android 4.1.2 or otherwise vulnerable to CVE-2013-2595). How? From what I've gathered, the "Framaroot Gandalf exploit" source is on GitHub (also see this Tweet by Pau Oliva), so it shouldn't be too hard for an expert Android developer -- which I'm sure we have plenty of in this forum -- write a graphical front-end for it and have it drop Koush's Superuser onto the device after a successful exploit (instead of SuperSU or $your_favorite_proprietary_superuser_app).
Thoughts?
Click to expand...
Click to collapse
TBH, it is a good idea. But there is already a Rooting procedure so creating an app would be useless. No?

mdfzhi said:
towelroot is opensourced
[GitHub link I had to remove because xda is stupid and thinks everything posted by "new" users is spam, no matter what]
Click to expand...
Click to collapse
Thank you for the suggestion, but unfortunately there are multiple issues here:
It doesn't work. I tested out a variety of different rooting methods, of which one was Towelroot. The concept is great, but it just wouldn't work on my Nokia X, running the original firmware. lifehacker.com/towelroot-roots-android-kitkat-devices-in-one-tap-no-p-1592226618 notes that "[Towelroot] works on phones running Android KitKat", and the Nokia X isn't running KitKat.
Towelroot is actually not FOSS. Someone took the original tr.apk file from towelroot.com, ran it through apktool (code.google.com/p/android-apktool/) and posted the result on GitHub. It was not released there by its author, which makes it effectively a blatant copyright violation, tool. Furthermore the resulting thing won't compile either. Several sources (such as tinyhack.com/2014/07/07/exploiting-the-futex-bug-and-uncovering-towelroot/ and clevcode.org/cve-2014-3153-exploit/) note that "TowelRoot is closed source and heavily obfuscated" and that there are (or rather, weren't) any public exploits of CVE-2014-3153 (Joel Eriksson rectified that, though).
Of course it'd be great to see tools like Framaroot and Towelroot go open source, but I don't see that happening anytime soon. Why the developers cling to the source so hard when they're distributing their work entirely for free is beyond me; I'm no big fan of freeware personally.
All that being said, I'm not proposing we reinvent the wheel, but rather invent the wheel and release the invention under a suitable license for everyone to study, amaze and contribute to. That's something you can't do with tools like Framaroot and Towelroot.
(Sorry about the lack of clickable links, btw; I blame that on XDA. Sorta ironical that the initial post can contain links, but subsequent replies cannot. Makes total sense...not.)

Dom3616 said:
TBH, it is a good idea. But there is already a Rooting procedure so creating an app would be useless. No?
Click to expand...
Click to collapse
If by "procedure" you refer to the fact that you can flash a recovery firmware or whatnot, then no, I don't think creating an app would be useless at all. Flashing requires a computer (unless I'm horribly mistaken here) and it can seem intimidating for, well, someone who hasn't done it before (like me!). I'm still somewhat of a smartphone newbie, and definitely an Android newbie, although I have plenty of programming experience and IT experience in general.
Framaroot was really simple to use and you really can't go wrong with it, but as I wrote in the original post, the sad truth is that it's still proprietary and that's at least a major ideological concern for some (like me), but also a practical concern. When the source code is available, you can look at it and see what it does, or if you lack the skills, you can ask an experienced (Android) dev to check it for you. When the app is closed-source, all you have is the dev's word on it, and occasionally that of the app's users. It's something, but it's not ideal -- for anyone, I believe.
Google Play Store and other app stores are full of Flappy Bird clones and whatnot, and despite Play Store not accepting apps meant to root the device, I firmly believe that this utility should be built, for it serves a practical purpose and essentially hasn't been done before: there are rooting utilities that are easy-to-use, there are FOSS implementations (well, at least the one I linked in my original post) of the CVE-2013-2595 exploit, but there isn't a FOSS version of the CVE-2013-2595 exploit that would have a GUI and be easy to use.
It's all about choices, and I wish there are options available to the users, and not just "which proprietary rooting app you want to use?".

well if u really must use opensource tool to root the nokia x family, that too can already happen.
first just flash custom recovery, eg cwm or twrp. both are foss. both can be flash using fastboot, not closed source tool needed.
then just boot into the custom recovery and flash either chainsdd superuser flashable zip or koush superuser flashable zip, both are foss too.

mdfzhi said:
well if u really must use opensource tool to root the nokia x family, that too can already happen.
first just flash custom recovery, eg cwm or twrp. both are foss. both can be flash using fastboot, not closed source tool needed.
then just boot into the custom recovery and flash either chainsdd superuser flashable zip or koush superuser flashable zip, both are foss too.
Click to expand...
Click to collapse
This is indeed true, but flashing can be intimidating for newbies and as mentioned in my original post (and also in the thread title), an .apk is so much better. My main motivation for gaining root access was so that I could install Xposed Framework and the resOverloader module for it, which enables to make the device support a language not supported by default, as the X's language selection is not like that of your average Android device's.
Should you sacrifice functionality if you want to be free and stay free? While the answer way too often is "yes", it obviously shouldn't be that way, given the obvious advantages of free and open source software. Admittedly this proposal's scope is somewhat narrow in that the initial target would be devices equipped with Qualcomm chipsets and running Android 4.1.2 (or older), and I probably should have posted this in a more generic Android app development section of the forum instead of the Nokia X subforum. However, it certainly wouldn't hurt anyone if this app would be built, as community members could then contribute to it and add support for other devices, SoCs and versions of Android...which, in the long run, would have the potential to become something like a free and open source clone of Framaroot.

TWRP recovery 3.0 для Zenfone 6 Multi Lang

del

zenfone 5
When TWRP 3.0 for zenfone 5 release?thanks

@quanganh2627 can you port it?

abw_bw said:
@quanganh2627 can you port it?
Click to expand...
Click to collapse
It will work on Zenfone 5 too.
But it is laggy on both phones due to theme. This TWRP 3.0.0 build was compield by umerov1999 from 4PDA.

Link?

my build recovery based cm-13.0 source , support ota update i think
- CM-13.0 Recovery
- TWRP 3.0 M1 Recovery
you can use it https://www.androidfilehost.com/?w=files&flid=52032

X AnwarMov said:
my build recovery based cm-13.0 source , support ota update i think
- CM-13.0 Recovery
- TWRP 3.0 M1 Recovery
you can use it https://www.androidfilehost.com/?w=files&flid=52032
Click to expand...
Click to collapse
Hello @X AnwarMov!
First I would like to clarify that until this moment, I couldn't have done this, as you hadn't published any binary from your releases, but now, you must follow the Open Source Licenses.
If you don't know, the TWRP recovery is published in GPL licenses, the same for the Linux kernel.
As also the recovery is dependent from a kernel, you should know that you need to share your entire sources that you used to build the recovery (including the kernel, necessary for the recovery), and also, according to XDA Rules, your sources must:
Successfully build and produce a valid output file, which is the same format as provided in the binary
Contain all source code, interface definition files, scripts used to control compilation and installation of the executable (it is not required to include the actual compiler/toolchain, but sufficient information should be made available to obtain the SAME configuration, including compiler flags, as used to build the binary version as released)
So, you need to share your sources, otherwise you'll be breaking an Open Source License and we can contact the distributor to get a lawyer to get in touch with you. Also, XDA may take their providences.
Thanks.
If you need, here are some useful links:
XDA-Developers and the GPL
GNU General Public License v3 (GPL-3) Explained in Plain English
The GNU General Public License v3

tank0412 said:
It will work on Zenfone 5 too.
But it is laggy on both phones due to theme. This TWRP 3.0.0 build was compield by umerov1999 from 4PDA.
Click to expand...
Click to collapse
I think this http://forum.xda-developers.com/android/themes/theme-twrp-3-0-0-0-materialised-dark-t3326070 should help

dgadelha said:
Hello @X AnwarMov!
First I would like to clarify that until this moment, I couldn't have done this, as you hadn't published any binary from your releases, but now, you must follow the Open Source Licenses.
If you don't know, the TWRP recovery is published in GPL licenses, the same for the Linux kernel.
As also the recovery is dependent from a kernel, you should know that you need to share your entire sources that you used to build the recovery (including the kernel, necessary for the recovery), and also, according to XDA Rules, your sources must:
Successfully build and produce a valid output file, which is the same format as provided in the binary
Contain all source code, interface definition files, scripts used to control compilation and installation of the executable (it is not required to include the actual compiler/toolchain, but sufficient information should be made available to obtain the SAME configuration, including compiler flags, as used to build the binary version as released)
So, you need to share your sources, otherwise you'll be breaking an Open Source License and we can contact the distributor to get a lawyer to get in touch with you. Also, XDA may take their providences.
Thanks.
If you need, here are some useful links:
XDA-Developers and the GPL
GNU General Public License v3 (GPL-3) Explained in Plain English
The GNU General Public License v3
Click to expand...
Click to collapse
I disagree.
Linux Kernel (which is present in every running Android ROM in some shape or form) is licensed under the GPL (version 2).
And kernel sources was shared. (he used this sources to build TWRP kernel)
So device tree is licenced under Apache license. So your statement is not correct. You have all sources. You can build it by yourself.

tank0412 said:
I disagree.
Linux Kernel (which is present in every running Android ROM in some shape or form) is licensed under the GPL (version 2).
And kernel sources was shared. (he used this sources to build TWRP kernel)
So device tree is licenced under Apache license. So your statement is not correct. You have all sources. You can build it by yourself.
Click to expand...
Click to collapse
Have you noted the line
Contain all source code, interface definition files, scripts used to control compilation and installation of the executable (it is not required to include the actual compiler/toolchain, but sufficient information should be made available to obtain the SAME configuration, including compiler flags, as used to build the binary version as released)?
The source files are partially shared, plus he hasn't added any references to the source code he has used.

dgadelha said:
Have you noted the line
Contain all source code, interface definition files, scripts used to control compilation and installation of the executable (it is not required to include the actual compiler/toolchain, but sufficient information should be made available to obtain the SAME configuration, including compiler flags, as used to build the binary version as released)?
The source files are partially shared, plus he hasn't added any references to the source code he has used.
Click to expand...
Click to collapse
Again.
It is true for GPL license only.
But device tree is under Apache license.

tank0412 said:
Again.
It is true for GPL license only.
But device tree is under Apache license.
Click to expand...
Click to collapse
I partially agree.
Device files aren't necessary, but the reference to the used kernel source is.

tank0412 said:
Again.
It is true for GPL license only.
But device tree is under Apache license.
Click to expand...
Click to collapse
He's right. The whole point of open source is to share all the sources and references so that others can verify it and work on it. Forget about the license. It's the best thing to do.

eragon21 said:
He's right. The whole point of open source is to share all the sources and references so that others can verify it and work on it. Forget about the license. It's the best thing to do.
Click to expand...
Click to collapse
Lets imagine situation that MM device tree by X Anwar is shared but CM13 build is not shared.
Other people can build Marshmallow rom and push it to public. So their will get all credits. And X Anwar this way will got nothing.
So i am totally agree that he does not share sources. If i were him, i share nothing too.

tank0412 said:
Lets imagine situation that MM device tree by X Anwar is shared but CM13 build is not shared.
Other people can build Marshmallow rom and push it to public. So their will get all credits. And X Anwar this way will got nothing.
So i am totally agree that he does not share sources. If i were him, i share nothing too.
Click to expand...
Click to collapse
XDA rules state that if someone shared their work and others work on it, they must give proper credits. If X Anwar thinks that others copied it, he can report it to the mods and take it down.
If Quanganh, shakalaca, knone all thought like that, there won't be any ROMs now.

​
eragon21 said:
XDA rules state that if someone shared their work and others work on it, they must give proper credits. If X Anwar thinks that others copied it, he can report it to the mods and take it down.
If Quanganh, shakalaca, knone all thought like that, there won't be any ROMs now.
Click to expand...
Click to collapse
You did not understand me.
All of this devs published device tree AFTER rom publishing.
Nobody shared BEFORE rom publishing.
So X Anway should share his device tree AFTER CM13 publishing. An it will be OK.
And other people can use it without any problems.

eragon21 said:
XDA rules state that if someone shared their work and others work on it, they must give proper credits. If X Anwar thinks that others copied it, he can report it to the mods and take it down.
If Quanganh, shakalaca, knone all thought like that, there won't be any ROMs now.
Click to expand...
Click to collapse
Agreed.
Plus this is a community, we are supposed to work together and help each other.

tank0412 said:
​You did not understand me.
All of this devs published device tree AFTER rom publishing.
Nobody shared BEFORE rom publishing.
So X Anway should share his device tree AFTER CM13 publishing. An it will be OK.
And other people can use it without any problems.
Click to expand...
Click to collapse
But I thought his ROM is bootable. Even if he didn't fix all his bugs, he could share his work so that others can help him right? Everyone, including you shared it. And, I believe many devs helped you fix some important bugs.
I know you're right. But sharing his work will benefit the community as well as him.

eragon21 said:
But I thought his ROM is bootable. Even if he didn't fix all his bugs, he could share his work so that others can help him right? Everyone, including you shared it. And, I believe many devs helped you fix some important bugs.
I know you're right. But sharing his work will benefit the community as well as him.
Click to expand...
Click to collapse
There is no senior developer who can help him. There are a Junior and Middle developers.
Note: Senior developer is a developer who first create bootable rom like Knone or Tran Huu Tin

tank0412 said:
There is no senior developer who can help him. There are a Junior and Middle developers.
Note: Senior developer is a developer who first create bootable rom like Knone or Tran Huu Tin
Click to expand...
Click to collapse
X Anwar already mentioned a issue (the only issue he mentioned), no Internal Storage, I know a fix, I tried to contact him saying about it but I got no answer.
And isn't all about being a Senior Developer, anybody can easily build a ROM nowadays (and I made the CM build a lot easier) and analyze how to fix the bugs. But as I said, this is a community, if we work together, we can make it.

[MAGISK MODULE] [SM-G920P] [DEBLOAT] TDH-JR (Just enough Remains) [v1.1.20180512]

Description
TDH-JR is a Magisk Module for extremely debloating ROMs based on the G920P stock nougat Android. The debloating is quite complete, so as little of your ROM actually runs after flash installing this module.
Screenshots
Coming . . .
Features
The entire debloat operation is systemless (i.e., no modifications occur to your base ROM, Magisk systemless overlays are used to prevent bloat from installing and running.
Extreme Debloat (Just enough ROM to Use, add your own apps)
The resulting debated system passes SafetyNet as long as your kernel also passes (suggest using @tdhite's SkyHigh Kernel).
Downloads
TDH-JR v1.1.20180512. (debloating based on Firrmware version G920PSPT4DRC2):
Android File Host Download
MD5: fcc0410e48d254be48c311a804ba271b
Updated for Magisk 16.40.
Updated for DRC2 stock firmware.
TDH-JR v1.0-20180101 (debloating based on Firrmware version G920PVPS4DQK1):
Android File Host Download
MD5: 5ffc47cae4dcd67bb38cb5afae17a8bb
How to Install -- FOLLOWING IN ORDER IS REQUIRED!
READ THE DISCLAIMER BEFORE INSTALLING!.
Assure you are on the appropriately similar base (stock) firmware.
Download the module from any of the download links above and place it in your /sdcard directory.
Strongly suggest downloading the latest @tdhite SkyHigh Kernel flash (installer) and place the zip in your /sdcard directory
Reboot to recovery (TWRP)
Make a backup of your existing ROM (TWRP nandroid is best)
Wipe Data, Dalvik, Cache (standard factory reset)
Strongly suggest installing (flashing) the latest @tdhite SkyHigh Kernel. That will install the kernel, root the phone with Magisk and install the kernel's support module. Note: if you do not install the SkyHigh kernel, you will have to manually install Magisk before installing the TDH-JR debloating module.
Dirty flashing coming from pure stock cannot debloat your ROM -- the bloat software is already installed and setup.
Dirty flashing over a system in which you previously installed this module cleanly (per instructions above) should work fine.
Flash (i.e., Install in TWRP) the flashable module zip file.
Reboot (to System)
Enjoy!
After cleanly installing (post a factory reset wipe) this module, the initial boot will take many minutes and may reboot once during the initial setup sequence. Many operations are taking place (e.g., Dalvik regeneration, activation, etc.).
Special Thanks and Credits
[MENTION]topjohnwu[/MENTION]@xda (For the venerable Magisk root)
XDA:DevDB Information
TDH-JR Debloating Magisk Module, Tool/Utility for the Sprint Samsung Galaxy S6
Contributors
tdhite
Source Code: https://github.com/TeamSPR/magisk-module-tdhjr
Version Information
Status: Stable
Current Stable Version: v1.1.20180512.
Stable Release Date: 2018-05-12
Created 2018-01-01
Last Updated 2018-05-13

Disclaimer
*** Legal Disclaimer -- READ ALL OF THE FOLLOWING ***
If you use any software from download links provided anywhere within this thread, or convey the same to someone else, you and all subsequent conveyees are bound by the following:
LEGAL DISCLAIMERS AND ASSUMPTION OF THE RISK BY THE USER OF THE PROGRAM
Assumption of the Risk of Use
YOU ASSUME, AND AGREE TO ASSUME, ALL THE RISK OF HARM BY USING THE PROGRAM. THE PROGRAM MAY VOID YOUR WARRANTY WITH A THIRD PARTY, IT MAY IMPROPERLY OPERATE AND DAMAGE YOUR DEVICE, IT MAY CAUSE ANY MYRIAD OF HARMFUL OUTCOMES REGARDING YOUR DEVICE OR THE USE OF THE DEVICE ON WHICH IT GETS INSTALLED. YOU ACKNOWLEDGE THAT YOU ARE AWARE OF THOSE RISKS, UNDERSTAND THOSE RISKS, AND VOLUNTARILY AND INTELLIGENTLY ELECT TO ENGAGE THOSE RISKS BY USING THE PROGRAM.
Disclaimer of Warranty
THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME ALL LIABILITY AND AGREE THAT IN NO EVENT WILL YOU SEEK ANY FORM OF RECOMPENSE, WHETHER LEGAL OR EQUITABLE, INCLUDING BUT NOT LIMITED TO NECESSARY SERVICING, REPAIR, CORRECTION OR OTHERWISE.
Disclaimer of Title Warranty
THERE IS NO WARRANTY OF TITLE FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING ANY CONVEYOR OF THE PROGRAM MAKES NO WARRANTY OF ANY KIND THAT HE OR SHE HAS ANY TITLE OR THE RIGHT TO TRANSFER ANY TITLE TO THE PROGRAM TO YOU. YOU ACCEPT THAT, IN FACT, YOU RECEIVE NO TITLE TO ANY OF THE PROGRAM.
Limitation of Liability
IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS THE PROGRAM, PERMITTED OR NOT, BE LIABLE TO YOU FOR LEGAL DAMAGES OR EQUITABLE RELIEF, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.

Reserved

Thanks for this! Looking forward to testing between football games. (A guy has to have priorities.)

works great
works great love the update thanks so much no problems so far lags a little during initial setup but no lag after all set up

Nice, thanks! Am I going crazy, or are the links to the module missing?

nostrings said:
Nice, thanks! Am I going crazy, or are the links to the module missing?
Click to expand...
Click to collapse
This? https://www.androidfilehost.com/?fid=673791459329070582

I do not understand this module at all, do we have to install it once we install a new stock rom? Or can i install it whenever i want? (Im on bigdaddys rom, can i install this right now?)

Ryan-sv said:
I do not understand this module at all, do we have to install it once we install a new stock rom? Or can i install it whenever i want? (Im on bigdaddys rom, can i install this right now?)
Click to expand...
Click to collapse
You can try -- I have no idea what BigDaddy loads or does not load from the stock kernel, much less its base. Whatever you do, follow the instructions.

tdhite said:
You can try -- I have no idea what BigDaddy loads or does not load from the stock kernel, much less its base. Whatever you do, follow the instructions.
Click to expand...
Click to collapse
Oh, i also have your kernel, but ok, i'll make a backup before try this

Working great, thanks @tdhite. Kernel seems to be offering support for Synapse, is that correct?

koop1955 said:
? . . Kernel seems to be offering support for Synapse, is that correct?
Click to expand...
Click to collapse
Yup. Just install Synapse and tune to your heart's content.
Sent from my iPad using Tapatalk

koop1955 said:
This? https://www.androidfilehost.com/?fid=673791459329070582
Click to expand...
Click to collapse
Yes. The XDA Labs app wasn't showing the link (see screenshot)

I installed this and i don't have the auto rotate or portrait icon when i pull down the top of phone! It is in auto rotate and i want it in portrait mode! Any help would be much appreciative??

I cannot for the life of me get Sprint Launcher or Sprint ID uninstalled. Anyone have any ideas? The phone restarts when I try to uninstall them.

_Epic said:
I cannot for the life of me get Sprint Launcher or Sprint ID uninstalled. Anyone have any ideas? The phone restarts when I try to uninstall them.
Click to expand...
Click to collapse
Have you tried adding those packages to the list of the directories in the module? It should be in the `config.sh` script. Or just post the paths here, and I am sure someone (or @tdhite) will add them to the list for the future.

nostrings said:
Have you tried adding those packages to the list of the directories in the module? It should be in the `config.sh` script. Or just post the paths here, and I am sure someone (or @tdhite) will add them to the list for the future.
Click to expand...
Click to collapse
I haven't gotten that far into it yet. I may check it out later.

Just a note for future reference - you should really not "uninstall" anything if you are using this module ... just add whatever you don't want on the list, and start again. This will ensure you are can receive OTA updates (though, these may not come anymore, as Samsung is probably abandoning this device for good now), and redo/reapply the magisk module again.

nostrings said:
Just a note for future reference - you should really not "uninstall" anything if you are using this module ... just add whatever you don't want on the list, and start again. This will ensure you are can receive OTA updates (though, these may not come anymore, as Samsung is probably abandoning this device for good now), and redo/reapply the magisk module again.
Click to expand...
Click to collapse
Actually there's a rumor from two Samsung support reps that s6 may actually get oreo! Not a reliable source, but worth holding out hope!
@tdhite Thanks for this module! I just switched over from the tdhjr Rom without a hitch. Feels clean and proper. Definitely a brilliant alternative to the tdhjr rom.
I do have one question, and anyone else who might know is welcome to chime in, which package that was debloated is responsible for how Google assistant works? I thought it was just the Google app, so i installed that (and the Google Assistant app)... But i cant use smart unlock (ya know, unlock with your voice) Does it need to be installed as a system app? Or was there another google related app/package that I'm forgetting about?

Nye-uhls said:
Actually there's a rumor from two Samsung support reps that s6 may actually get nougat! Not a reliable source, but worth holding out hope!
Click to expand...
Click to collapse
That would be super, but judging by past devices and the software they got, I'd say with 99% certainty that this is it. I'd love to be proved wrong, though ?