Develop Bugs

Can you safely replace SuperSU with Magisk on the HTC10?

I recall that installing SuperSU on the HTC10 was originally a special case. Due to the encryption it used, originally flashing SuperSU onto the HTC10 would break the cellular radio, eventually SuperSU was updated to fix this.
I want to know if Magisk is in the same boat, or it could break your radio too like SuperSU used to, or if the way it works does not cause this issue on the HTC10.
And if so, can it be installed in place of SuperSU without having to wipe/reset your data?

I haven't used Magisk so I can't speak from experience.
However:
1) I know in the ICE Rom thread, that users have recently asked for an aroma option not to have SU installed (or PHH SU installed rather than SuperSU) so they can more easily get Magisk working.
2) Secondly, the original developer of Magisk has a HTC 10.
It's a pretty safe bet to say Magisk works if you follow the instructions...

Nearly all the instructions recommend wiping your data though, and that's not an option for me.

the Dev from Magisk has a HTC10 as main device ^^
so Magisk works flawless (except maybe sprint/verizon).
Super Su is not recommended anyway, as you can read on post Nr 2.
i've been using phh's SU for a while now and havent had a single issue.
AFAIK you dont have to wipe data but restore Stock System (Image) and kernel.
stock boot.img is important to wipe the Ramdisk.

I am already on the stock rom, all I originally did was unlock the bootloader then flash SuperSU, I never flashed a custom rom.

Works fine for me!

Works great for me on Leedroid.
1) Full unroot with SuperSU (don't restore anything)
2) Flash Magisk
3) Flash PHH root
4) Install Magisk Manager
5) Install PHH SuperUser

How is Magisk better than systemless SuperSU ?

CroCop18 said:
How is Magisk better than systemless SuperSU ?
Click to expand...
Click to collapse
Its not to say one is better than the either.....
To put it in VERY simple terms (There is much more to it)
Magisk is a utility for rooted related mounts and SElinux permissive status. It allows all mods to be truly systemless. It also allows rooted users to still have the ability to utilize Android Pay. You can read MUCH more at http://forum.xda-developers.com/android/software/mod-magisk-v1-universal-systemless-t3432382
To use Magisk effectively at this point, you need PHH SuperSU.
Magisk, systemless xposed, phh supersu are all under the same umbrella and are designed to be used together.
It works perfect for me on the HTC 10 with the multiple ROMS, including stock, that I have tested. I have used SUPERSU for as long as I remember, but in this case, the modified chainfire supersu did not work smoothly for me in the systemless magisk envionrment. Gotta give thanks to both topjohnwu, PHH and chainfire alike!

Does anyone know if you use magisk will that allow you to take ota updates from HTC or will the ota updates not work using magisk either ? Another question if anyone knows I have an Unlocked HTC 10 but may get the new Marlin due out being made by Htc so I am also wondering if magisk will work and you still get your updates from Google using magisk. I just thought maybe someone one here might know rather than try to go through tons of pages on that thread itself. I am hoping so as that would rock if you could still get your ota updates and have root too using magisk.

By the way, why did you say I might have problems if I am on Sprint?

Cyber Akuma said:
Nearly all the instructions recommend wiping your data though, and that's not an option for me.
Click to expand...
Click to collapse
they say it's recommended.
this is my experience ce seting up Magisk on a LG g4 (h811) running Resurrection Remix, and super su. I have an unlocked bootloader.
my main concern was maintaining viper4android (originally installed with arise (I don't remember the version))
I downloaded all the files for magisk plus the rom (resurrection remix official, just in case I needed to start clean)
I booted into twrp, made a complete backup (system would have been enough, but safety first)
I then rebooted into Android and backed up viper4android from /system/priv-app/. removed the following, super su binary, super su app, busybox/app, Viper driver then the app, and a few other root apps installed to system (I simply deleted the apk from /system/app and /system/priv-app)
now I rebooted back into Android, once booted I rebooted into recovery
and installed all Magisk requirements, and then Magisk viper4android mod.
and finally wiped cache and dalvik/art
now I shut down for about 30 minutes (phone got too hot) stupid snapdragon 808
booted back into Android, opened play and installed the Super user needed for Magisk.
now I open kernel adiutor and allow su access (need to turn off cpus 3-6)
Now I open play and install Google pay and safetynet playground.
now I open Magisk manager, and disable root.
Open play I add my cards fine.
I exit play, and open safetynet playground and check, it passes.
now I enable root again.
I install the Viper I backed up earlier as a user app, and try and use it. Nope it's trying to Install the driver. I cancel and remove it and install the official Viper.
it works fine (remember I already installed the Viper Magisk mod earlier)
Now I'm golden.
Now I never cleared my data, but I did clear dalvik/art and cache.
the only part of arise that I changed was the Viper version, I removed arise version of viper from /system/priv-app and installed the official Viper as a user app)
in all I'm just saying make a backup and try without wiping data.
I chose to wipe dalvik/art and cache because of the major change on the device.
This may or may not work for hboot lock devices. (I'm using a LG g4 (h811))
the release thread does say you need an unlocked bootloader

Hiding root for Banking App

Hi Everyone,
I'm currently looking for a way to hide SU so that i can use my banking app, but with so many threads i'm reading, i can't find a reliable source and procedure. I'm currently studying how magisk work but some says that it doesn't work.
If i missed out a good and updated thread on hiding root, please do let me know.

You can use root switch
https://www.asus.com/zentalk/tw/thread-173542-1-1.html

Back when I was trying to get PokemeonGo to work, I tried a couple of different apps and hacks, and very few of them work, and even fewer of them work well. That was before I switched to Magisk, which I was skeptical about at first (I've been using SuperSu for years), but it really does work quite nicely.
I use Magisk, with no SuperSU. IIRC, Magisk is a systemless root, meaning it doesn't touch your /system, it flashes into your /boot. I flashed my ROM, Kernel, Magisk zip, and then downloaded the app from the play store. Inside the Magisk settings, there's a toggle for "Magisk Hide". Simply switch that on, and everything works! Your SafetyNet checks work, your banking apps work, your PokemonGo/MarioRun work, etc. Apps that already have root will continue to work, but any new apps will not be able to obtain root unless you unhide.

crazyates said:
Back when I was trying to get PokemeonGo to work, I tried a couple of different apps and hacks, and very few of them work, and even fewer of them work well. That was before I switched to Magisk, which I was skeptical about at first (I've been using SuperSu for years), but it really does work quite nicely.
I use Magisk, with no SuperSU. IIRC, Magisk is a systemless root, meaning it doesn't touch your /system, it flashes into your /boot. I flashed my ROM, Kernel, Magisk zip, and then downloaded the app from the play store. Inside the Magisk settings, there's a toggle for "Magisk Hide". Simply switch that on, and everything works! Your SafetyNet checks work, your banking apps work, your PokemonGo/MarioRun work, etc. Apps that already have root will continue to work, but any new apps will not be able to obtain root unless you unhide.
Click to expand...
Click to collapse
Thank you for sharing you experience with Magisk! i'm also skeptical with this but i will try it later, see if it will works with me. Thanks!

crazyates said:
Back when I was trying to get PokemeonGo to work, I tried a couple of different apps and hacks, and very few of them work, and even fewer of them work well. That was before I switched to Magisk, which I was skeptical about at first (I've been using SuperSu for years), but it really does work quite nicely.
I use Magisk, with no SuperSU. IIRC, Magisk is a systemless root, meaning it doesn't touch your /system, it flashes into your /boot. I flashed my ROM, Kernel, Magisk zip, and then downloaded the app from the play store. Inside the Magisk settings, there's a toggle for "Magisk Hide". Simply switch that on, and everything works! Your SafetyNet checks work, your banking apps work, your PokemonGo/MarioRun work, etc. Apps that already have root will continue to work, but any new apps will not be able to obtain root unless you unhide.
Click to expand...
Click to collapse
Just a quick question, did you just restore your boot image then flashed the magisk zip? then downloaded the app manager from play store?

yoorie016 said:
Just a quick question, did you just restore your boot image then flashed the magisk zip? then downloaded the app manager from play store?
Click to expand...
Click to collapse
I switched to Magisk at the same time I was switching ROMs, so I did a complete wipe and flash. You could do a dirty flash, but I would reflash your /system and /boot withOUT wiping cache or dalvik or anything. I don't know what (if) your previous root installed anything into /system, in which case it probably won't like it.
So what I would do If I were you is boot into recovery, re-flash your ROM/Gapps (no need to wipe cache), reflash your kernel (optional), flash the magisk zip, reboot, install magisk manager from Store, and you're good to go!

crazyates said:
I switched to Magisk at the same time I was switching ROMs, so I did a complete wipe and flash. You could do a dirty flash, but I would reflash your /system and /boot withOUT wiping cache or dalvik or anything. I don't know what (if) your previous root installed anything into /system, in which case it probably won't like it.
So what I would do If I were you is boot into recovery, re-flash your ROM/Gapps (no need to wipe cache), reflash your kernel (optional), flash the magisk zip, reboot, install magisk manager from Store, and you're good to go!
Click to expand...
Click to collapse
Thanks! i'll try it later, hopefully i dont brick my phone. LoL.

I use PureNexus with Magisk, AndroidPay, snapchat or pokemon go works but not my banking app(ANZ GoMoney Wallet), I have yet to find a solution, give magisk a try and see if it works for you. The producure is basiclly wipe system in twrp - flash purenexus - flash magisk zip - boot and install magiskmanager from play store

P.Fan said:
but not my banking app(ANZ GoMoney Wallet), I have yet to find a solution
Click to expand...
Click to collapse
Did you manage to get this working?
I'm using latest Magisk, and I always fail/error when it's performing the encryption for the wallet functionality.

mouth said:
Did you manage to get this working?
I'm using latest Magisk, and I always fail/error when it's performing the encryption for the wallet functionality.
Click to expand...
Click to collapse
No, PureNexus will not bypass the root check in the banking app despite passing safetynet for some reason. However, since then I have switched back to official stock ROM with magisk installed and haven't had a problem so far.

I use a star Finanz banking app that fails with Magisk.
The solution I found is to uninstall Magisk manager when I need to use the push TAN app and then reinstall it(Magisk manager) from my internal storage when I'm done. Seems to work for me now.

Dumb question, but you guys are using Magisk Hide for the app bank's app right? Your device is showing up as certified in the play store settings correct?

OhioYJ said:
Dumb question, but you guys are using Magisk Hide for the app bank's app right? Your device is showing up as certified in the play store settings correct?
Click to expand...
Click to collapse
Yeah, it used to not work at all. Now on latest Magisk it hides it successfully 50% of the time.
Found it easier to just uninstall the manager and reload it after. Since I only need the push TAN for online transfers.
Android pay works without a problem for me.

Snapchat login fail on rooted device

Hi guys,
I bought a HTC One M9 from my friend but I discovered that it's rooted. That's not a big issue but I can't use Snapchat because the device has been rooted. I only know it's rooted with SuperSU.
I don't know anything about roots and ROMs so can anyone help me with this problem? I red some other threads but they didn't work out... The apps hidemyroot and Root Cloaker also didn't help me.
Thanks a lot!

You'd be best off either unrooting or flashing a fresh rom without any root, and using something like Titanium Backup to backup Snapchat, and whenever you re-root, restore from that backup. You won't have to login again. (Correct me if I'm wrong, as this process had worked in the past, however I am unsure if this is the case now.)

Andranoxi said:
You'd be best off either unrooting or flashing a fresh rom without any root, and using something like Titanium Backup to backup Snapchat, and whenever you re-root, restore from that backup. You won't have to login again. (Correct me if I'm wrong, as this process had worked in the past, however I am unsure if this is the case now.)
Click to expand...
Click to collapse
Thanks for your answer! I just don't know how you do everything with roots etc. Is it possible to get the root away? Would be the best solution for me because I never use it. Is there already a good thread which tells you how to unroot your HTC? My phone is S-On so they told me it was not possible...

If you desperately need snapchat that much then you'll have to flash the phone back to its stock state. There is a thread, by flippy, in the general section stickies that explains how to do that.
Beamed in by telepathy.

Don't listen to these guys, you can download a few things and be on your merry Snapchat. What you'll need (all can be found on XDA):
UnSU-signed.zip
SuperSU 2.79 SR3 zip
suhide zip
RootSwitch 1.3.3.2
xposed framework [optional] (I recommend version 86.2 by topjohnwu)
First reboot to recovery, flash UnSU zip, then reboot to system. Download SafetyNet Helper Test and check if you pass just without root, if it's green we're good to proceed. If it doesn't pass, blue or red, you'll want to flash a ROM and start fresh.
Reboot to recovery again, flash SuperSU zip, it should install as systemless automatically. After that you can install the suhide zip and if you want xposed, then wipe Dalvik and cache and reboot.
Once you're rebooted back in the system you'll want to install the RootSwitch apk and suhide GUI from the playstore. Once they are installed, open RootSwitch and select the options for Disable USB debugging and Stop all su daemons (I also have notification showing so I always know whether it's enabled or not). Open suhide GUI and make sure these items are checked off: Android Pay, Pokemon Go, SnapChat and SystemUI. Once those options are checked, go back to RootSwitch and hit Disable Root. Open SN Helper and test again; it should be green.
You now have a device with systemless root and xposed that can be disabled at any time without a reboot and used as a stock device, working with Android Pay and other apps that block rooted phones, including SnapChat. ?
Of course, if you don't want any of this and just want a stock HTC M9, I recommend downloading the RUU for your model direct from HTC and doing a full restore on it.
Hope this helps.

I just got my Pixel XL in 2018.

Hello, its been awhile since i been in the android scene. i just got my pixel xl. i was wondering some tips and tricks. what do you guys on rom wise or is stock fine. this is my secondary phone so ill be able to root and rom. regarding rooting does it trip anything and are you able to go back to stock with google knowing.

Since super su is not be updated anymore, the only way to root (as far as I know) is Magisk.
I just installed Magisk and it was very easy. You can unlock the bootloader or not. If you do, then install lastest twrp fastboot image, the in twrp flash twrp installer zip. Boot, go back to twrp, flash magisk.zip boot and check that Magisk manager app was installed. Check if your rooted. Then go into apps and clear cache & data from play store app and clear cache from the play store services app which is right above play store app.(sorry I can't recall the exact name of this app, but you'll see it) then check play store settings and you should be certified, pass saftey net, etc.
Good luck

I've had magisk on my XL with no issue for the last 2 months. I recently installed Viper4android to have more control over my audio settings and that's been working fine for about a week. I did just find the light patch so I'm about to install that. You should check it out https://forum.xda-developers.com/pixel-xl/development/aroma-light-patch-t3681333

fiverings said:
Since super su is not be updated anymore, the only way to root (as far as I know) is Magisk.
I just installed Magisk and it was very easy. You can unlock the bootloader or not. If you do, then install lastest twrp fastboot image, the in twrp flash twrp installer zip. Boot, go back to twrp, flash magisk.zip boot and check that Magisk manager app was installed. Check if your rooted. Then go into apps and clear cache & data from play store app and clear cache from the play store services app which is right above play store app.(sorry I can't recall the exact name of this app, but you'll see it) then check play store settings and you should be certified, pass saftey net, etc.
Good luck
Click to expand...
Click to collapse
If I go this root do I option of going back without trip counter like Samsung and are you running stock or custom rom

urphonesux said:
I've had magisk on my XL with no issue for the last 2 months. I recently installed Viper4android to have more control over my audio settings and that's been working fine for about a week. I did just find the light patch so I'm about to install that. You should check it out https://forum.xda-developers.com/pixel-xl/development/aroma-light-patch-t3681333
Click to expand...
Click to collapse
Stock rom or custom? I just updated to 8.1.0 and security patch of this month. What mods do you have?

Simplyeduardo said:
Stock rom or custom? I just updated to 8.1.0 and security patch of this month. What mods do you have?
Click to expand...
Click to collapse
Ok, I'm running stock room, there aren't a lot of rooms for the pixel XL. Stock works fine. I have no desire to run a custom room on this phone. I run pure Nexus on My Nexus 6.
You can go back with Magisk and they have these modules you can add to do certain things. I usually don't mess with that kind of stuff. Good luck and you should read about Magisk on the official site but topjohnwu.

Simplyeduardo said:
Stock rom or custom? I just updated to 8.1.0 and security patch of this month. What mods do you have?
Click to expand...
Click to collapse
Are you experiencing any major bugs on 8.1?

[HELP] Root questions

Hello everyone!
I want to root my phone, but have some question before starting the process, because something maybe will not work as expected.
1. The main propose of my root is to install Cerberus as system app, wich will protect the app from a hard reset;
2. I want to remove some useless apps, like lens, google files, and others (I have found some posts with is safe to disable/remove);
3. I want to integrate the app's updates the phone receives after setting an account. I have used Link2SD on previous phones;
4. MAYBE I will install Butterfly For Daisy (the multitasking is annoying!!), so, maybe I'll install Kernel Auditior as system app.
5. I'll NOT use custom ROM, I'll keep Android One experience for now.
So, as far I read, to complete the root process, I have to disable encryption on phone. The problem is: i use 4 accounts on my phone, one of them is a Google App one, wich means when I configure it, it will ask to encrypt my phone. Google Apps accounts ALWAYS use encryption on my organization, is mandatory. So...
A. Can I root without disable encryption?
B. Can I just boot TWRP to root, without permanently install it?
C. I'll have phone updates problems with questions 1, 2, 3 and 4 above?
D. Will a Google App account work on a rooted phone with Magisk for Mi A2 Lite?
E. Magisk Manager will be installed as system app or user app? Because Cerberus will use root. If I reset the phone, I'll lose Magisk Manager if it is installed as user, so Cerberus will not get root permissions and will not work properly.
Thank you in advice, and sorry for tons of questions.

romulocarlos said:
A. Can I root without disable encryption?
B. Can I just boot TWRP to root, without permanently install it?
C. I'll have phone updates problems with questions 1, 2, 3 and 4 above?
D. Will a Google App account work on a rooted phone with Magisk for Mi A2 Lite?
E. Magisk Manager will be installed as system app or user app? Because Cerberus will use root. If I reset the phone, I'll lose Magisk Manager if it is installed as user, so Cerberus will not get root permissions and will not work properly.
Click to expand...
Click to collapse
A. Magisk/root works fine with encryption.
B. Don't use TWRP to root. But you can boot it without installing (fastboot boot image.img)
C. Follow the process in the Magisk guide thread to install OTAs.
D. No idea
E. User app. It gives itself root via Magisk.
If you modify the system image you'll have a much harder time doing OTAs. You must have unmodified partitions to install OTAs. I do this to get a dark bootanim, but for install/remove system apps you'd be much better off to use Magisk modules. There's modules for both systemizing apps and hiding system apps.

a1291762 said:
A. Magisk/root works fine with encryption.
B. Don't use TWRP to root. But you can boot it without installing (fastboot boot image.img)
C. Follow the process in the Magisk guide thread to install OTAs.
D. No idea
E. User app. It gives itself root via Magisk.
If you modify the system image you'll have a much harder time doing OTAs. You must have unmodified partitions to install OTAs. I do this to get a dark bootanim, but for install/remove system apps you'd be much better off to use Magisk modules. There's modules for both systemizing apps and hiding system apps.
Click to expand...
Click to collapse
Thank you.
A. OK, I'll try soon
B. Ok, I'll use it to take a full backup before start the process
C. You mean your guide or BubuXP's? In fact, BubuXP's seems easier to do!
D. Let's cross fingers...
E. Can I convert it to system? Like I sayed, Cerberus will need root after a reset. Without Manager, I'll not see the warning to grant root access, don't?
I'll search for these modules. Thank you.

romulocarlos said:
C. You mean your guide or BubuXP's?
E. Can I convert it to system? Like I sayed, Cerberus will need root after a reset. Without Manager, I'll not see the warning to grant root access, don't?
Click to expand...
Click to collapse
C. If you just have Magisk, use bubuxps guide. My guide is if you have magisk and twrp and want to do otas. It's mostly the same, with extra steps.
E. Magisk Manager does not need to be a system app. It won't help you if it lives on /system and Magisk gets removed.
Factory reset doesn't touch boot so I guess if you intend to do factory reset often it might be useful to put apps on system. But by doing so, you'll make it much harder to take OTAs.
To take an OTA you'll need to flash the original system, apply the ota then apply your system changes again. If you're upgrading to a release without fastboot images you'll want to take a backup of system before you modify it.
It might even be worthwhile only upgrading to fastboot releases because you'll have the backup and can modify the images before you flash them, avoiding booting without your customizations.

a1291762 said:
C. If you just have Magisk, use bubuxps guide. My guide is if you have magisk and twrp and want to do otas. It's mostly the same, with extra steps.
E. Magisk Manager does not need to be a system app. It won't help you if it lives on /system and Magisk gets removed.
Factory reset doesn't touch boot so I guess if you intend to do factory reset often it might be useful to put apps on system. But by doing so, you'll make it much harder to take OTAs.
To take an OTA you'll need to flash the original system, apply the ota then apply your system changes again. If you're upgrading to a release without fastboot images you'll want to take a backup of system before you modify it.
It might even be worthwhile only upgrading to fastboot releases because you'll have the backup and can modify the images before you flash them, avoiding booting without your customizations.
Click to expand...
Click to collapse
Thank you again. But...
C. I used BubuXP's guide. Works well. I just need an updated "Disable-Force-Encryption-Treble.zip", because it install an older version of Magisk, and I need encryption disabled to make backups, as TWRP can't make backup on /data.
E. Well, Magisk itself won't be removed after a reset, but if Magisk Manager is removed, how an app will get root permissions? The warning about the permissions comes from Magisk Manager, not from Magisk itself (the one on boot), don't?
And, yes, I want some apps on /system, as Cerberus, for example. I'll put the updates on /system, also. It makes easier to handle the phone after a reset. I don't mind too much to OTAs, as we can download the whole ROM and flash it as I need.
EDIT: don't need an updated "disable-force-encription". Just installed lastest Magisk version in TWRP after disable-force-encription.