Hi,
this is a topic I want to start in order to help the development of more intelligent brightness control for Galaxy S (probably regional variants of it will benefit as well).
It began with my PM to some of kernel DEVs that I've noticed brownish color instead of black on ONE brightness setting. My idea was to omit that one brightness level.
Overnight, I already got two responses. One that it should be no problem and one that the link I sent might lead to fixing the problem I mentioned as well (color correction).
The other, connected to brightness topic, thing I've noticed is that auto control of it is retarded. First, it's too jumpy without any reason (like let's say change of outside brightness) and second it likes to set level that burn the eyeballs. I've never had such problem on my CM Hero.
Here's my original PM:
embrion said:
Hi,
I'm PMing you as the most popular kernels coders.
Long story short: SAMOLED screens like to make black or similar colors brownish at low brightness. I've (and not only me) noticed that there's a step just about min. when it starts to be brown and a next step after that it magically stops. The idea is to omit this step at all or just in auto brightness table. I believe It's doable by using those methods.
The original story begins here from the first half of #522 post
Like I've wrote there, this problem exists in all kernels and all color temperature variants of them + stock one.
If you're interested, please respond me. If not, also respond as I'd like to know if I can count on anything.
Thanks
Click to expand...
Click to collapse
Some links that might help:
[SOLUTION] Fix for minimum screen brightness! [10/13 - adjustable]
Kernel makers, please add the ability to adjust auto brightness.
[APP] Different auto-brightness
Gizmodo - Why iPhone 4 and Android Brightness Controls Are Effectively Useless
My random thoughts:
One option would be fooling the sensor that it is less bright than it is
Another, more proper I believe, it to modify some brightness tables to leave extreme brightness levels to extreme outside light situations. This one would also help skipping this "brown" brightness level as like I said, it looks to be only one level
Color correction MIGHT fix "brown" problem too, but I'm not sure as COLD and WARM kernel variants didn't changed this brown problem (unless colors are optimized only for some of the levels like I've read at VOODOO site)
CM 6 already has such brightness level options in Settings-> CM Settings - > User interface -> Automatic backlight -> Use custom(just checked on my Hero) so probably lot of code can be reused (as I believe there is CM for Galaxy S)
Kernel DEVs, fell free to hijack this thread. It is to help your cooperation (unless each one of you prefer to solve problems on they own ) Btw. don't be offended if I didn't included you in the DEVs list I've sent my PM. It was late and I PMed only those I've noticed that they kernels I've used. All of you are more than welcomed.
Other, please don't post "I cannot see any brown", and those one that can see it, please stop posting about info after first 5 people do
I'm so happy to read this threat. I had posted questions about display and auto brightness a couple of months ago in the questions section but never received any credible responses.
My problem is that when I turn auto brightness on, not only does my display get exceptionally dark, but it becomes very noticeable that e.g. grey turns more brownish. Comparing my display to yet another Galaxy S confirmed my suspicions that this is not they way the display is supposed operate, i.e. compared to mine the other Galaxy stayed a lot brighter in equal lighting conditions and the grey remained grey (instead of brownish-grey like mine). I compared the grey tones of the numeric buttons in the stock Dialer APP to conclude this.
I suspectED the light sensor might be defective, but I have run the test menu on a couple of Galaxies (*#0589#) and the units always display the same values when put next to mine.
You might see why this is bugging me so much, it seems my galaxy's display is not using less battery even though I get less brightness than the others on auto brightness. Unless I manually bump up the brightness to full the colors on my screen look dull (grey turns Brownish, and over all it looks not as alive) as compared to other units. Simply bumping the brightness up is of course not an option, this drain the battery like crazy.
EDIT: I too have tried the various Kernels, hardcore warm and cold, voodoo w/ color fix sadly all to no avail
EDIT2: @embrion The above all doesn't explain why our phones have this problem, but the far majority of Galaxy S phones doesn't. Of course I cannot statistically back this up, but I have not physically seen any other device that gets brown on autobrightness like ours. Any Ideas?
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
embrion said:
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
Click to expand...
Click to collapse
It does not turn brown and appears much brighter in equal lighting w/ auto brightness ON. I edited my post above, please read again if it was unclear before. Thank you!!
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
embrion said:
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
Click to expand...
Click to collapse
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
(Auto)brightness corrections
Original Auto Brightness level is too high & sluggish.
It 's need to fix like a voodoo Brightness level fix (2.1 only).
schiphol said:
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
Click to expand...
Click to collapse
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
embrion said:
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
Click to expand...
Click to collapse
Which CSC code do you have? I mine was originally XEN (Netherlands). The units I tested that did not have the problem were all DBT (german Sim free). Just asked my brother and he says his phone also gets brownish (also XEN). Have to check product codes later, will update then.
Mine is XEE (Orange, Poland)
Supercurio did some tinkering with those settings:
https://github.com/project-voodoo/l...a2/Kernel/drivers/video/samsung/s3cfb_mdnie.c
I suspect this is the file we need to modify;
Code:
mDNIe_data_type mDNIe_UI[]=
{
#ifdef CONFIG_VOODOO_MDNIE
// Voodoo color: optimized UI mode
// reduce the sharpness filter radius to make it much closer
// to the real fuzzyness introduced by the SAMOLED Pentile pattern
// color saturation boost on everything is also disabled because
// it causes harm on stock settings (exaggerated colors)
0x0084, 0x0040,
0x0090, 0x0000,
0x0094, 0x0FFF,
0x0098, 0x005C,
0x009C, 0x0613,
0x00AC, 0x0000,
0x00B4, 0x0A00,
0x00C0, 0x0400,
0x00C4, 0x7200,
0x00C8, 0x008D,
0x00D0, 0x00C0,
END_SEQ, 0x0000,
Any thoughts and datasheet quotations on this? Because seriously I see just random numbers in this.
Some interesting code begins around line 315, but seriously I'm clueless
Another interesting file:
https://github.com/project-voodoo/l...2/Kernel/drivers/video/samsung/s3cfb_tl2796.c
My screen has brownish/reddish deep grays on brightness settings under 16-17%. However when I set it over 17% and use screen filter app deep grays are NOT brownish/reddish, this means there is definitely something with lower brightness settings.
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
embrion said:
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
Click to expand...
Click to collapse
@embrion so did you pm Supercurio? What did he say? It's too bad this color/sharpness fixing will probably be put on a back burner what with Gingerbread and CM7 development. D*RN IT! I tried an app in the market that is more precise than the built-in slider. Try it out Adjbrightness (free). I punched in all values possible between 2-255. The tipping point (where the browness is gone) lies at when you go from 34 to 35. Is this the same for everyone suffering from this problem. Please remove all apps like e.g. 'screen filter' before you try!
For me crucial step is going from
/ # echo 53 > /sys/devices/platform/s3cfb/spi_gpio.3/spi3.0/backlight/s5p_bl/brightness
to 54, however I'm running trasig's voodoo.
While 54 and over looks ok, lower values are... reddish/pinkish.
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
embrion said:
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
Click to expand...
Click to collapse
No fix there, just a different behaviour...
Would like to see this in next voodoo, might even write some simple user interface for this.
I have an idea but its not quite clear yet, however if this patch will let most users 'calibrate' their screens.. I think I'll give simple GUI a shot.
@embrion
Could you perhaps upload the screenshots you talked about in R64's thread so I can replicate. Because of different kernels and settings I want to try and establish beyond a doubt that the problem we're having is of the same nature and root cause. Thanks
This wont be visible on screenshots. You need to make a photo, problably with DSLR and know how to do it
I'll try it today and let you know
According to Supercurio, this is Samsung's color profile deviation, not SAMOLED fault itself.
Anything software broken can be software fixed
@schiphol, xan: yes, it won't be noticed at screenshots, I've already compared R64's black notification bar screenshots and my brown ones. Color picker showed a little difference in color (R:24, G:24, B:24 or something VS RGB: 0, 0, 0 - true black). Such difference should'n be visible and is not visible from software screenshot point of view but Samsung color profile makes 24,24,24 brown IN REAL LIFE while 0,0,0 is still black. I repeat, they're both black at screenshots no matter which brightness level is set, but only 0,0,0 black doesn't look like brown when viewed by bare human eye. Samsung profile at this brightness treats 24,24,24 as brown while it should as black.
--edited--
You're right, Xan. It's just another, ( but 1337 ) method of changing the brightness. I thought there's a plaintext table with levels accessible to change by hand
Hi Ok I have kept the brightness at 2 clicks to the right from minimum to stop grey from looking grey-brown all through today. Now my display accounts for 95% of the battery usage, it has never been this high before. The battery is at 25% whilst I only used the display for 44 minutes.
Thats ridiculous battery drainage and should be taken into careful consideration when a fix is developed for this issue. Are you guys having a similar experience??
Hi guys,
i did a search but have found nothing regarding this kind of problem.
My display shows some kind of pattern on plain colors.
http://dl.dropbox.com/u/16054199/screen.jpg
Its worst on grey and white, (certainly) not seen on a black screen, and its almost not visible on the highest screen brightness. But, its very distracting on everything below and also visible in pictures etc. if looked closely.
I come from a S2 which had not this effect. Is it a faulty screen or a normal effect of the pen tile matrix?
I see the same thing when my screen dims down before it goes to sleep.
Sent from my Galaxy Nexus using xda premium
Just before it goes into sleep mode? (which afaik is even darker than the darkest setting while it`s awake).
I clearly see it under medium backlight setting, the grey elements of the market are a place where i always see it.
hate to break it to you, but that's just how the screen is(especially when the brightness is turned down & on plain colors). i've had 2 Nexus' and both did the same, even the ones on display in my local verizon store are the same way.
Turn the brightness up and it will go away. It's a quirk of the screen technology.
Allright, so i have to live with that... Thanks for your answers!
Is it possible to edit the levels of the automatic screen brightness?
soulcrash said:
Allright, so i have to live with that... Thanks for your answers!
Is it possible to edit the levels of the automatic screen brightness?
Click to expand...
Click to collapse
If you're rooted and have Clockworkmod you can use this:
http://forum.xda-developers.com/showthread.php?t=1377410
Just make sure you meet the requirements and follow the directions in the thread. I have used this on a Verizon LTE Galaxy Nexus and didn't have any issues, even though it is in the CDMA form.
I am not the dev of this mod, just passing along the info.
awesome, thanks a lot!
I wonder if there's some kind of deeper hidden meaning to the pattern, some kind of subliminal message jk
Terminators run on Android...
Hello to all!!.. is possible to find an application to tweak the saturation of the SGS2 screen!!?... it has the worst color rendition I saw in a cellular screen, I work in photography I can not even show the pictures in my telephone!!... I like this phone but with the screen of the iphone, miles away better.
Best regards!
this maybe help http://forum.xda-developers.com/showthread.php?t=1260468
The saturation sliders does not work
wer11 said:
this maybe help http://forum.xda-developers.com/showthread.php?t=1260468
Click to expand...
Click to collapse
Thanks for your feedback, the only problem is the Saturation slider, it does not work on my SGS2 and that slider is the most important
Besides that, that application is not done in good way, the RGB sliders has to modify de levels of color not the levels of brightness as the application do.
Moving all the sliders to the left has to decrease saturation not brightness as it does in a wrong way.
Regards!
I`m disappointed too with the screen colours.If I take a picture of white walls it seems to have a white-green colour.In my old HTC HD2 with HyperDroid-CM7-2.3.7,the white was brilliant white.If I put the same picture that I taked with the HTC in my SGSII,the white looks a lot greener.Is there a fix for that problem?
gabilondo said:
I`m disappointed too with the screen colours.If I take a picture of white walls it seems to have a white-green colour.In my old HTC HD2 with HyperDroid-CM7-2.3.7,the white was brilliant white.If I put the same picture that I taked with the HTC in my SGSII,the white looks a lot greener.Is there a fix for that problem?
Click to expand...
Click to collapse
The colors of SGS2 are pure crap, I dont understand why there are lot of people interested in develop a firmware but they forget this part that is really important, you pay lot of money for a phone that gives you crap colors, totally biased and has no possibility to calibrate them.
Totally agree...My old HD2 with 5MP camera takes a lot better photos than SGSII.The problem is RGB calibration of the screen,not the camera.
gabilondo said:
Totally agree...My old HD2 with 5MP camera takes a lot better photos than SGSII.The problem is RGB calibration of the screen,not the camera.
Click to expand...
Click to collapse
Yes, I refer to the color rendition of the screen.
+1 for this... couldn't find any screen tuner/gamma adjuster/saturation adjuster or whatsoever for i9100 that work in ICS...
And my screen is way too blueish... and color is washed....
Crescendo Xenomorph said:
+1 for this... couldn't find any screen tuner/gamma adjuster/saturation adjuster or whatsoever for i9100 that work in ICS...
And my screen is way too blueish... and color is washed....
Click to expand...
Click to collapse
The gamma should not be modified, if some app is modifying the gamma is doing the wrong thing, it should modify RGB values or saturation remaining the brightness constant.
Hmmm, i thought it was gamma thing also... since I hate the blueish tint... I prefer warmer color.... >,<
Crescendo Xenomorph said:
Hmmm, i thought it was gamma thing also... since I hate the blueish tint... I prefer warmer color.... >,<
Click to expand...
Click to collapse
What you are looking for is the Kelvin temperature to change, changing the gamma curve will change the behavior of brightness and color and that is not the way.
The controls that should have the telephone are real RGB controls without modifying the brightness, Temperature and Saturation, even better Contrast (but it should not change the colors), with that controls you could calibrate the screen the way best fit to you.
Maybe that's the control that included in CM9...
I've recently purchased 2 LG G3 from T-mobile and strangely, the screen colors on those two appear to be quite different? (one seems to be warmer and sort of darker, I have two screen at the same brightness level)
The easiest way to tell the difference is to pull out the setting screen where there are menu options in white background, the colors on the white backgrounds are clearly different on two devices. I've also tried to compare the two I have with another G3 in T-mobile store, and the 3rd one doesn't have the same color to any of mine G3's. The color adjustment settings on all 3 devices are OFF, I've tried to factory reset the devices I owned but nothing changed. Anyone notice the same issue with your G3?
Also I notice there's a code on the back of the back cover of the G3, does that code represent anything? Is it okay to swap the back covers of the 2 G3's with same model?
Thanks
That's just the QC tolerance from what I understand. My korean G3 has warmer colors while my D850 has cooler ones. You can swap back covers without any issues so don't worry about that. Anyway back to the displays, you can download an app to adjust the color tone. At the end of the day it's just how that particular display is.
Thanks for your reply.
Yeah, I've never had a chance to compare two devices with the same model. I've always expected them to have the same exact screen colors.
Could you point me to some apps that can adjust screen color tone? The Color Adjustments setting under Accessibility setting menu is just for contrast, right?
Trickster mod if you are rooted is a good one. Just search the play store for it there should be quite a few out there.
Hey guys, having an extremely annoying problem here. Hoping it's an easy solution but I must be Googling the wrong terms as I can't find what I'm looking for.
Pixel 2 owner here, and when I am shooting videos, for instance against a white background, the temperature keeps rapidly changing instead of changing constant. The walls will turn "yellowish orange" tint as the temp gets warmer for no reason, then as I adjust the phone while recording, it will go back to a neutral white backdrop and the colors no longer look a shade of yellow.
Basically everything keeps shifting to warm tones against my will, and it's extremely frustrating.
Is this something I can disable?
duckdown said:
Hey guys, having an extremely annoying problem here. Hoping it's an easy solution but I must be Googling the wrong terms as I can't find what I'm looking for.
Pixel 2 owner here, and when I am shooting videos, for instance against a white background, the temperature keeps rapidly changing instead of changing constant. The walls will turn "yellowish orange" tint as the temp gets warmer for no reason, then as I adjust the phone while recording, it will go back to a neutral white backdrop and the colors no longer look a shade of yellow.
Basically everything keeps shifting to warm tones against my will, and it's extremely frustrating.
Is this something I can disable?
Click to expand...
Click to collapse
I have also seen this behaviour n not much can not be done
Sent from my Pixel 2 XL using Tapatalk
duckdown said:
Hey guys, having an extremely annoying problem here. Hoping it's an easy solution but I must be Googling the wrong terms as I can't find what I'm looking for....
Click to expand...
Click to collapse
What light are you shooting videos under vs. the camera settings? For example fluorescent light is notorious for bad coloring. Agree "auto" should work, but if you're looking for a toggle, I would start there. Pick a light setting that matches the environment and see if it improves your results.