Related
Hi,
this is a topic I want to start in order to help the development of more intelligent brightness control for Galaxy S (probably regional variants of it will benefit as well).
It began with my PM to some of kernel DEVs that I've noticed brownish color instead of black on ONE brightness setting. My idea was to omit that one brightness level.
Overnight, I already got two responses. One that it should be no problem and one that the link I sent might lead to fixing the problem I mentioned as well (color correction).
The other, connected to brightness topic, thing I've noticed is that auto control of it is retarded. First, it's too jumpy without any reason (like let's say change of outside brightness) and second it likes to set level that burn the eyeballs. I've never had such problem on my CM Hero.
Here's my original PM:
embrion said:
Hi,
I'm PMing you as the most popular kernels coders.
Long story short: SAMOLED screens like to make black or similar colors brownish at low brightness. I've (and not only me) noticed that there's a step just about min. when it starts to be brown and a next step after that it magically stops. The idea is to omit this step at all or just in auto brightness table. I believe It's doable by using those methods.
The original story begins here from the first half of #522 post
Like I've wrote there, this problem exists in all kernels and all color temperature variants of them + stock one.
If you're interested, please respond me. If not, also respond as I'd like to know if I can count on anything.
Thanks
Click to expand...
Click to collapse
Some links that might help:
[SOLUTION] Fix for minimum screen brightness! [10/13 - adjustable]
Kernel makers, please add the ability to adjust auto brightness.
[APP] Different auto-brightness
Gizmodo - Why iPhone 4 and Android Brightness Controls Are Effectively Useless
My random thoughts:
One option would be fooling the sensor that it is less bright than it is
Another, more proper I believe, it to modify some brightness tables to leave extreme brightness levels to extreme outside light situations. This one would also help skipping this "brown" brightness level as like I said, it looks to be only one level
Color correction MIGHT fix "brown" problem too, but I'm not sure as COLD and WARM kernel variants didn't changed this brown problem (unless colors are optimized only for some of the levels like I've read at VOODOO site)
CM 6 already has such brightness level options in Settings-> CM Settings - > User interface -> Automatic backlight -> Use custom(just checked on my Hero) so probably lot of code can be reused (as I believe there is CM for Galaxy S)
Kernel DEVs, fell free to hijack this thread. It is to help your cooperation (unless each one of you prefer to solve problems on they own ) Btw. don't be offended if I didn't included you in the DEVs list I've sent my PM. It was late and I PMed only those I've noticed that they kernels I've used. All of you are more than welcomed.
Other, please don't post "I cannot see any brown", and those one that can see it, please stop posting about info after first 5 people do
I'm so happy to read this threat. I had posted questions about display and auto brightness a couple of months ago in the questions section but never received any credible responses.
My problem is that when I turn auto brightness on, not only does my display get exceptionally dark, but it becomes very noticeable that e.g. grey turns more brownish. Comparing my display to yet another Galaxy S confirmed my suspicions that this is not they way the display is supposed operate, i.e. compared to mine the other Galaxy stayed a lot brighter in equal lighting conditions and the grey remained grey (instead of brownish-grey like mine). I compared the grey tones of the numeric buttons in the stock Dialer APP to conclude this.
I suspectED the light sensor might be defective, but I have run the test menu on a couple of Galaxies (*#0589#) and the units always display the same values when put next to mine.
You might see why this is bugging me so much, it seems my galaxy's display is not using less battery even though I get less brightness than the others on auto brightness. Unless I manually bump up the brightness to full the colors on my screen look dull (grey turns Brownish, and over all it looks not as alive) as compared to other units. Simply bumping the brightness up is of course not an option, this drain the battery like crazy.
EDIT: I too have tried the various Kernels, hardcore warm and cold, voodoo w/ color fix sadly all to no avail
EDIT2: @embrion The above all doesn't explain why our phones have this problem, but the far majority of Galaxy S phones doesn't. Of course I cannot statistically back this up, but I have not physically seen any other device that gets brown on autobrightness like ours. Any Ideas?
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
embrion said:
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
Click to expand...
Click to collapse
It does not turn brown and appears much brighter in equal lighting w/ auto brightness ON. I edited my post above, please read again if it was unclear before. Thank you!!
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
embrion said:
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
Click to expand...
Click to collapse
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
(Auto)brightness corrections
Original Auto Brightness level is too high & sluggish.
It 's need to fix like a voodoo Brightness level fix (2.1 only).
schiphol said:
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
Click to expand...
Click to collapse
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
embrion said:
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
Click to expand...
Click to collapse
Which CSC code do you have? I mine was originally XEN (Netherlands). The units I tested that did not have the problem were all DBT (german Sim free). Just asked my brother and he says his phone also gets brownish (also XEN). Have to check product codes later, will update then.
Mine is XEE (Orange, Poland)
Supercurio did some tinkering with those settings:
https://github.com/project-voodoo/l...a2/Kernel/drivers/video/samsung/s3cfb_mdnie.c
I suspect this is the file we need to modify;
Code:
mDNIe_data_type mDNIe_UI[]=
{
#ifdef CONFIG_VOODOO_MDNIE
// Voodoo color: optimized UI mode
// reduce the sharpness filter radius to make it much closer
// to the real fuzzyness introduced by the SAMOLED Pentile pattern
// color saturation boost on everything is also disabled because
// it causes harm on stock settings (exaggerated colors)
0x0084, 0x0040,
0x0090, 0x0000,
0x0094, 0x0FFF,
0x0098, 0x005C,
0x009C, 0x0613,
0x00AC, 0x0000,
0x00B4, 0x0A00,
0x00C0, 0x0400,
0x00C4, 0x7200,
0x00C8, 0x008D,
0x00D0, 0x00C0,
END_SEQ, 0x0000,
Any thoughts and datasheet quotations on this? Because seriously I see just random numbers in this.
Some interesting code begins around line 315, but seriously I'm clueless
Another interesting file:
https://github.com/project-voodoo/l...2/Kernel/drivers/video/samsung/s3cfb_tl2796.c
My screen has brownish/reddish deep grays on brightness settings under 16-17%. However when I set it over 17% and use screen filter app deep grays are NOT brownish/reddish, this means there is definitely something with lower brightness settings.
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
embrion said:
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
Click to expand...
Click to collapse
@embrion so did you pm Supercurio? What did he say? It's too bad this color/sharpness fixing will probably be put on a back burner what with Gingerbread and CM7 development. D*RN IT! I tried an app in the market that is more precise than the built-in slider. Try it out Adjbrightness (free). I punched in all values possible between 2-255. The tipping point (where the browness is gone) lies at when you go from 34 to 35. Is this the same for everyone suffering from this problem. Please remove all apps like e.g. 'screen filter' before you try!
For me crucial step is going from
/ # echo 53 > /sys/devices/platform/s3cfb/spi_gpio.3/spi3.0/backlight/s5p_bl/brightness
to 54, however I'm running trasig's voodoo.
While 54 and over looks ok, lower values are... reddish/pinkish.
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
embrion said:
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
Click to expand...
Click to collapse
No fix there, just a different behaviour...
Would like to see this in next voodoo, might even write some simple user interface for this.
I have an idea but its not quite clear yet, however if this patch will let most users 'calibrate' their screens.. I think I'll give simple GUI a shot.
@embrion
Could you perhaps upload the screenshots you talked about in R64's thread so I can replicate. Because of different kernels and settings I want to try and establish beyond a doubt that the problem we're having is of the same nature and root cause. Thanks
This wont be visible on screenshots. You need to make a photo, problably with DSLR and know how to do it
I'll try it today and let you know
According to Supercurio, this is Samsung's color profile deviation, not SAMOLED fault itself.
Anything software broken can be software fixed
@schiphol, xan: yes, it won't be noticed at screenshots, I've already compared R64's black notification bar screenshots and my brown ones. Color picker showed a little difference in color (R:24, G:24, B:24 or something VS RGB: 0, 0, 0 - true black). Such difference should'n be visible and is not visible from software screenshot point of view but Samsung color profile makes 24,24,24 brown IN REAL LIFE while 0,0,0 is still black. I repeat, they're both black at screenshots no matter which brightness level is set, but only 0,0,0 black doesn't look like brown when viewed by bare human eye. Samsung profile at this brightness treats 24,24,24 as brown while it should as black.
--edited--
You're right, Xan. It's just another, ( but 1337 ) method of changing the brightness. I thought there's a plaintext table with levels accessible to change by hand
Hi Ok I have kept the brightness at 2 clicks to the right from minimum to stop grey from looking grey-brown all through today. Now my display accounts for 95% of the battery usage, it has never been this high before. The battery is at 25% whilst I only used the display for 44 minutes.
Thats ridiculous battery drainage and should be taken into careful consideration when a fix is developed for this issue. Are you guys having a similar experience??
hello,
since the leaked Froyo Updates the screen is a little bit darker then before. Is it possbile to increase the screen brightness on froyo roms ?
Maybe this seems to be the reason Froyo saves more power then Eclair.
any ideas ?
thanks
Just go to settings/display/uncheck auto brightness and move the slider to your liking.
i have already moved the slider to maximum brightesns - but it not as bright as before with Eclair.
yeah. i have noticed this one too. have compared several times the brightness of the eclair to froyo and there is a great difference comparing the 100% brightness
Hmm, strange. I know by default the Froyo version has night mode on by default. I wonder if that has anything to do with it?
Try to use this app;ledefy
Is there someone who has already found a real solution? The thing with the brightness is very, very bad.
The screen goes dark after the vibration on boot progress. The kernel is load before, isn't it? Then normally this should be no problem to increase the screen brightness for the devs?
In hope, greetz from Germany!
echo 1 > /sys/class/leds/lcd-backlight/als
Click to expand...
Click to collapse
or use ledefy
slph said:
echo 1 > /sys/class/leds/lcd-backlight/als
Click to expand...
Click to collapse
How you can set this value after boot? Is there any init folder from where you could run a script?
download terminal emulator and run this command, this should fix the brightness (it did it for me) providing that your phone is rooted!
zakoo2 said:
download terminal emulator and run this command, this should fix the brightness (it did it for me) providing that your phone is rooted!
Click to expand...
Click to collapse
Right, but I won't do that each time after I rebooted my phone.
Great! Works fine....there's a way to auto execute this command on startup?
I don't know how to execute this command on startup but i'm using the ledefy app (ledefy.com). There you can set the increase brigthness fix and autostart on startup.
Furthermore it will give you a nice battery icon in the status bar with 1% steps and various other fixes...
ledefy does not work on CM7
becaus every time i switch of my screen, the brightness will be decreased to the CM7 default brightness. If i switch on my screen i can increas brightness again with ledefy.
What exactly does this line?
"echo 1 > /sys/class/leds/lcd-backlight/als"
Is it setting backlight fix to a MAX or is it increasing the range of control?
If it is increasing the range - is it works for automatic or manuel or both?
What is the default value to go back?
I know this is possible in CM9's display settings, but I'm currently running AOKP. Is there any other way to lower the minimum screen brightness?
I've given Tasker root permissions, approved it as a device administrator, and approved it as an accessibility service. Still, when I use a task to lower the brightness to very low levels, the brightness will only hold for a fraction of a second before it ramps up to the factory minimum.
So is there some system component I can modify to allow lower brightness, or is this only available as a ROM control like in CM9?
byrong said:
So is there some system component I can modify to allow lower brightness, or is this only available as a ROM control like in CM9?
Click to expand...
Click to collapse
FWIW the lowest possible brightness setting can't be altered via the CM9 settings, only the auto brightness levels, both sensor input levels ("bins") and the brightness level associated with that input/bin. The minimum value of 19 for the lowest slot can't be lowered further. There are other display parameters (related to brightness) that can also be altered in the CM9 settings, but it won't accept a value less than 19.
Edit: I see from a link in your sig that you're familiar with the custom levels
Yes we can do it in the frameworks to go lower than 19. I did it on other phones. I'm not sure why it hasnt been done yet for nexus, and ive been too lazy myself.
But we can even take it down to zero or 4-5 etc so its much dimmer at night. Its on my to do list.
Also i posted some kernel code in a similar thread where this question was already asked. But mod the framework is much quicker.
RogerPodacter said:
Yes we can do it in the frameworks to go lower than 19. I did it on other phones. I'm not sure why it hasnt been done yet for nexus, and ive been too lazy myself.
But we can even take it down to zero or 4-5 etc so its much dimmer at night. Its on my to do list.
Also i posted some kernel code in a similar thread where this question was already asked. But mod the framework is much quicker.
Click to expand...
Click to collapse
I should have clarified more clearly that my post above was regarding doing it via the CM settings.
I'll mod mine...at some point...but like you, too lazy for something that won't blow me away.
You want this app, works great https://play.google.com/store/apps/...yZy5wcm9qZWN0dm9vZG9vLmRpc3BsYXlmaWx0ZXIiXQ..
Sent from my Galaxy Nexus GSM using Tapatalk expect possible typos
I'm an idiot; I just found it in AOKP. It's in the custom backlight settings.
My experience does not mirror you guys. When I decrease the "screen dim level" in the custom brightness settings, it applies globally. I just did it in AOKP the same way I used to in CM9 and now with Tasker I've taken the screen all the way down to 1
Is there any way to decrease the minimum brightness on stock?
aidanbree said:
Is there any way to decrease the minimum brightness on stock?
Click to expand...
Click to collapse
Yes with above linked app. I confirm it works on stock
Sent from my Galaxy Nexus using Tapatalk
I've used a similar app called Screen Filter. My only problem with these types of apps is that I find the black/gray filter they use greatly decreases contrast at low brightness levels (more so than a "true" brightness level at an equivalent setting). Still, if you are running a setup in which they are your only option, they certainly beat having nothing.
The problem with using a screen filter is that it limits the maximum brightness when in sunlight.
I only want to affect the minimum as it is too bright.
Has anyone been able to do this on a stock rom? I too think that the minimum brightness is too high, but I don't want to use the above linked program because it also affects the maximum brightness too. I would like to be able to set custom light levels as per cm9/cm10 and pretty much any custom ROM right now, albeit with my stock ROM. Any flashable zips out there?
Cheers,
Dan
First of all, yes i turned autobrightness off and turned it manually up to the max, but i think that the brightnes goes down in some apps or the brightnes is just kinda low on the note 2? i am on this rom http://forum.xda-developers.com/showthread.php?t=2259479
Brightness level on all Samsung phones is good... that ROM uses a lot of dark/black themes... so my guess is just the apps that are dark themed will appear lower in brightness.
However do check (in settings) your Screen mode.. if it is set to standard or Dynamic...check Brightness settings (in settings again, not toggles) to see if Auto is set and where the "line dot" is set... and further down check if you have "Auto adjust screen tone" checked.
But you have enough post counts to ask in that ROM thread for better answers. Good luck!
Yeah, I've also noticed low brightness on stock based 4.3 ROM.You may use some other apps to control it (never tried them).
However now I'm on miui and the brightness adapt seems much better.
Sent from galaxy n7105
Do you have problems with auto brightness in MIUI roms? Your screen brightness gets extremely dark in low light conditions, or the brightness spikes just with a few increase of light?
For low brightness problem, actually you can adjust the minimum autobrightness in slider bar, but sometimes it will reset back to default minimum brightness. For example if you turn off auto brightness in game, when you turn it on again, it won't resume your settings. As a result the screen will get darker than your adjustment.
I created magisk module to fix that. This will increase the minimum brightness in low light, and also reduce the over brightness in medium and high ambient light. The result will be smoother auto brightness step, and be more convenient for your eyes!
There are two modules, one for Miui 10 running Android Pie, and the other ones for Miui 10 running Android Oreo. Dont install wrong module, because there are much more brightness values in Android P than O.
The Oreo version may be not as good as Pie version, because i tested it in Redmi Note 5. My Mi Mix 2s currently running Miui 10 P beta 8.8.16 for Pie version testing. But it should give the same result. Oreo version works in Miui 9 too, but may results different.
So what this module do? It adds framework-res to the /system/media/theme/default. With a magisk module you can do it systemlessly! To install it, just download the module then browse it in Magisk Manager.
If you dont like my setting values, just unzip my module, find framework-res file, unzip it, then edit the theme_values.xml to any values you want under "config_autoBrightnessLcdBacklightValues", then zip all back.
Download links in attachment.
Guide:
V1 for lowest brightness (best battery)
V2 for a bit brighter in low light
V3 for brighter brightness (best for full edge cover tempered glass user)
V4 for more responsive and smoother auto brightness. Values are about similar to v3.
To check if this module works;
Tap the Kernel Version in About Phone 5 times, then you will enter CIT. Go to Light Sensor. Cover your phone light sensor on upper bezel (lower for Mi Mix 2s) with your palm till the light sensor value reach 0. If the backlight is not going under 100/130 (pie) or 7 (oreo), then this module works! My module limits the minimal auto brightness, which the original can reach to 20 which is ridiculously very dark.
This module may work on any MIUI-based rom phones with IPS display, not just Mi Mix 2s.
I also created this module for Mi 9 (amoled display). Visit my thread HERE
Notes:
- Only V4 has responsitivity adjustment. More responsive means it needs less light increments to trigger auto brightness adjustment.
- Editing the values can cause a mess. Add .disable_magisk file in cache partition if your phone cant boot then uninstall the module in manager.
Thanks have flashed this and will see how it goes over a day/night. Initially it's good though.
I find the auto bright annoying sometimes especially given how easy it is to cover the bottom chin sensors on this phone.
M.
mattman83 said:
Thanks have flashed this and will see how it goes over a day/night. Initially it's good though.
I find the auto bright annoying sometimes especially given how easy it is to cover the bottom chin sensors on this phone.
M.
Click to expand...
Click to collapse
Thanks for trying. I hope you get better auto brightness experience after a day..
Yeah the worst part is the light sensor in mix 2s located in bottom left where you could get the screen unseenable while using two/left hands. If its in center, it would be better.
My other mi phone with forehead light sensor often gets annoyingly too dark. I never satisfied with miui default auto brightness and always use this mod since miui 7. Fortunately, this method still works with some adjustment in value.
Ok so it's been a couple of days and this has helped a lot imo at least for indoors (haven't really had any major outdoors time...).
Still gets dark enough when it's really dark, but certainly for normal indoor conditions the default settings you have are much better. Xiaomi settings often got too dark, and you can adjust the slider, but then the slider goes back after while anyway :-\
M.
Just reporting back after a while with this and more miui updates, seems the later beta builds have changed something in the brightness in that I don't know if this mod works any more, or if it needs tweaking to provide the same brightness levels it used to.
I had a really quick play with values as suggested in the op but it's well outside my field of expertise and couldnt get it to do much different
M.
@arddy1
... where to find the default values ?
I'm on Poco F1 and want to compare to the default values and adjust theme_values.xml
mattman83 said:
Just reporting back after a while with this and more miui updates, seems the later beta builds have changed something in the brightness in that I don't know if this mod works any more, or if it needs tweaking to provide the same brightness levels it used to.
I had a really quick play with values as suggested in the op but it's well outside my field of expertise and couldnt get it to do much different
M.
Click to expand...
Click to collapse
Sorry for late reply. This mod still works in miui 8.10.11 global. Here are the screenshots of screen light value in lowest brightness. The lower one is the original. Mine still brighter in lowest light.
der_Kief said:
@arddy1
... where to find the default values ?
I'm on Poco F1 and want to compare to the default values and adjust theme_values.xml
Click to expand...
Click to collapse
Here's the screenshot from framework_res in rom 8.10.11 global
So it only works on miui
Yes since it's a miui issue. Stock android roms don't reset brightness like miui.
Stock roms just set the brightness bar where you want, some will have the ability adjust the total curve even. Miui if you raise brightness it will change itself back after 5 mins or so, so it's needed to change the system default values
M.
mattman83 said:
Yes since it's a miui issue. Stock android roms don't reset brightness like miui.
Stock roms just set the brightness bar where you want, some will have the ability adjust the total curve even. Miui if you raise brightness it will change itself back after 5 mins or so, so it's needed to change the system default values
M.
Click to expand...
Click to collapse
To me it happens on the treble roms. Exactly as in miui.. might be a vendor thing idk
Can I use this on Vince running Resurrection Remix 6.2.1 Android Oreo? I am having auto brightness issue in custom ROMs too.
Shubhambora said:
Can I use this on Vince running Resurrection Remix 6.2.1 Android Oreo? I am having auto brightness issue in custom ROMs too.
Click to expand...
Click to collapse
No, its for miui only. Even using it on miui other than i specified in first post may not work
Can you check with the latest miui 8.11.15?
I'm currently using this but sometimes the brightness still jumps from dim to bright
Thanks for this fix!
Can you make flashable zip version via TWRP recovery? I don't use Magisk and I don't want to be rooted
Sent from my MIX 2S using Tapatalk
Max auto brightness level can be increased from current value?
From 4095 to 4500
It would better in sunlight
Sent from my MIX 2S using Tapatalk
hi any chance to have it without root?
graw2 said:
Max auto brightness level can be increased from current value?
From 4095 to 4500
It would better in sunlight
Sent from my MIX 2S using Tapatalk
Click to expand...
Click to collapse
No. 4095 is the max value.
H0unter said:
hi any chance to have it without root?
Click to expand...
Click to collapse
Yes you can. As long as you unlock bootloader and place the framework-res file in system path i mentioned in first post with twrp
I tried your auto brightness fix. And surprisingly it seems to work on the Mi Max 3 with xiaomi.eu 8.12.6v2 as well.
palmdude said:
I tried your auto brightness fix. And surprisingly it seems to work on the Mi Max 3 with xiaomi.eu 8.12.6v2 as well.
Click to expand...
Click to collapse
Agreed, on 8.12.13 xiaomi.eu (pie) Mi Max 3 it works very well. Thank you for your efforts OP.