Develop Bugs

Android 8.1 + Magisk

Hi!
Does Magisk (including root, etc.) work flawlessly on a Pixel C with Android 8.1? Or is better to stay with 8.0 and wait a little bit?
Thanks in advance and kind regards,
star3141.

It works, initially it would force close but now seems stable. I used v14.5 beta.
On the other hand super su by chainfire does not work. Would flash but app missing. Downloading from play store and updating binaries through app causes boot loop.

v14.5 works perfectly here, no problems at all.

Hi!
Thanks for the replies. Maybe I will give it a try at Christmas or alternatively wait for the first update of 8.1 in January.

Hello!
Today, I gave it a try but unfortunately faced some kind of total reflection.
1. I downloaded and flashed the latest android factory image (ryu-opm1.171019.016 = 8.1 from Feb. 2018) from Google.
2. I downloaded and booted (without installing) twrp-3.2.1-0-dragon by means of "fastboot boot twrp-3.2.1-0-dragon.img"
3. In TWRP I mounted the system partition rw
However, after mounting the system partition rw, android won't boot into the system anymore. I am alway getting the green android guy laying on its back with "No command". When I boot into TWRP and mount /system in ro-mode, then will boot afterwards without any problems. So the problem must be related to mounting /system in rw-mode by TWRP.
I have also tried twrp-3.0.0-0-dragon-ryu-02112016-1.img, which worked on my previous 8.0 installation, but it won't work in this 8.1 release anymore.
Any ideas how to get rid of this problem?
Thanks in advance and kind regards,
star3141.

Hello!
I found a solution!
If someone else suffers from similar problems then try the following which hopefully will fix everything: :fingers-crossed:
1. Download and flash the latest (in my case Android 8.1 from Feb. 2018) android factory image from Google.
2. Complete the standard android setup procedure and, when the system is up and running, enable "USB debugging" in the "Developer Options".
3. Restart your device in bootloader mode by "adb reboot bootloader".
4. Format your /data partition by "fastboot format userdata" to remove the filesystem encryption.
5. Download the latest TWRP (in my case "twrp-3.2.1-0-dragon.img") and start it by "fastboot boot twrp-3.2.1-0-dragon.img".
6. In TWRP mount /system in rw-mode and just to be sure check if the /data partition can be accessed. If not, just wipe/format it as ext4 again.
7. Download the latest Magisk (in my case "Magisk-v15.3.zip") and sideload it by "adb sideload Magisk-v15.3.zip" in TWRP.
8. Reboot into the android system and install the Magisk app (in my case "MagiskManager-v5.5.5.apk")
9 Viola! Enjoy a working and rooted android 8.1. :victory:
Kind regards,
star3141.

didn't have any problems with magisk 15.3 on 8.1 but with 16.0 the pixel won't boot anymore (stays at the google logo, not even reaching the bootaniamtion). anyone else having this issue? after flashing boot-image and reinstalling magisk 15.3 it works fine again...

For me as well, get 16.0 not to run, Bootloop

Yep, same here, then I bricked it restoring a nandroid backup where it destroyed system, then I couldn't get past encryption password in TWRP. So it's been one of those days...

m+a+r+k said:
Yep, same here, then I bricked it restoring a nandroid backup where it destroyed system, then I couldn't get past encryption password in TWRP. So it's been one of those days...
Click to expand...
Click to collapse
did you already try "default_password" (without quotes of course)? had this issue too some time ago after restoring a nandroid – reflashing twrp via fastboot and decrypting with default_password helped

doumer said:
did you already try "default_password" (without quotes of course)? had this issue too some time ago after restoring a nandroid – reflashing twrp via fastboot and decrypting with default_password helped
Click to expand...
Click to collapse
Yes, tried that as well. I think I just corrupted the system, wiped data and system in trying to get around the Magisk problem.

m+a+r+k said:
Yes, tried that as well. I think I just corrupted the system, wiped data and system in trying to get around the Magisk problem.
Click to expand...
Click to collapse
Hm, as long as you still have fastboot access, I would try to manually flash partiotions (system, vendor etc), flash twrp, install masgisk 15.3, start from scratch and restore the apps with titanium backup (hopfully you have a backup!). as long as its not a hard brick, it's all fixable

doumer said:
Hm, as long as you still have fastboot access, I would try to manually flash partiotions (system, vendor etc), flash twrp, install masgisk 15.3, start from scratch and restore the apps with titanium backup (hopfully you have a backup!). as long as its not a hard brick, it's all fixable
Click to expand...
Click to collapse
Oh, I'm back to normal now. I couldn't get it to connect to PC as all I had was fastboot and recovery. I discovered the only way to get adb/fastboot connection from PC was to go into TWRP and ADB Sideload. Once that was established it made the connection and I installed 8.1 from the command line with the flash-all.bat.
Then I could restore the nandroid. All is well now, thanks.

good to hear!

Same problem here with 16.0. Seems to be either a bug or some kind of incompatibility with the pixel c.

Magisk 16 and Pixel C
Any word on resolution of the boot loop issue?

Reflash + downgrade to 15.3 seems the only working solution at the moment.

I have re-rooted using Magisk 15.3 from SuperSu. Am I OK updating to 16.0 through Magisk, or should I try 16.3?

mightywhites29111971 said:
I have re-rooted using Magisk 15.3 from SuperSu. Am I OK updating to 16.0 through Magisk, or should I try 16.3?
Click to expand...
Click to collapse
16.0 causes a boot loop. Somebody else had an issue with 16.3. I'd stay with 15.3. Just turn off update notifications and Magisk won't bother you.

Cheers

My /data partition always gets encrypted again after beeing formatted

Hi,
I try to install LineageOS 14.1 + Magisk 15.0 without encryption on Data, but it always is encrypted after installation again.
Here are the steps I take:
1. Install TWRP 3.2.1-0
2. Boot into TWRP recovery (getting prompted to enter pattern so it can decrypt data)
3. Format Data (forced to type "yes" , so did not only wipe it)
4. Reboot into recovery to proove that I am unencrypted now (not prompted again for the pattern again)
5. Install LineageOS 14.1
6. Install Magisk 15.0
7. Install Google Apps
8. Reboot into system, installing LineageOS, some apps, etc.
The next time I boot into recovery, I get prompted for the pattern so I guess my Data partition is encrypted again.
I tried several variants of install packages, also the "no-enforce-encrypt-no-verify" package (after installing LineageOS), but got no luck so far.
Please could someone tell me what I am doing wrong and what to do to avoid encryption of data again?
Thank you!
fex42

fex42 said:
Hi,
I try to install LineageOS 14.1 + Magisk 15.0 without encryption on Data, but it always is encrypted after installation again.
Here are the steps I take:
1. Install TWRP 3.2.1-0
2. Boot into TWRP recovery (getting prompted to enter pattern so it can decrypt data)
3. Format Data (forced to type "yes" , so did not only wipe it)
4. Reboot into recovery to proove that I am unencrypted now (not prompted again for the pattern again)
5. Install LineageOS 14.1
6. Install Magisk 15.0
7. Install Google Apps
8. Reboot into system, installing LineageOS, some apps, etc.
The next time I boot into recovery, I get prompted for the pattern so I guess my Data partition is encrypted again.
I tried several variants of install packages, also the "no-enforce-encrypt-no-verify" package (after installing LineageOS), but got no luck so far.
Please could someone tell me what I am doing wrong and what to do to avoid encryption of data again?
Thank you!
fex42
Click to expand...
Click to collapse
Use this recovery:

Pendragon2000 said:
Use this recovery:
Click to expand...
Click to collapse
Thank you, but it seems not to be caused by my TWRP version (3.2.1-0). In the meantime I installed LineageOS 15.1 but did format data again just before rebooting and now data stays unencrypted (does not ask me for unlock pattern in TWRP). Even after installing Magisk v15.0 later, is stays unencrypted . But in MagiskManager there's the checkbox set "keep force encryption" - dont know if that does matter? On my Redmi Note 4 this checkbox is not set.

Same problem here with my Redmi K20 Pro. The problem occurred after I reboot my phone to uninstall FDE.AI magisk module. My phone then encrypts itself. Factory reset, format data, repair partition, re-flashing stock ROM doesn't solve the problem. Have you solved it yet?

Updating from OB9 to OB20 (Pie)

Can someone tell me how I can safely update from open beta 9 to open beta 20 while maintaining root. I just want to make sure if there are any extra steps since open beta 9 was before the treble update. I am rooted with magisk.

also can anyone share updated twrp links or links for anything else I need if possible. Thanks

I heard that, I followed the guide in the development section and got and error when trying to flash it. I'm on TWRP 3.2.3-1 as well.

Yes, everything is fine, I have root. It took me a while, because of TWRP. The only problem is, that while you can get magisk, twrp will get overwritten by stock and I could not prevent it.
Process:
1. Install stock recovery (from here: https://www.androidfilehost.com/?fid=674106145207488252) in fastboot (fastboot flash recovery filename.img)
2. Install the new open beta
3. Download magisk on your phone
4. Install TWRP by codeworkx (from here: https://forum.xda-developers.com/oneplus-5t/development/recovery-twrp-3-2-1-0-oreo-8-0-8-1-t3729673) in fastboot and boot to twrp immediately.
5. Install magisk from within TWRP's first boot
6. After reboot twrp will most likely get overwritten by stock recovery, but we don't care as we have magisk already.
7. Profit.

@jazzgott so is there no way for me to reinstall twrp after updating? How will I update to new versions after?

@jccspeed
1. flash twrp via fastboot (pc, usb cable and phone and everything in need for this needed)
2. after flashing the recovery, turn off your phone, this is important.. do NOT boot your phone into the OS after flashing.. turn it off (chose power off with your volume keys within the fastboot mode and press the standby button once shortly)
3. hold volume down und power button at the same time until you see the "boot loader unlocked" warning stuff.. keep it pressed there for 2 or 3 more seconds. then let loose of these buttons.
4. you should now be in TWRP. congratulations.
if you now flash magisk, you will keep twrp as long as you keep magisk installed. you can freely boot into the OS and still have TWRP installed. How ever, if you don't install magisk and boot into your OS, your OS will overwrite TWRP with stock recovery.
forgot to mention: please use codeworkx pie twrp. its the one I have installed and have gotten into no problems so far.

@jazzgott @moeq123
Does this method erase the user data? I am encrypted and rooted(magisk). I want to preserve all my data.

@ajithpoison
at first I want to mention something important: always do a full backup.
if you unroot your phone (say, if you uninstall magisk using the uninstall.zip from within the magisk app itself and reboot) you should be able to update to open beta 20 via system update settings (where you need to choose a .zip file for the update.. so you need to download the open beta 20 rom from onceplus website).
(please verify that you are on stock recovery after the uninstalling magisk and reboot process. do this by booting into recovery with the power and volume down method. if you don't know how, google how to boot into recovery for your device)
This updating process should not erase your user data at all.
But be aware, that, if you want to go back to stable releases, you have to wipe everything.. so your user data will be erased if you choose to go back to stable releases.
if you want root and twrp back again, follow my instructions mentioned above.

@moeq123
Let me explain my situation in brief.
I am on the open beta channel. I am rooted(magisk) and I have the official TWRP and I am encrypted.
This is how I update everytime:
1. Download the zip
2. Reboot to recovery
3. Wipe cache and dalvik
4. Install update.zip
5. Install Magisk
6. Wipe cache and dalvik again
7. Reboot
This time, the above method will not work due to the compatibility thingy. I want to preserve app data. There are specific apps which I use and I don't want to lose those app's data. Previously I used titanium backup to take backup of app data. I am not sure whether backing up the app data and then restoring it will work since I am upgrading from oreo to pie. Is there any definite way to backup and restore app data after upgrading to pie?
I am summing up the method which I have to follow now. Correct me if I am wrong.
There are two methods which I know as of now.
Method 1:
The official method given by FunkWizard which involves deleting the compatibility.zip for which some users have reported ERROR 7.
Method 2:
1. Download Magisk & OB20 and have it in internal storage and switch off the phone.
2. Install stock recovery via fastboot.
3. Install the new open beta via stock recovery and switch off.
4. Install TWRP by codeworkx and boot to recovery
5. Install magisk from within TWRP's first boot
6. Clear cache and dalvik
7. Reboot to system and Profit.
(Will TWRP remain as a recovery after following all this or will it get overwritten by the stock recovery?)

@moeq123
Nevermind. I have got it to work without losing any data. I followed all the steps which were in the post by @funkwizard who put up the OP5T OB20 Official update post. It worked well except for one thing. The magisk manager did not show up even after installing magisk through the recovery. (I use BluSpark recovery). So I did a manual installation of the magisk manager apk and everything worked fine. I did not lose any data and so far no bugs.

Pixel 3 XL + Magisk 18.0 - Unlocks and boots once or twice, then fails to (re)boot

Hi all,
Long time lurker, first time poster (I think...)
If this is in the wrong location and/or the title is off, I apologise.
I'm having a weird issue with my P3XL. I'm able to properly root it with Magisk (have used 17.3 beta in the past, am now on 18.0), but after "a while", if/when I reboot my phone, it'll simply refuse to boot. Or rather, it will boot, it will show me the Google logo, and then I see my lock screen for about half a second, screen goes black, and then every so often the time (in white) will flash/blink in the top right corner. After a while it will also flash/blink Safe Mode in the bottom left. After a few more blinks, it will reboot and tell me: "Can't load Android system/ Your data may be corrupt."
Now, I have not yet done a full root cause analysis, but it seems to have started after I messed up my first unlock and used the "format data" option in TWRP. I have since flashed (and wiped) the stock factory image, but this issue seems to be reocurring after I root my phone again.
I am currently on the P3XL December update, and am using Magisk 18.0 with TWRP 3.2.3-3-crosshatch, but my first Magisk install after which this happened was on P3XL November, Magisk 17.3 (beta), TWRP 3.2.3-1.
I had hoped it was a Magisk beta issue, but I feel like there's more to this than just Magisk. My gut is telling me it's some kind of encryption thing, that doesn't work well due to the (accidental) full format through TWRP.... But again, gut feel, not based on any true evidence.
The steps to reproduce (for myself) are:
1) flash_all December stock firmware (with -w/wipe option enabled)
* Install my phone, some apps, set up screen lock (pin) and fingerprint
2) download Magisk 18
3) fastboot boot twrp
4) install Magisk 18 through twrp
5) reboot (all looks great, rooted, safetynet, the whole shebang)
6) use my phone for a couple of days
7) decide I need to reboot my phone (for whatever reason, I've run out of battery, I used GPS Joystick and it needed me to reboot to disable location services, I just wanted to reboot)
8) Phone panics and I need to start at 1
When in step 8, I have tried (without success):
* fastboot boot twrp, wipe dalvik/cache
* fastboot boot twrp, install Magisk (with and without dalvik wipe)
* * No issues with Magisk, it happily tells me all is well
* fastboot flash (stock) boot.img
* install twrp (and try to install Magisk)
* use the stock bootloader's factory reset
* use twrp's factory reset
Only the last two will allow me to boot once, but at the end of the setup process stop responding to screen inputs/grind my phone to a halt/flash&blink my screen (although the wifi, phone bars and charging icon remain on/visible)
Has anyone seen this behaviour before, and if so, has found a permanent solution? Because I like having my phone rooted, but I don't like having to wipe and reinstall everything every time my phone restarts
Thanks in advance!

It seems that the phone goes to heck after you reboot? When you flashed the stock boot image did you flash it to both slots? Next time you try to root install the magisk uninstaller zip prior to installing the magisk zip, this of course is all done in twrp. At this point I would start with the factory image, less the -w. Then boot twrp and run the magisk uninstaller then the magisk.
Sent from my [device_name] using XDA-Developers Legacy app

Thanks @jd1639
I have flashed both slots with the factory image. Good call on the Magisk uninstaller. I had assumed that wouldn't be required on a full flash.
*However* I seem to have made some progress with my root cause analysis, and unlike what the title now says, it seems to be the GPS Joystick that I'm using. As soon as I turn on "Disable Location Services" and turn on "A-GPS Reset", it goes to heck. It rebooted perfectly fine the 6 times before I enabled those settings.
I realised in all my repeats, the GPS Joystick's settings were the only other common denominator.
I have just stock flashed my phone (the 3rd time today), both slots, and will try Magisk Uninstall before I install it again... And then I'll repeat my steps up to the GPS Joystick's settings.
I'll try to report back asap.

So far, everything looks alright. I have:
Flashed (and wiped) December stock firmware
Booted TWRP, uninstalled magisk, wiped cache/dalvik, installed Magisk
Installed GPS Joystick (and used private mode)
Installed Systemify Magisk module and installed above as system app
Rebooted multiple times, no issues.
I have yet to enable either A-GPS Reset and/or Disable Location Services, but I have to get to work and don't have time to further tinker right here right now.

Bootloop in all custom ROMs

Hello Freinds...
I'm facing a "some new" problem, and I really need your help
I have a C2005 with TWRP 3.0.2-0 and unofficial LOS 14.1 flashed on it, and everything was working fine.
Then, I decided to update the hosts file and get rid of some Google Apps with clean install -I always do clean installs from time to another-.
So, I edited the gapps-config file and created a flashable zip for the hosts file, rebooted into TWRP, Wiped everything (dalvik, system, cache, data, internal), flashed ROM, dual SIM patch, hosts file, and finally GApps -everything as usual-, then I rebooted into system, but this time, the device went into bootloop.
P.S: The only different thing this time is that I was using xposed module (GravityBox) to set navbar height to "0", and another module (xposed edge) to set some gestures, and I rebooted into recovery and wiped everything -as mentioned above- without deactivating those modules.
I tried to clean install the ROM zip only, in case there was something wrong with the zips I made, and even tried another ROM (PecanCM's AOSP 7), but nothing happened, still bootlooped...
Finally, and as final solution, I tried to begin from zero, so I flashed the stock ROM ftf with Androxyde Flashtool and the device booted successfully into system and worked very fine, then I reflashed TWRP with ADB ......., sideloaded LineageOS.zip (Followed the LineageOS installation steps explained in LineageOS Nicki Wiki step by step)........, but also Still bootlooped!!!!
P.S: Into the Install Zip page in TWRP, I noticed this message (this operation may install incompatible software and render your device unusual) for the first time, I do not know if it is normal or not.
Please, Any body know if there is any logical reason for this?, please help me :crying::crying:
Thanks in advance