Develop Bugs

Prep for December patch

I have made a lot of changes to the November build such as TWRP, root with magisk, custom kernel and Tulsa mods to the systemUI and framework.
I am thinking that I will need to reset to factory default in order to get the December update. I have not done a factory reset yet.
Sounds like I use Flashall.bat with the - w option removed and the phone in Fastboot mode.
Do Magisk or TWRP need to be removed before Flashall?
Will there be a full December build or do I flash an old build and then take the updates?
Any other suggestions on the best way to update to the Dec build?

swieder711 said:
I have made a lot of changes to the November build such as TWRP, root with magisk, custom kernel and Tulsa mods to the systemUI and framework.
I am thinking that I will need to reset to factory default in order to get the December update. I have not done a factory reset yet.
Sounds like a use Flashall.bat with the - w option removed.
Will there be a full December build or do I flash an old build and then take the updates?
Any other suggestions on the best way to update to the Dec build?
Click to expand...
Click to collapse
There Dec flash-all batch file, without the -w, will over write all your modifications and that's all you should need to do. It's always best to backup everything you can just in case.
Sent from my [device_name] using XDA-Developers Legacy app

So can you not download the ota from Google's website and flash it in TWRP? Then just flash TWRP and root again before rebooting?

hatdrc said:
So can you not download the ota from Google's website and flash it in TWRP? Then just flash TWRP and root again before rebooting?
Click to expand...
Click to collapse
Not in TWRP, but you can ADB sideload it then reroot. The flash all after removing the-w also saves data and apps.

hatdrc said:
So can you not download the ota from Google's website and flash it in TWRP? Then just flash TWRP and root again before rebooting?
Click to expand...
Click to collapse
If you don't install the permanent TWRP, and just use the bootable image, you can place the OTA on your phone and use the stock recovery to install it. The OTA will install without wiping data.

spotmark said:
If you don't install the permanent TWRP, and just use the bootable image, you can place the OTA on your phone and use the stock recovery to install it. The OTA will install without wiping data.
Click to expand...
Click to collapse
Right, but then you need to reroot with a PC. I have TWRP permanent so I was hoping you could just boot into TWRP and flash it, then flash TWRP again and then root and be back to the way it is now.
So in my case I need to just download the images, remove -w and then flash. Temp boot TWRP and flash root. Don't think I'll put TWRP on permanently this time since that was the only reason I did the last time.
Thank you everyone for your help

December update breaks magisk?

Hi all,
I've updated my 3xl to the december update like usual, flash-all.bat without -w. Afterwards, it boots fine, and in settings it clearly states that I'm running the December security patch.
However, when I boot into twrp (not installed) and flash magisk, android boots to just before asking my SIM PIN, says "Shutting Down", then reboots and gives me the message "Can't load Android System. Your data may be corrupt." etc. inside stock recovery.
Did the December update somehow break magisk? Anyone gotten it to work? I'd rather not do a factory reset if it's not needed.

Works fine for me.

Try re-flashing the December update with the - w deleted see if it boots up. Then try flashing magdisk manually on bkth a and b partitions

Working fine for me as well.

I would try flashing the stock boot and system images to both slots. It probably won't work but worth a try before doing a factory reset.
Sent from my [device_name] using XDA-Developers Legacy app

You have a corrupt backup copy of boot.img, Magisk grabbed that and used it for root.
Flash the stock boot.img to both slots and reroot.

mikepopo99 said:
Try re-flashing the December update with the - w deleted see if it boots up. Then try flashing magdisk manually on bkth a and b partitions
Click to expand...
Click to collapse
jd1639 said:
I would try flashing the stock boot and system images to both slots. It probably won't work but worth a try before doing a factory reset.
Sent from my [device_name] using XDA-Developers Legacy app
Click to expand...
Click to collapse
TonikJDK said:
You have a corrupt backup copy of boot.img, Magisk grabbed that and used it for root.
Flash the stock boot.img to both slots and reroot.
Click to expand...
Click to collapse
First off, thanks for trying to help!
Flashing the stock boot.img "solves" the problem, I can boot and use the phone like normal, but without root obviously. Using the stock boot.img inside magisk manager to patch it with 17.3 and flashing that boot image to both partitions gives me this error again. I've also tried re-applying the December update at least 3 more times, with the same result. Any other ideas?

RogerXIII said:
First off, thanks for trying to help!
Flashing the stock boot.img "solves" the problem, I can boot and use the phone like normal, but without root obviously. Using the stock boot.img inside magisk manager to patch it with 17.3 and flashing that boot image to both partitions gives me this error again. I've also tried re-applying the December update at least 3 more times, with the same result. Any other ideas?
Click to expand...
Click to collapse
Flash the stock boot.img to both slots.
Reboot and check it.
Copy the Magisk zip to your phone.
Fastboot boot the TWRP img file, don't install it.
Use TWRP to install the Magisk zip, and you are done.

RogerXIII said:
First off, thanks for trying to help!
Flashing the stock boot.img "solves" the problem, I can boot and use the phone like normal, but without root obviously. Using the stock boot.img inside magisk manager to patch it with 17.3 and flashing that boot image to both partitions gives me this error again. I've also tried re-applying the December update at least 3 more times, with the same result. Any other ideas?
Click to expand...
Click to collapse
Do you have the previous version of Edge Sense Plus module installed? That sounds exactly like what happens if you install Magisk with that module still there. He put out a new one today.

sliding_billy said:
Do you have the previous version of Edge Sense Plus module installed? That sounds exactly like what happens if you install Magisk with that module still there. He put out a new one today.
Click to expand...
Click to collapse
Thank you so much, this worked!
Instead of going back an Android version, I used this script, uninstalled all modules and re-flashed Magisk. It works perfectly now. Thanks again!

RogerXIII said:
Thank you so much, this worked!
Instead of going back an Android version, I used this script, uninstalled all modules and re-flashed Magisk. It works perfectly now. Thanks again!
Click to expand...
Click to collapse
Good deal. That is why I always keep a copy of the Magisk uninstaller on the phone itself. As long as I can get to BL/temp TWRP .img, the worst I am out is the time it takes me to reconfigure Magisk.

RogerXIII said:
However, when I boot into twrp (not installed)
Click to expand...
Click to collapse
What do you use to get TWRP going when it's not permenantly installed? Just curious?
Fire Hound 8.1

Shaftamle said:
What do you use to get TWRP going when it's not permenantly installed? Just curious?
Fire Hound 8.1
Click to expand...
Click to collapse
The TWRP image from the official website, and then simply fastboot boot twrp.img

RogerXIII said:
The TWRP image from the official website, and then simply fastboot boot twrp.img
Click to expand...
Click to collapse
Ok cool. Wasn't sure if there was an app like fashify or something.
Fire Hound 8.1

sliding_billy said:
Do you have the previous version of Edge Sense Plus module installed? That sounds exactly like what happens if you install Magisk with that module still there. He put out a new one today.
Click to expand...
Click to collapse
you are godsend my friend.

Touz604 said:
you are godsend my friend.
Click to expand...
Click to collapse
Glad you got it figured out.

RogerXIII said:
The TWRP image from the official website, and then simply fastboot boot twrp.img
Click to expand...
Click to collapse
How can we boot the twrp from fastboot?
The one from official website doesn't support Android 10 I believe and I failed with the info says "too many links".

bbs3223474 said:
How can we boot the twrp from fastboot?
The one from official website doesn't support Android 10 I believe and I failed with the info says "too many links".
Click to expand...
Click to collapse
You ca't yet.

bbs3223474 said:
How can we boot the twrp from fastboot?
The one from official website doesn't support Android 10 I believe and I failed with the info says "too many links".
Click to expand...
Click to collapse
Thread is from 2018

I am gonna check the official TWRP website for the workable TWRP for my Pixel 3 till I see your post
wangdaning said:
Thread is from 2018
Click to expand...
Click to collapse

Root and Magisk on Oreo (oct security patch)

After using this phone for a while I decided to root it.
I unlocked bootloader, installed TWRP and flashed Magisk, but all I get is bootloop or stuck on bootlogo (your device has been unlocked.....)
SOLUTION
https://forum.xda-developers.com/moto-z-play/how-to/guide-how-to-magisk-root-xposed-oreo-8-t3743273
Applicable also for moto Z2 Play, just with appropriate recovery, of course
Please note the updates to the first post. It may be necessary to do the procedure twice.
I tried these TWRPs:
3.2.3.0
64bit 3.2.1
and TWRP and modified magisk from https://forum.xda-developers.com/z2-play/how-to/guide-twrp-root-t3667769
I tried all TWRPs with both modified magisk and official v18.
I have XT1710-09 with Oreo and October security patch
Is there a way to root this lastest firmware?
Thanks

Klen2 said:
I tried these TWRPs:
3.2.3.0
64bit 3.2.1
and TWRP and modified magisk from https://forum.xda-developers.com/z2-play/how-to/guide-twrp-root-t3667769
I tried all TWRPs with both modified magisk and official v18.
I have XT1710-09 with Oreo and October security patch
Is there a way to root this lastest firmware?
Thanks
Click to expand...
Click to collapse
I did 3.2.3-0 TWRP method (by Junior Passos) on my XT1710-06 device with 8.0 on August 1 security patch (purposefully neglected updating any further cause method was tested exactly up to August patch according to Passos) and everything seems working pretty fine for a month now. Think I've installed no Magisk modules other than Xposed systemless yet and I've no interest in SafetyNet as well, so not deeply tested either. Don't know for sure, but I guess there's a good chance for such method to work on October patch too. Just be sure to perform every step as it is now in the 3.2.3-0 OP. One word of advice: after performing TWRP backup, look for it in /system/media and move it to both external and internal SDcards just in case something goes wrong (usually because of a missed step, I can say)... Also: I recommend to install Magisk v17.1 first time; then, if you want, update to v18 but right from the installer...
Sent from my Moto Z2 Play using XDA Labs

Strange, I have zero magisk problems when using the latest stock rom. Flash in twrp, done, no issues. However, it could be because I first back up boot and system and then restore them with twrp before rooting(this removes encryption).

Have these steps worked for me...
1.)Flash TWRP using Fastboot
2.)Go to TWRP/Settings and open Terminal.
3.)Run both of following commands:
echo KEEPVERITY=true>>/data/.magisk
echo KEEPFORCEENCRYPT=true>>/data/.magisk
Click to expand...
Click to collapse
4.)Flash Magisk-v17.1.zip
5.)Repeat step 2 and 3 dont wipe.
6.)Start
NOTE: before Reinstall stock or uninstall Magisk.

I did the Junior Passos method of doing the backup, and everything is working like a charm.

Cupcake 1.5 said:
Strange, I have zero magisk problems when using the latest stock rom. Flash in twrp, done, no issues. However, it could be because I first back up boot and system and then restore them with twrp before rooting(this removes encryption).
Click to expand...
Click to collapse
Hi, Could you please, tell me which stock ROM you are using and where is possible to get it?
First time I am having problem with Magisk, never had on other phones.
Problem = Bootlop

OldUncle said:
Hi, Could you please, tell me which stock ROM you are using and where is possible to get it?
First time I am having problem with Magisk, never had on other phones.
Problem = Bootlop
Click to expand...
Click to collapse
It's not what rom but, how you do it. When on stock ROM, it is encrypted so you must first back up system and boot and then immediately restore them, this remove encryption. Now flash magisk and it will work.

Cupcake 1.5 said:
It's not what rom but, how you do it. When on stock ROM, it is encrypted so you must first back up system and boot and then immediately restore them, this remove encryption. Now flash magisk and it will work.
Click to expand...
Click to collapse
Perfect!
Thank you very much!
The only solution which worked!
Finally I got full control on my Z2 Play.

Cupcake 1.5 said:
It's not what rom but, how you do it. When on stock ROM, it is encrypted so you must first back up system and boot and then immediately restore them, this remove encryption. Now flash magisk and it will work.
Click to expand...
Click to collapse
Regarding backup, this is done through the stock ROM correct (Settings --> System --> Backup to Google Drive).
Thanks,
smithmal

Cupcake 1.5 said:
It's not what rom but, how you do it. When on stock ROM, it is encrypted so you must first back up system and boot and then immediately restore them, this remove encryption. Now flash magisk and it will work.
Click to expand...
Click to collapse
This worked perfectly on my Moto Z2 XT1710-06 with Oreo 8.0 when no other options worked.
Flash or Boot into TWRP
Backup System and Boot partitions in TWRP
Restore System and Boot Partitions in TWRP (note I had to enable R/W access in TWRP to restore the system partition)
Flash Magisk-v19.3.zip
Reboot
That is it. Now Rooted and passes all SafteyNet test. No more restricted apps. Even Google Pay now works.
Thank You.

sick
Cupcake 1.5 said:
It's not what rom but, how you do it. When on stock ROM, it is encrypted so you must first back up system and boot and then immediately restore them, this remove encryption. Now flash magisk and it will work.
Click to expand...
Click to collapse
your method worked like charm, thanks alot man

Help Updating to December Security Patch

I'm running the stock rom on the November patch. I have TWRP installed with Magisk and the Kirisakura kernel. I've read and Googled for a solution and still can't get it to work. I have the latest ADB told installed but I am unable to push the update through. Can someone tell me what I'm missing? This used to be so much simpler lol. Thanks in advance.

DarkPhoenix said:
I'm running the stock rom on the November patch. I have TWRP installed with Magisk and the Kirisakura kernel. I've read and Googled for a solution and still can't get it to work. I have the latest ADB told installed but I am unable to push the update through. Can someone tell me what I'm missing? This used to be so much simpler lol. Thanks in advance.
Click to expand...
Click to collapse
From what I understand you can not do ADB in TWRP to install an update. What I did was download the factory images, remove -w from the flash all.bat. flashed the images and let the phone boot normally. Once I knew it was running I went to the bootloader and booted TWRP temporarily. Once that was up I flashed Magisk and then my kernel
I don't install TWRP anymore.

DarkPhoenix said:
I'm running the stock rom on the November patch. I have TWRP installed with Magisk and the Kirisakura kernel. I've read and Googled for a solution and still can't get it to work. I have the latest ADB told installed but I am unable to push the update through. Can someone tell me what I'm missing? This used to be so much simpler lol. Thanks in advance.
Click to expand...
Click to collapse
Adding to what hatdrc said, you want the full image, not OTA, and install from your PC in fastboot mode. If you are concerned about saving your data, remove the -w switch from flash-all.bat first using a file editor like notepad. Have the twrp.zip, kernel.zip and magisk.zip files already staged. I personally don't boot to system first (but you can), I "catch" the reboot after flashing completes with the volume down button to reboot to fastboot mode. Then fastboot boot twrp.img, and then install twrp, kernel and magisk zips all in one go using the "add more zips" button in twrp. Every month when you update, you'll lose twrp, kernel and magisk, so those have to be reflashed each time. You'll soon get used to it and can do the whole thing in about 5 minutes consistently. Just make sure to pre-stage the 3 zip files on the phone before you start. Best of luck.

I tried that but couldn't get it to work. I downloaded the ADB tools again just in case there was an issue with that. I'm going to run the flash-all script again to see if I can get it to work.

DarkPhoenix said:
I tried that but couldn't get it to work. I downloaded the ADB tools again just in case there was an issue with that. I'm going to run the flash-all script again to see if I can get it to work.
Click to expand...
Click to collapse
if whats suggested above doesnt work, you can make the OTA work....download the ota to your PC, boot to Android Recovery (not TWRP), apply the ota via ADB from the menu. Whenever I have "odd" issues applying the Full image, this always works for me. Obviously you need to re-root after.
GL!

cmh714 said:
if whats suggested above doesnt work, you can make the OTA work....download the ota to your PC, boot to Android Recovery (not TWRP), apply the ota via ADB from the menu. Whenever I have "odd" issues applying the Full image, this always works for me. Obviously you need to re-root after.
GL!
Click to expand...
Click to collapse
Doesn't installing TWRP remove Android Recovery?

DarkPhoenix said:
Doesn't installing TWRP remove Android Recovery?
Click to expand...
Click to collapse
hmm, since I dont install TWRP anymore, you may be correct....still cant hurt to try

DarkPhoenix said:
Doesn't installing TWRP remove Android Recovery?
Click to expand...
Click to collapse
Yes it does. TWRP replaces the stock recovery.
Sent from my [device_name] using XDA-Developers Legacy app

v12xke said:
Adding to what hatdrc said, you want the full image, not OTA, and install from your PC in fastboot mode. If you are concerned about saving your data, remove the -w switch from flash-all.bat first using a file editor like notepad. Have the twrp.zip, kernel.zip and magisk.zip files already staged. I personally don't boot to system first (but you can), I "catch" the reboot after flashing completes with the volume down button to reboot to fastboot mode. Then fastboot boot twrp.img, and then install twrp, kernel and magisk zips all in one go using the "add more zips" button in twrp. Every month when you update, you'll lose twrp, kernel and magisk, so those have to be reflashed each time. You'll soon get used to it and can do the whole thing in about 5 minutes consistently. Just make sure to pre-stage the 3 zip files on the phone before you start. Best of luck.
Click to expand...
Click to collapse
Ok, I got the flash-all script to run. My brain shut down and I was running the wrong command.

DarkPhoenix said:
Ok, I got the flash-all script to run. My brain shut down and I was running the wrong command.
Click to expand...
Click to collapse
Well done. Now you can do it all over again in a week on Monday the 7th when the January build comes out.

v12xke said:
Well done. Now you can do it all over again in a week on Monday the 7th when the January build comes out.
Click to expand...
Click to collapse
I was updating so I could install Bootleggers rom so updating should be a lot easier lol.

[Rooted] Pixel 2XL and System Autoupdates?

I really don't have a clue how to get auto updates via System Updates on my rooted Pixel 2 XL (Pie, Magisk 18.1).
If I check updates it replies that I already have the latest version (still from February 2019).
Is it possible to get updates via system menu on a rooted phone?
P. S. Sorry if I've missed a right thread for this topic)

b3rsus said:
I really don't have a clue how to get auto updates via System Updates on my rooted Pixel 2 XL (Pie, Magisk 18.1).
If I check updates it replies that I already have the latest version (still from February 2019).
Is it possible to get updates via system menu on a rooted phone?
P. S. Sorry if I've missed a right thread for this topic)
Click to expand...
Click to collapse
No, you will have to manually update on a rooted phone. It requires a computer but only takes a couple minutes.

murphyjasonc said:
No, you will have to manually update on a rooted phone. It requires a computer but only takes a couple minutes.
Click to expand...
Click to collapse
Is it possible to update the system without full wiping? As I remember I should put -w in the flash script, but will it update correctly and should I reinstall TWRP or Magisk in this case?

b3rsus said:
Is it possible to update the system without full wiping? As I remember I should put -w in the flash script, but will it update correctly and should I reinstall TWRP or Magisk in this case?
Click to expand...
Click to collapse
It will not wipe your phone as long as you remove the -w. Magisk and Twrp will have to be reinstalled but that's an easy process. Fastboot boot the twrp.img file. That will get you back in to twrp temporary so you can flash the twrp and magisk zip files.

murphyjasonc said:
It will not wipe your phone as long as you remove the -w. Magisk and Twrp will have to be reinstalled but that's an easy process. Fastboot boot the twrp.img file. That will get you back in to twrp temporary so you can flash the twrp and magisk zip files.
Click to expand...
Click to collapse
Is it any difference with the sideload method?

b3rsus said:
Is it any difference with the sideload method?
Click to expand...
Click to collapse
Mostly personal preference.. if you use the side load method you need to download the ota file instead of the full image. I personally prefer flashing the whole image in fastboot. In my experience there is less room for user error but that's my opinion.

murphyjasonc said:
Mostly personal preference.. if you use the side load method you need to download the ota file instead of the full image. I personally prefer flashing the whole image in fastboot. In my experience there is less room for user error but that's my opinion.
Click to expand...
Click to collapse
Thank you very much!)

Probably will be useful for somebody.
How to update system on a rooted Pixel 2 XL with TWRP.
Code:
[LIST=1]
[*]Download OTA file, TWRP.zip and Magisk.zip to the phone
[*]Reboot to TWRP, install OTA archive
[*]Reboot to Bootloader
[*]fastboot boot twrp.img
[*]Install TWRP.zip and Magisk.zip
[*]Power off system from TWRP
[*]Run!
[/LIST]

b3rsus said:
Is it possible to update the system without full wiping? As I remember I should put -w in the flash script, but will it update correctly and should I reinstall TWRP or Magisk in this case?
Click to expand...
Click to collapse
remove the -w from the bat file

wrecklesswun said:
remove the -w from the bat file
Click to expand...
Click to collapse
This!!