Develop Bugs

root with Magisk on Oreo.

I was trying to get help on Reddit but I wasn't able to get any help.
I was able to find the Twrp image to Boot into but Magisk isn't installing when I go to try to install it.
I'm using 13.4 for my pixel XL and I tried 13.3
Any ideas why they aren't working? No errors in Twrp when installing.

DudeThatsErin said:
I was trying to get help on Reddit but I wasn't able to get any help.
I was able to find the Twrp image to Boot into but Magisk isn't installing when I go to try to install it.
I'm using 13.4 for my pixel XL and I tried 13.3
Any ideas why they aren't working? No errors in Twrp when installing.
Click to expand...
Click to collapse
Hello,
Not sure if Magisk is even working on O but you would want to flash a kernel like ElementalX first or the modified stock. Flash the kernel, then Magisk but again I am not sure if it is actually working yet. If you do get it installed and working be sure to report back to all. Also if you had SU + SUhide prior then you will want to flash the Magisk remover first, then kernel then Magisk.
Cheers

jschill31 said:
Hello,
Not sure if Magisk is even working on O but you would want to flash a kernel like ElementalX first or the modified stock. Flash the kernel, then Magisk but again I am not sure if it is actually working yet. If you do get it installed and working be sure to report back to all. Also if you had SU + SUhide prior then you will want to flash the Magisk remover first, then kernel then Magisk.
Cheers
Click to expand...
Click to collapse
Yup. Just verified it doesn't work. I booted into twrp, installed ElementalX, then Magisk 13.4 and rebooted, still doesn't work.
Then I booted into twrp, installed ElementalX and Magisk 13.3 and rebooted. Nothing.
I also installed TWRP RC2 and it works fine. If you want I can upload the bootable image for twrp and RC2 that I used. At least now I have a way of testing it out (well, to keep testing it out, when I'm at work).

DudeThatsErin said:
Yup. Just verified it doesn't work. I booted into twrp, installed ElementalX, then Magisk 13.4 and rebooted, still doesn't work.
Then I booted into twrp, installed ElementalX and Magisk 13.3 and rebooted. Nothing.
I also installed TWRP RC2 and it works fine. If you want I can upload the bootable image for twrp and RC2 that I used. At least now I have a way of testing it out (well, to keep testing it out, when I'm at work).
Click to expand...
Click to collapse
So you have twrp installed with no issues?

humdrum2009 said:
So you have twrp installed with no issues?
Click to expand...
Click to collapse
Correct

I'm using a 6p with a pixel on the way. I had it working on the 6p with Oreo. I'm pretty sure I had to download an apk as well as flash the zip. Have you done this?

the pixel has a special magisk version because of boot a/b system stuff from my understanding. So it doesn't matter if it works on any other google phone.
It sucks too because i heavily rely on magisk due to how good it is on hiding...goodwin_c is my only hope. hanging on a thread here...
If you mention other root hiding methods just know that no...they all suck lol

j_mullet said:
I'm using a 6p with a pixel on the way. I had it working on the 6p with Oreo. I'm pretty sure I had to download an apk as well as flash the zip. Have you done this?
Click to expand...
Click to collapse
Zizzy2020 said:
the pixel has a special magisk version because of boot a/b system stuff from my understanding. So it doesn't matter if it works on any other google phone.
It sucks too because i heavily rely on magisk due to how good it is on hiding...goodwin_c is my only hope. hanging on a thread here...
If you mention other root hiding methods just know that no...they all suck lol
Click to expand...
Click to collapse
What Zizzy2020 said. It is annoying. I can't wait for the next magisk to be released.

Check out this post, it works like a charm.

Phone will only boot to recovery after flashing TWRP?

Hey all, so this is a strange issue. I've tried this 3 times, on 8.0, 8.1 Jan security patch, and 8.1 March security patch. Booting to TWRP via fastboot works just fine, but after flashing it via ZIP within TWRP and rebooting, the phone will only boot to TWRP. Even flashing a stock boot.img and/or dirty flashing the stock image did not fix the issue and every time I had to do a clean install of the stock image. Any ideas why this is going on?

Have you tried installing Magisk after it boots back into TWRP?

sliding_billy said:
Have you tried installing Magisk after it boots back into TWRP?
Click to expand...
Click to collapse
Absolutely. It will patch the Boot Img.

Mikkey81 said:
Absolutely. It will patch the Boot Img.
Click to expand...
Click to collapse
hooligan33_3 said:
Hey all, so this is a strange issue. I've tried this 3 times, on 8.0, 8.1 Jan security patch, and 8.1 March security patch. Booting to TWRP via fastboot works just fine, but after flashing it via ZIP within TWRP and rebooting, the phone will only boot to TWRP. Even flashing a stock boot.img and/or dirty flashing the stock image did not fix the issue and every time I had to do a clean install of the stock image. Any ideas why this is going on?
Click to expand...
Click to collapse
Sorry, I meant to quote you when I suggested installing Magisk since it will patch boot.img.

Hello, this happened to me too after I uninstalled Magisk. I just reinstalled it and wiped the phone (just to be sure) and it works now.

stepedes said:
Hello, this happened to me too after I uninstalled Magisk. I just reinstalled it and wiped the phone (just to be sure) and it works now.
Click to expand...
Click to collapse
Are you trying to flash Magisk in fastboot or through TWRP?

In TWRP.
I'm a noob in all this, glad I didn't brick it. ?

it just happened to me now, I read one of the posts saying flash Magisk again and it worked.
aside: can someone tell me briefly who phones now having slot A and B? everytime i reboot twrp, i see option to decide which slot. I did choose slot B once and the phone never booted up. i'm little bit confused. and everytime twrp boots in, it asks me to draw my security pattern for decryption, is that OK? thx

mohawahba said:
it just happened to me now, I read one of the posts saying flash Magisk again and it worked.
aside: can someone tell me briefly who phones now having slot A and B? everytime i reboot twrp, i see option to decide which slot. I did choose slot B once and the phone never booted up. i'm little bit confused. and everytime twrp boots in, it asks me to draw my security pattern for decryption, is that OK? thx
Click to expand...
Click to collapse
Are you using twrp-pixel-installer-marlin-3.2.3-1.zip and twrp-3.2.3-1-marlin.img on your Pixel XL?
twrp should not be giving you an option to choose
a slot nor draw a security pattern for decryption.
look at this guide: [Guide] Pixel XL Android 9.0 (Pie) Unlock/Root/Install Images/Kernels/Recovery + by Homeboy76

Homeboy76 said:
Are you using twrp-pixel-installer-marlin-3.2.3-1.zip and twrp-3.2.3-1-marlin.img on your Pixel XL?
twrp should not be giving you an option to choose
a slot nor draw a security pattern for decryption.
look at this guide: [Guide] Pixel XL Android 9.0 (Pie) Unlock/Root/Install Images/Kernels/Recovery + by Homeboy76
Click to expand...
Click to collapse
I am actually sailfish .. will look into the link. Thanks

mohawahba said:
I am actually sailfish .. will look into the link. Thanks
Click to expand...
Click to collapse
Try the Pixel forum
TWRP for sailfish
- twrp-pixel-installer-sailfish-3.2.3-1.zip
- twrp-3.2.3-1-sailfish.img

Magisk bootloop twrp

Everytime i try to install magisk I get a bootloop. Bootloop goes away again as soon as I use magisk uninstaller so it's definetly magisk.
Any idea how I can get round this, it's kinda annoying.

yusuo said:
Everytime i try to install magisk I get a bootloop. Bootloop goes away again as soon as I use magisk uninstaller so it's definetly magisk.
Any idea how I can get round this, it's kinda annoying.
Click to expand...
Click to collapse
I get this too and have not been able to figure it out. What year and month was your Pixel XL manufactured in? Are you using the March update?
Homeboy76 has been helping me troubleshoot my problem so maybe one of these set of steps could help you flash yours. I'm still trying to get mine to root.
https://forum.xda-developers.com/pixel-xl/how-to/guide-pixel-xl-android-9-0-pie-unlock-t3825866/post79177838#post79177838

i had the same problem as u. the fix for me was to update to the march pixel xl factory image and flash it with no wipe. delete -w so i keep all my existing data/apps etc and flash latest twrp and latest magisk v18.1 and no twrp bootloop. hope this helps

Issues Rooting Pixel XL with TWRP/Magisk

I'm following some guides to root my pixel xl but am running to some issues.
I tried using twrp-3.3.1-0-marlin.img to load Magisk-v19.3.zip but it gives me errors mounting system and vendor.
I then tried using twrp-3.3.0-0-marlin.img to load Magisk-v19.3.zip and it appears to succeed. I reboot, but Magisk Manager never appears. When I load it manually, it tells me that Magisk 19.3 isn't installed.
I'm not sure what I'm doing wrong. Is there some hidden step?
Thank you.

ookami007 said:
I'm following some guides to root my pixel xl but am running to some issues.
I tried using twrp-3.3.1-0-marlin.img to load Magisk-v19.3.zip but it gives me errors mounting system and vendor.
I then tried using twrp-3.3.0-0-marlin.img to load Magisk-v19.3.zip and it appears to succeed. I reboot, but Magisk Manager never appears. When I load it manually, it tells me that Magisk 19.3 isn't installed.
I'm not sure what I'm doing wrong. Is there some hidden step?
Thank you.
Click to expand...
Click to collapse
Mounting errors are normal. Use 3.3.1-0
Boot TWRP image
Flash TWRP zip
Flash magisk (latest canary channel)
Reboot
Install magisk manager if necessary (latest canary)
Open magisk manager and follow any instructions.

Tulsadiver said:
Mounting errors are normal. Use 3.3.1-0
Boot TWRP image
Flash TWRP zip
Flash magisk (latest canary channel)
Reboot
Install magisk manager if necessary (latest canary)
Open magisk manager and follow any instructions.
Click to expand...
Click to collapse
Need to try this soon, glad to see it's working ?
Sent from my Pixel XL using XDA Labs

Tulsadiver said:
Mounting errors are normal. Use 3.3.1-0
Boot TWRP image
Flash TWRP zip
Flash magisk (latest canary channel)
Reboot
Install magisk manager if necessary (latest canary)
Open magisk manager and follow any instructions.
Click to expand...
Click to collapse
I've followed this along with every other guide I could find at least 10x each or more, and still haven't achieved root. Everything seems to install fine, but everytime I open Magisk Manager, it shows "Magisk is not installed". And that seems to be the only thing keeping me from getting root. There has to be a missing step or something... It's been about 5 years since I've rooted a device(HTC M8), but I don't remember ever having so much difficulty. I've wiped the phone more times than I can count, uninstalled/reinstalled Magisk(regular and Canary), tried to do this on both Android 8 and 9, tried to complete this process on both LinuxMint and Windows, etc. I'm completely out of ideas at this point.

tyler.durden said:
I've followed this along with every other guide I could find at least 10x each or more, and still haven't achieved root. Everything seems to install fine, but everytime I open Magisk Manager, it shows "Magisk is not installed". And that seems to be the only thing keeping me from getting root. There has to be a missing step or something... It's been about 5 years since I've rooted a device(HTC M8), but I don't remember ever having so much difficulty. I've wiped the phone more times than I can count, uninstalled/reinstalled Magisk(regular and Canary), tried to do this on both Android 8 and 9, tried to complete this process on both LinuxMint and Windows, etc. I'm completely out of ideas at this point.
Click to expand...
Click to collapse
Have you tried fastboot flash boot magisk_patched.img after making one in magisk manager? Are you on Android 10?
This was made from a pixel XL boot.img, Android 10
https://mega.nz/#!lQg0RaiJ!_YRjiL3nHysUeLavKt0umJjrHbSPzJsqkPVi2qIQfZE
Make sure your ADB/fastboot platform tools are up to date.

Tulsadiver said:
Have you tried fastboot flash boot magisk_patched.img after making one in magisk manager? Are you on Android 10?
This was made from a pixel XL boot.img, Android 10
https://mega.nz/#!lQg0RaiJ!_YRjiL3nHysUeLavKt0umJjrHbSPzJsqkPVi2qIQfZE
Make sure your ADB/fastboot platform tools are up to date.
Click to expand...
Click to collapse
That's definitely one that I haven't tried yet. I'm still on Android 9 for now. I downloaded the latest Platform tools just a few days ago, so that part should be up to date. It doesn't seem like there's much for Android 10 yet, so I'm waiting a bit before I switch.

tyler.durden said:
That's definitely one that I haven't tried yet. I'm still on Android 9 for now. I downloaded the latest Platform tools just a few days ago, so that part should be up to date. It doesn't seem like there's much for Android 10 yet, so I'm waiting a bit before I switch.
Click to expand...
Click to collapse
Here is the boot and patched boot from 9 August update. I typically have firmware for recent Pixel phones.
https://mega.nz/#!gRBGhYAZ!Z7mEBEHVT9V4ut0p__g5BVboS8RjLSSPWXgjurSQxbU

Tulsadiver said:
Here is the boot and patched boot from 9 August update. I typically have firmware for recent Pixel phones.
https://mega.nz/#!gRBGhYAZ!Z7mEBEHVT9V4ut0p__g5BVboS8RjLSSPWXgjurSQxbU
Click to expand...
Click to collapse
Thank you! Magisk finally installed using the boot.img patching method, and now I have root access.

Tulsadiver said:
Have you tried fastboot flash boot magisk_patched.img after making one in magisk manager? Are you on Android 10?
This was made from a pixel XL boot.img, Android 10
https://mega.nz/#!lQg0RaiJ!_YRjiL3nHysUeLavKt0umJjrHbSPzJsqkPVi2qIQfZE
Make sure your ADB/fastboot platform tools are up to date.
Click to expand...
Click to collapse
I am having the same issue, but with the Oct patch. How do I make one of these with Magisk Manager? I tried making it with the bootloader img from the stock factory image, but it fails at repackaging step. Anyone else having issue with Oct patch?

smithilberry said:
I am having the same issue, but with the Oct patch. How do I make one of these with Magisk Manager? I tried making it with the bootloader img from the stock factory image, but it fails at repackaging step. Anyone else having issue with Oct patch?
Click to expand...
Click to collapse
You meant boot.img, right?
Edit. You need to unzip the image zip in order to get the boot.img.

Tulsadiver said:
You meant boot.img, right?
Edit. You need to unzip the image zip in order to get the boot.img.
Click to expand...
Click to collapse
Yes, that's what I meant. I also got it working. I used TWRP 3.3.0 and it worked. Not sure what the reason would be.

Tulsadiver said:
Mounting errors are normal. Use 3.3.1-0
Boot TWRP image
Flash TWRP zip
Flash magisk (latest canary channel)
Reboot
Install magisk manager if necessary (latest canary)
Open magisk manager and follow any instructions.
Click to expand...
Click to collapse
Sent from my marlin using XDA Labs
---------- Post added at 10:51 AM ---------- Previous post was at 10:45 AM ----------
Tulsadiver said:
Have you tried fastboot flash boot magisk_patched.img after making one in magisk manager? Are you on Android 10?
This was made from a pixel XL boot.img, Android 10
https://mega.nz/#!lQg0RaiJ!_YRjiL3nHysUeLavKt0umJjrHbSPzJsqkPVi2qIQfZE
Make sure your ADB/fastboot platform tools are up to date.
Click to expand...
Click to collapse
This was my dilemma. I have no PC so I am using Osmosis's static fastboot magisk mod and it works excellent but because the sdk must be an updated version it does not know the command when you flash the patched boot.img the " --slots all " it says unrecognizabled command in termux and terminal emulator but everything else will flash it's just that new --slots all that gets it. Is there any way for me to get the boot.img on both slots without using that command? Can I just fastboot the boot then reboot bootloader and repeat? Would that get it on both slots?
Is it possible to install the boot.img in one slot or will that mess things up? Guide has patched boot on both...Or just boot twrp 3300 and flash a rom? I'm weary about getting too brave because I bricked a device recently that was A/B. I been around for many years and never bricked anything till recently. ?
Sent from my marlin using XDA Labs

flash713 said:
Sent from my marlin using XDA Labs
---------- Post added at 10:51 AM ---------- Previous post was at 10:45 AM ----------
This was my dilemma. I have no PC so I am using Osmosis's static fastboot magisk mod and it works excellent but because the sdk must be an updated version it does not know the command when you flash the patched boot.img the " --slots all " it says unrecognizabled command in termux and terminal emulator but everything else will flash it's just that new --slots all that gets it. Is there any way for me to get the boot.img on both slots without using that command? Can I just fastboot the boot then reboot bootloader and repeat? Would that get it on both slots?
Is it possible to install the boot.img in one slot or will that mess things up? Guide has patched boot on both...Or just boot twrp 3300 and flash a rom? I'm weary about getting too brave because I bricked a device recently that was A/B. I been around for many years and never bricked anything till recently.
Sent from my marlin using XDA Labs
Click to expand...
Click to collapse
I personally have never flashed it to both slots. Just the current slot
fastboot flash boot magisk_patched.img

Tulsadiver said:
I personally have never flashed it to both slots. Just the current slot
fastboot flash boot magisk_patched.img
Click to expand...
Click to collapse
You rock! Appreciate you telling me this! I believe I understand more now that I've read about the A/B partition for a few weeks.. Pixel XL forums actually has the most detailed information of A/B that I've seen yet. Cheers.
Sent from my marlin using XDA Labs

Tulsadiver said:
I personally have never flashed it to both slots. Just the current slot
fastboot flash boot magisk_patched.img
Click to expand...
Click to collapse
Can I fastboot vendor and bootloader, or anything instead of the entire factory image if I want to roll back to August Pie from October 10? I'm going after DU and it's an August pie build.. Thanks for the info on slots! Somehow it helped me better understand the entire partition deal... I remember you from many years ago on some Nexus device that you made various mods for.. Anyway thanks! Alot!
Sent from my marlin using XDA Labs

flash713 said:
Can I fastboot vendor and bootloader, or anything instead of the entire factory image if I want to roll back to August Pie from October 10? I'm going after DU and it's an August pie build.. Thanks for the info on slots! Somehow it helped me better understand the entire partition deal... I remember you from many years ago on some Nexus device that you made various mods for.. Anyway thanks! Alot!
Sent from my marlin using XDA Labs
Click to expand...
Click to collapse
To roll back you not only have to flash the entire image but you'll have to wipe your phone.

TWRP boot looping?
I'm trying to root a Pixel XL Android 10, purchased form Google. I'm stuck at the point of trying to boot the phone to the temporary TWRP. Using command "fastboot boot twrp.img" .
I get the "Sending, Booting, Finished OKAY" messages, but the phone then shows a never ending flash of the TWRP logo every few seconds, with no functionality.
The twrp.img I'm using is twrp-3.0.2-0-RC1-fastboot-marlin.img
Any suggestions?

SeekMocha said:
I'm trying to root a Pixel XL Android 10, purchased form Google. I'm stuck at the point of trying to boot the phone to the temporary TWRP. Using command "fastboot boot twrp.img" .
I get the "Sending, Booting, Finished OKAY" messages, but the phone then shows a never ending flash of the TWRP logo every few seconds, with no functionality.
The twrp.img I'm using is twrp-3.0.2-0-RC1-fastboot-marlin.img
Any suggestions?
Click to expand...
Click to collapse
NEVER MIND: I was using wrong version of TWRP.

SeekMocha said:
NEVER MIND: I was using wrong version of TWRP.
Click to expand...
Click to collapse
What TWRP version did you use?

Pixel 3a XL Bootloop after enabling modules in Android 11

Hello!
I installed the new Android 11 stable and everything went well. I installed OTA and was able to flash a modified boot.img for root. I then wanted to re-enable the modules I turned off for the update. That's when I got stuck in a boot loop. I'm not sure the correct procedure for re-enabling the modules but immediately after restarting to let the modules take effect I ran into a boot loop.
To remedy this I tried re-flashing the modified boot image, which always leads to a boot loop.
I have also tried the "adb shell magisk --remove-modules" command during the boot loop but that immediately brings me to the fastboot screen with the reason "Invalid boot slot" and then it stays there until I flash another boot.img.
I've tried unpacking and repacking a magisk_patched.img with both the Pixel 3a XL's "core only" and "remove modules" but those lead to a fastboot error where it doesn't like the image and won't boot from it.
If I flash the stock Android 11 boot.img the phone boots up fine but doesn't have root obviously. I am also using the newest (30.0.4) version of android platform tools.
I was wondering if anyone else had some insight as to what I'm doing wrong or where to go from here?
Thank you in advance

scyther3989 said:
Hello!
I installed the new Android 11 stable and everything went well. I installed OTA and was able to flash a modified boot.img for root. I then wanted to re-enable the modules I turned off for the update. That's when I got stuck in a boot loop. I'm not sure the correct procedure for re-enabling the modules but immediately after restarting to let the modules take effect I ran into a boot loop.
To remedy this I tried re-flashing the modified boot image, which always leads to a boot loop.
I have also tried the "adb shell magisk --remove-modules" command during the boot loop but that immediately brings me to the fastboot screen with the reason "Invalid boot slot" and then it stays there until I flash another boot.img.
I've tried unpacking and repacking a magisk_patched.img with both the Pixel 3a XL's "core only" and "remove modules" but those lead to a fastboot error where it doesn't like the image and won't boot from it.
If I flash the stock Android 11 boot.img the phone boots up fine but doesn't have root obviously. I am also using the newest (30.0.4) version of android platform tools.
I was wondering if anyone else had some insight as to what I'm doing wrong or where to go from here?
Thank you in advance
Click to expand...
Click to collapse
Sounds like an incomparable magisk module. You need to isolate which module is the problem and leave it disabled or look for an updated version

adm1jtg said:
Sounds like an incomparable magisk module. You need to isolate which module is the problem and leave it disabled or look for an updated version
Click to expand...
Click to collapse
I would be fine with this but I have no idea how to disable the modules without root. And the adb shell isn't working for me either.

scyther3989 said:
I would be fine with this but I have no idea how to disable the modules without root. And the adb shell isn't working for me either.
Click to expand...
Click to collapse
I think it's in the themes forum here but they're is a magisk module disabler. They're are also other utilities to do so.

adm1jtg said:
I think it's in the themes forum here but they're is a magisk module disabler. They're are also other utilities to do so.
Click to expand...
Click to collapse
The only things I've seen for Module disablers are...
the adb shell magisk module disable
the patched "core only" and "module remover" repacked boot images
magisk uninstaller that requires a recovery to run it
I've tried the first two and I can't find a TWRP that works with a Pixel 3a XL running Android 11.

scyther3989 said:
The only things I've seen for Module disablers are...
the adb shell magisk module disable
the patched "core only" and "module remover" repacked boot images
magisk uninstaller that requires a recovery to run it
I've tried the first two and I can't find a TWRP that works with a Pixel 3a XL running Android 11.
Click to expand...
Click to collapse
And you won't find one. Twrp only works on Android 9 or older. Starting with 10 the partitions are dynamic and to date twrp can't handle them at all. Since we haven't had a working twrp in over a year i wouldn't get my hopes up.

adm1jtg said:
And you won't find one. Twrp only works on Android 9 or older. Starting with 10 the partitions are dynamic and to date twrp can't handle them at all. Since we haven't had a working twrp in over a year i wouldn't get my hopes up.
Click to expand...
Click to collapse
Yeah I'm hoping for some kind of insight on how to disable modules without root or maybe some new patch I haven't tried.

Try booting into safe mode, this is supposed to disable all modules. When you boot back into regular mode they should still be disabled and you can delete or update the bad one.
Sent from my SM-T860 using XDA-Developers Legacy app

rifraf1 said:
Try booting into safe mode, this is supposed to disable all modules. When you boot back into regular mode they should still be disabled and you can delete or update the bad one.
Sent from my SM-T860 using XDA-Developers Legacy app
Click to expand...
Click to collapse
Wow this actually worked!!
For anyone having a similiar issue:
I flashed the magisk_patched.img from Android 11 and let it go back into it's bootloop
As soon as the booting animation started I pressed volume UP and volume DOWN and it booted into safe mode
I restarted once I successfully made it into safe mode
The modules causing the bootloop were disabled and I am now able to have root in Android 11
Thank you @rifraf1