Related
I'm working on a tool I'm calling "applytheme". Basically you create a theme.zip, stick it in an archive with the included applytheme binary and update-script, sign it, and it will update the files on any of the Dream firmwares with the ones you've provided.
There are some limitations currently:
It can't yet determine space required before-hand, so you may run out of space in the middle. If you do, you can just restore the original theme with the restoration update.zip.
It can't add files - only replace existing ones.
The original files are stored in /data/original_theme.zip, which will eat your /data space, but only the replaced files are stored.
This version is a test release and may or may not have bugs. Be sure to back up your phone before trying it.
Please consult the example for figuring out what to put in the theme.zip, but it's basically full-path-to-filename-you-want-to-update/full-path-to-file-you-want-to-replace
So if you wanted to replace "assets/images/android_320x480.png" (the boot screen) in "/system/framework/framework-res.apk", you would have a file in your theme.zip called "system/framework/framework-res.apk/assets/images/android_320x480.png".
Case matters - please use the correct case (which is usually all lowercase).
Example theme (replaces boot animation only, with a cupcakedroid):
applytheme-200902090018-example.zip
Restoration update.zip (restores from /data/original_theme.zip then deletes original_theme.zip):
theme_restore-200902090018.zip
Source code (for developers or other curious people):
applytheme-200902090018.tar.gz
EDIT: 200902082117 fixes a couple of stupid bugs in 200902081755 :/
EDIT: 200902082316 removed extraneous/incorrect free space check; noticed that the update script stuff is significantly more stupid than I'd thought - update scripts should work now.
EDIT: 200902090018 close files so space can be reclaimed during patching
Reporting problems
If one of the applytheme updates fails, while still in the recovery mode please do the following:
Press ALT+X to get to the console
Press <enter> to get to the prompt
Type cp /cache/recovery/log /sdcard/recovery.txt
Type df >> /sdcard/recovery.txt
Type reboot to reboot.
Send the recovery.txt from the SD card to zinx <AT> users.sourceforge.net with the subject "applytheme error log"
If I don't have the log (or at least the error message from the log), I can't know why it's failing, and can't do anything to fix it.
I am looking at your post but don't see the benefits of doing it like this. you would still need to do this every time you add a theme or just a image and you still need to sign it or am I just not seeing the benefits of using it
kron2 said:
I am looking at your post but don't see the benefits of doing it like this. you would still need to do this every time you add a theme or just a image and you still need to sign it or am I just not seeing the benefits of using it
Click to expand...
Click to collapse
Current themes replace the whole system.
If you change as single file in /system/app/Browser.apk (say, an icon), you have to replace the whole file.
You don't have to do that with applytheme, so you can replace the icon no matter what firmware is being run.
This would be great themes wont need to be converted any more.
manup456 said:
This would be great themes wont need to be converted any more.
Click to expand...
Click to collapse
Indeed, for example:
More Vintage Less War via applytheme (theme by manup456 )
EDIT: Oh, I should note I tested this one with RC33. Didn't bother to time the progress meter though, so just wait until it tells you to reboot with home+back.
This looks like an amazing tool! I'm surprised more people haven't checked this out.
Let me get a few things straight before I give it a shot.
Let's say I was updating some basic images in the framework-res.apk. All I need to do is:
~Download your applytheme-example.zip
~Open up the theme.zip (remove current folders inside)
~Create the folders system\framework\framework-res.apk\res\drawable\
~Add the icons I've changed, with the exact original names
~rename applytheme-example.zip to update.zip
~load onto SD card and load onto phone as usual
~success?
I don't quite understand the backup system...
When you load the update onto the phone, it backs up the images you're replacing and puts them into a \data\original_theme.zip?
Then, if for some reason you want to revert to the original theme, you simply run the theme.restore.zip on the phone and it grabs all the \data\original_theme.zip images and places them in their original location?
Also, if the theme you're installing is a few megs, then the \data\original_theme.zip will get rather large, no? Will this cause any issues?
Thanks!
The steps are a bit more like this:
Download applytheme-example.zip
create system/framework/framework-res.apk/res/drawable/
add the files you've changed
create a theme.zip with the files above - MAKE SURE IT HAS THE PATH, STARTING WITH system/
replace the theme/theme.zip in applytheme-example.zip with your new theme.zip
sign the applytheme-example.zip with the replaced theme/theme.zip
put it on the SD card as /sdcard/update.zip and update as normal
success! (unless there was a problem during patching, then it may be partially applied and you can use theme_restore.zip to fix it)
MOONSSPOON said:
When you load the update onto the phone, it backs up the images you're replacing and puts them into a \data\original_theme.zip?
Then, if for some reason you want to revert to the original theme, you simply run the theme.restore.zip on the phone and it grabs all the \data\original_theme.zip images and places them in their original location?
Click to expand...
Click to collapse
Yep.
MOONSSPOON said:
Also, if the theme you're installing is a few megs, then the \data\original_theme.zip will get rather large, no? Will this cause any issues?
Click to expand...
Click to collapse
It can get large, yes, but keep in mind that it's only the original files that have changed that get put in it. Most themes right now are much larger .zips than they actually are, because they include much more than what was changed. If it gets too large to fit, the update will just fail part-way, and you can restore using the theme_restore.zip.
You can also delete it if you don't want to restore.
If you have any better ideas for any of this, I'm definitely open to suggestion - It's not anywhere near finalized yet
Great work. Definitely a step in the right direction for generalizing themes and allowing them to work with any build without modification.
Some thoughts for the next steps... Perhaps do a once-over of the files in theme.zip and compare their sizes with the existing files? This would just about double the time it takes to install, but should catch any out-of-space issues before any replacements had been made. Alternatively, perhaps there's a way to detect failures and automatically revert and display an error?
MasterBunnyFu said:
Great work. Definitely a step in the right direction for generalizing themes and allowing them to work with any build without modification.
Some thoughts for the next steps... Perhaps do a once-over of the files in theme.zip and compare their sizes with the existing files? This would just about double the time it takes to install, but should catch any out-of-space issues before any replacements had been made. Alternatively, perhaps there's a way to detect failures and automatically revert and display an error?
Click to expand...
Click to collapse
Automatic reversion can be done.
The update stuff is too stupid to let me display an error (Seriously. There's no way to display a message to the user. All I get is the unchangeable 'Failed on line 3'.) - an error is kept in /cache/recovery/log though.
Checking the file sizes would indeed take twice as long - everything is compressed, so I'd basically be creating every file touched, but discarding the output, then creating it all again. It already takes quite some time, and it should normally have enough space free, so I would prefer to go the automatic reversion route if people don't want to have to use the theme_restore.zip after a partial update.
So I tried throwing in your more vintage theme, but I get the error failed on line 4.
I feel like a leecher posting this message, but explain to me how it's done.
APrinceAmongMen said:
So I tried throwing in your more vintage theme, but I get the error failed on line 4.
I feel like a leecher posting this message, but explain to me how it's done.
Click to expand...
Click to collapse
Should just be putting in it; can you post the /cache/recovery/log from after it fails? May need to copy it somewhere before rebooting.
I expect it's due to lack of space, but it was ok here :x
In an effort to make it a bit easier initially, I've written "toapplytheme". It takes a theme update, the update it was based on, and outputs an applytheme compatible theme.zip - You still have to put in in theme/theme.zip in the applytheme update zip and re-sign it, though.
If you use something other than the update it was based on, you're going to end up with a lot of extra and/or missing files, so don't do it.
Ex:
Code:
toat MyExcellentTheme.zip JFv1.41_RC33_light2.zip theme.zip
toat-200902091613.zip
Worked for me
I have an ADP1 w/the latest JFv1.43h, I extracted Rusty Metal (from the RC33 version, using you tool). Put it there on the example, signed it all and voila...
The only thing I noticed is that the background did not get changed, but that is a minimal issue (and easily fixed).
Great job Zinx, I don't understand why all theme designers don't use this tool.
A matter of time I hope?
DanOtero said:
I have an ADP1 w/the latest JFv1.43h, I extracted Rusty Metal (from the RC33 version, using you tool). Put it there on the example, signed it all and voila...
The only thing I noticed is that the background did not get changed, but that is a minimal issue (and easily fixed).
Click to expand...
Click to collapse
I just applied Rusty Metal to my G1 using the standard way (not this tool) and the background doesn't install with it anyways, so it's not a problem with this tool, but the theme itself simply doesn't include it.
First off I'd like to start off by saying that I am kind of an idiot...with that said; I like to mess around with important files on my device(Acer a100) even though I have absolutely no clue what I'm doing.
Using titanium backup I uninstalled that download system apk. The one with the green icon and the white arrow pointing down. Now when I try to restore it through tit. Backup it will just freeze and keep saying that it is restoring and I have to finally force close titanium. I have also tried messing around with permissions in root explorer, fixing permissions in rom manager, navigating to system/app and installing it manually through a file explorer( get message install fail), and hard resetting.
The main problem is that everything I download will show in my notification bar and after I close/exit them they come back 5-30 min later. If I click on the download in my notification(not on the x) then my notification bar just closes. I can kinda fix this by turning my notifications off or cleaning data/cache on ?download storage? Apk/app.
Does anyone know of an easy fix for restoring this system apk. For there are no custom roms or recovery sources for this device that I have seen yet.
Thank-you, Robb
Get the system.apk file from the roms here
http://forum.xda-developers.com/showthread.php?t=1307046
i tried downloading those recovery files and twice they came back saying they were corrupted, is there any way someone can just upload the system file i need from their a100...its the downloads apk. the green icon with a white arrow pointing down
RobbandJenica said:
i tried downloading those recovery files and twice they came back saying they were corrupted, is there any way someone can just upload the system file i need from their a100...its the downloads apk. the green icon with a white arrow pointing down
Click to expand...
Click to collapse
PM me with your email address, I'll email you the apk from my A100, I'm still running the stock rom that I pulled it out of the box with.
You can download it straight to your tab from your email, beforee you do, get a file manager (like es file manager) from the market. You will be able to get to your downloads folder from there and install it.
ummmmm............ could you repeat that?
6stringandy said:
PM me with your email address, I'll email you the apk from my A100, I'm still running the stock rom that I pulled it out of the box with.
You can download it straight to your tab from your email, beforee you do, get a file manager (like es file manager) from the market. You will be able to get to your downloads folder from there and install it.
ummmmm............ could you repeat that?
Click to expand...
Click to collapse
He's got Root Explorer, that should do the trick.
To the OP: You are mounting the system partition R/W in Root Explorer when you try this, aren't you? Hate to ask a dumb question but.....
Yes I am hitting that button up top on root explorer changing it from r/w to r/o but I think some how I just got the wrong apk....after titanium wouldn't restore it I think I remember copying apk. From my phone (g2x) and attempting to restore those...dumb, I know I might of tried changing the names of the apk. Too,..like I say I f*** with s*** I have no business Fu****** with. I will p.m. my email now maybe I can get a screen shot of the system files if anyone feels up to it, so I can cross check proper name and sizes
How about just reinstalling the 3.2.1 update that is in the developer section. There should be no reason to factory reset since it is the same version. I have soft bricked mine a few times and I have just did the update again.
I even upgraded from whatever version the device shipped with to 3.2.1 without wiping the data.
A100 development section??? I see three a100 recovery downloads and one a101 recovery in our development section but when I download them i t says they were corrupted...if those are what your talking about...which one exactly should I use and what do I do with the file after words???
----sorry two that say a101 and two a100
So should I use file Id # 115,116,117,or 109
Use the one in this post. It is already decrypted. The ones in the frist post need to be decrypted using the Acer decryption tool. I have used the one I linked to probably 20 times. Once you run the update you will have to re-root the tablet.
thank-you all..recovered and fixed!!!
I was able to fix my problem by using the recovery update zips. But I want to thank everyone that helped, and remind people from experience to freeze unwanted system apps instead of uninstlling in titanium backup.u
Very important advice also is to search and read before starting new posts. I could have saved some time and headache just by doing that...the answers were just a couple paragraphs away the whole time.
I'm not sure if this is possible as ICS has no built in file manager, but is there anywhere I can put an apk file that it would be accessible without one? Specifically I want to be able to open an apk to install a file manager as the first thing I do after flashing a rom, to avoid needing to go through the market.
I thought maybe I could leave it in sdcard/download but it seems like the downloads program is blind to anything in that folder that wasn't officially "downloaded". (I suppose I could upload one to my dropbox and download it via the browser, if there are no viable options). Also made a few stabs at getting the gallery program to show one but it seems to filter out anything that's not a picture or video.
Any ideas for places to stick an apk and get one of the stock programs to let me open it?
maybe email it to yourself?
but you would have to log into the email app to do that
but there isnt really anyway to access the file without a file explorer
Open your favourite rom zip, add your apk to /system/app, save the zip, push that zip to the phone, flash.
Peesashiz said:
maybe email it to yourself?
but you would have to log into the email app to do that
Click to expand...
Click to collapse
Yeah in general I'm trying to cut out the step of signing into anything and just restoring my apps from a backup before I need to cancel automatic restore functions (which I do want on and running once I do my own initial run of things).
bk201doesntexist said:
Open your favourite rom zip, add your apk to /system/app, save the zip, push that zip to the phone, flash.
Click to expand...
Click to collapse
I'm guessing this comes with the consequence of raising any apk added in this manner to system app level? Not that I distrust the apps I'd have in mind for this to do anything malicious themselves, but is there any danger of opening security holes by elevating apps not designed to be system apps?
What I've done many times is just enabling Air Plane as soon as I can after flashing a ROM. That's way I can install any apk I want.
Hope it helps.
heo_con184 said:
What I've done many times is just enabling Air Plane as soon as I can after flashing a ROM. That's way I can install any apk I want.
Click to expand...
Click to collapse
Hmm but then what is your method for getting to that apk? If you do it over wifi that seems to defeat the point, no?
Personally I've found that it works just fine to uncheck the boxes for recovery syncing during the setup process, and then just re-enabling them later in settings. (Alternately, not signing into my google account at all until I've performed a backup). That way even if I end up signing into the market to download a recovery app, it doesn't automatically try to re-download everything else on its own.
I'm starting to think that my dropbox solution will be the cleanest, as it'll be a simple step of opening the browser and downloading a single apk every time at the same link.
I bet that the inclusion of a basic file explorer will be one of those headline items in a future android release. A nice basic functionality that the bloggers can rehash to death before anything actually hits.
Download the file manager apk over wifi and install the APK via download manager.
I do it all the time with Chinese android tablets with no market access.
Or Bluetooth it from another device.
Or just use the market
LTE EX Galaxy Nexus - 4.0.3 AOSP
Asus Transformer - Revolver OC/UV
JoeSyr said:
Hmm but then what is your method for getting to that apk? If you do it over wifi that seems to defeat the point, no?
Personally I've found that it works just fine to uncheck the boxes for recovery syncing during the setup process, and then just re-enabling them later in settings. (Alternately, not signing into my google account at all until I've performed a backup). That way even if I end up signing into the market to download a recovery app, it doesn't automatically try to re-download everything else on its own.
I'm starting to think that my dropbox solution will be the cleanest, as it'll be a simple step of opening the browser and downloading a single apk every time at the same link.
I bet that the inclusion of a basic file explorer will be one of those headline items in a future android release. A nice basic functionality that the bloggers can rehash to death before anything actually hits.
Click to expand...
Click to collapse
Transfer by USB from my laptop.
Is there a way to do that in which the device will launch the apk you move over? When I copy files over usb, it only ever puts them into whatever directory, and I need a file explorer to interact with them on the phone. And then I'm back to square one, as far as this particular task is concerned (once things are up and running I just use the LAN option in ES file explorer and it's as convenient as could be).
you have the apk in your computer right?
connect the phone to pc, and use adb to install
'adb install <apk_file_name.apk>'
Ah. I haven't used adb since I first unlocked/rooted a few months ago. Guess it probably pays to be a little familiar with those tools; they don't even occur to me when problem solving these days.
JoeSyr said:
Ah. I haven't used adb since I first unlocked/rooted a few months ago. Guess it probably pays to be a little familiar with those tools; they don't even occur to me when problem solving these days.
Click to expand...
Click to collapse
mark thread as solved then, if that solved it
Well a completely in-phone solution would still be nice, but I guess if there were any of those they'd have come up by now.
I'll probably use abd if I'm actively working at my computer and a dropbox download otherwise.
Hello guys,
I've just flashed the Paranoid Android ROM by WOH (http://forum.xda-developers.com/showthread.php?t=1912187&page=111) and I really like it.
However, I'm having some kind of issue with the PA engine settings.
The problem goes like this:
1. When I set the global UI settings, I'm asked to reboot, but the settings are back to defaults after the reboot.
2. When I edit the preferences for a particular app, I'm only able to make it work by setting and applying the needed values followed by using the launch button, which finally makes the changes effective. These changes are, however, also reset after rebooting the phone.
I did some searching and found this hint (http://www.paranoid-rom.com/forum/guides-references/256-hint-pa-prefs-does-not-save-changes) which seems to deal with this problem, but haven't had any luck with it. In the terminal, when trying to run the commands, I get an error saying my file system is mounted read only. So I tried modifying the file perimissions in the ES file manager (which also didn't work on some occasions, but sometimes it did), then running the terminal commands successfully, but without any effect on the PA preferences bahaviour after rebooting.
I ended up editing those files manually and removing the backup file (which, I thought, was overwriting the preferences file, reverting the settings to defaults). The ES file manager also behaved very oddly when trying to manipulate those files, once I was not allowed to delete those files, than they disappeared on their own, same goes for renaming.
Finally, I think, the problem is being caused by the properties file being overwritten with the defaults on every boot. So far I've been unable to determine the cause of this behaviour, so I hope perhaps some of you have come across this problem and know the solution. Thanks in advance for that.
Hello to members here.
Would be really grateful for any help with info' regarding my Galaxy Grand Dous GT-19082 running on 4.1.2. I like the phone a lot, and don't like the fact I accidentally deleted the wall paper picker and also the program monitor from the system with root delete app. So I can not use live wall paper now, or the program monitor
As said before, phone rooted, think using/has CWM. Apart from that it's standard.I didn't back up my phone with Titanium back up etc unfortunately. I have tried to see which ROM I am using, but can't find out, even under settings/about device. It must be a stock ROM I guess, as I only rooted it, didn't change ROM.
I have spent/wasted a day and a half so far trying to find info' on the web looking how I can re install these to the phone. Potentially frustrating. I have looked for the apk files but could not locate.
I am fairly basic with my knowledge on this techie stuff, so if anyone can explain as simply as possible and step by step. I would be most thankful. If I could pay somebody to do it, then I would probably be keen, just want my phone as it was again...
Thanks again, and respect in advance for any helps/info' and advise.
Sincere regards, Alex
Recklessly deleting a few, seemingly unimportant system files could have as destructive consequence as having to reflash your whole firmware via Odin. That means you have to backup all your apps and datas. What firmware version are you on currently? Maybe some guys here can help extracting the files from the firmware package you mentioned, or else you might have to download the whole firmware (mind you, it's huge) and flash it via Odin.
Hey Naufalhadyan, Thanks for the reply. Yes, was reckless and kind'a stupid deleting the files.
My firmware is I believe 4.1.2 Jelly Bean
mr_b_alex said:
Hello to members here.
Would be really grateful for any help with info' regarding my Galaxy Grand Dous GT-19082 running on 4.1.2. I like the phone a lot, and don't like the fact I accidentally deleted the wall paper picker and also the program monitor from the system with root delete app. So I can not use live wall paper now, or the program monitor
As said before, phone rooted, think using/has CWM. Apart from that it's standard.I didn't back up my phone with Titanium back up etc unfortunately. I have tried to see which ROM I am using, but can't find out, even under settings/about device. It must be a stock ROM I guess, as I only rooted it, didn't change ROM.
I have spent/wasted a day and a half so far trying to find info' on the web looking how I can re install these to the phone. Potentially frustrating. I have looked for the apk files but could not locate.
I am fairly basic with my knowledge on this techie stuff, so if anyone can explain as simply as possible and step by step. I would be most thankful. If I could pay somebody to do it, then I would probably be keen, just want my phone as it was again...
Thanks again, and respect in advance for any helps/info' and advise.
Sincere regards, Alex
Click to expand...
Click to collapse
1. Boot into recovery, Volume UP + Home + Power
2. Select Install zip and choose this zip file - View attachment apps-update.zip
3. Let it install
4. Go back, select Wipe Cache
5. Go to advanced, select Wipe Dalvik-cache
Alternatively, extract the zip, mount your /system and copy the apks included and set their permissions to rw-r--r--
I couldn't find an exact apk that says Program Provider, so I'm included both possible ones.
Apks included:
- ApplicationsProvider
- SecLiveWallpapersPicker
- SecWallpaperChooser
- TaskProvider
All above apps are extracted from 4.1.2 XXAMF7 firmware directly.
The zip file will copy and replace the above system apps. Clearing cache and dalvik-cache will let your phone upgrade apps but no data will be lost, without it you might get Force Closes.
NOTE: Please make sure you back up your data before-hand, just in case
Hi Iceyhotguy,
Much thanks to you for the zip link and what seems like straight forward instructions.
I have spent a while trying to add the zip. When I go into recovery mode, it says it can not mound sd card. I have even payed for the premium version of CWM now, thinking I could add the zip this way, which I think I can, but again in recovery mode, it can not mount the sd card, which is where the file is download to. (I think)
Have downloaded the file straight to the phone aswell, but no luck yet.
I guess I have to install manually some how, you said ''Alternatively, extract the zip, mount your /system and copy the apks included and set their permissions to rw-r--r--'' . If you could be so kind to talk me through in baby steps (as I don't really understand this way) how I can do it this way, seeing the recovery mode way is not working for some reason.
Close,but not quite there yet.
Really hoping to fix my mistakes of accidentally deleting file soon, guess it's a good lesson, and I am learning more about this kind of thing, so not all bad.
Hope to hear back from you, and/or other members soon.
Thankyou,
Alex
Spent ages trying to fix my phone, and research online how I ''copy the apks included and set their permissions to rw-r--r--'' can't do it, getting frustrating..
Also I read online that using CWM as a recovery is not needed on a stock ROM and the error message in recovery 'can't not mount sd card'' can happen with stock rom and CWM....
Would really appreciate some help to fix this. Thanks:good:
Managed to try change permission with a root explorer program, though it says some files do not allow permission change, so seems I can not so this either
mr_b_alex said:
Spent ages trying to fix my phone, and research online how I ''copy the apks included and set their permissions to rw-r--r--'' can't do it, getting frustrating..
Also I read online that using CWM as a recovery is not needed on a stock ROM and the error message in recovery 'can't not mount sd card'' can happen with stock rom and CWM....
Would really appreciate some help to fix this. Thanks:good:
Click to expand...
Click to collapse
Reflash the CWM for 4.1.2 with Odin from here - http://forum.xda-developers.com/showpost.php?p=42349036&postcount=1
That'll fix the sdcard issue. If it doesn't try putting the zip file in internal memory.
I explained how to copy bootanimation file here in steps and paste it back in /system/media with setting permissions : http://forum.xda-developers.com/showpost.php?p=46010766&postcount=2
The same principle will apply when copying apks from the above zip file, take all 4 apks, and paste them in /system/app folder then follow my post above to set permission.
iceyhotguy said:
Reflash the CWM for 4.1.2 with Odin from here - http://forum.xda-developers.com/showpost.php?p=42349036&postcount=1
That'll fix the sdcard issue. If it doesn't try putting the zip file in internal memory.
I explained how to copy bootanimation file here in steps and paste it back in /system/media with setting permissions : http://forum.xda-developers.com/showpost.php?p=46010766&postcount=2
The same principle will apply when copying apks from the above zip file, take all 4 apks, and paste them in /system/app folder then follow my post above to set permission.
Click to expand...
Click to collapse
Thanks for the info' s. Have tried, done what was well explained, but still no luck..
Think I try to reflash the stock rom via odin, if you have any links /info' on this, that would be great, thanks
iceyhotguy said:
1. Boot into recovery, Volume UP + Home + Power
2. Select Install zip and choose this zip file - View attachment 2581684
3. Let it install
4. Go back, select Wipe Cache
5. Go to advanced, select Wipe Dalvik-cache
Alternatively, extract the zip, mount your /system and copy the apks included and set their permissions to rw-r--r--
I couldn't find an exact apk that says Program Provider, so I'm included both possible ones.
Apks included:
- ApplicationsProvider
- SecLiveWallpapersPicker
- SecWallpaperChooser
- TaskProvider
All above apps are extracted from 4.1.2 XXAMF7 firmware directly.
The zip file will copy and replace the above system apps. Clearing cache and dalvik-cache will let your phone upgrade apps but no data will be lost, without it you might get Force Closes.
NOTE: Please make sure you back up your data before-hand, just in case
Click to expand...
Click to collapse
Thanks a ton man, this worked for me and now I re-installed Live Wallpaper APK. Could not install via any root perm enabled file manager. Sumit pointed me here, thanks to him too.