Develop Bugs

[Fix] Banding problem fix with launcherPro on widgets.

On all roms there is a banding problem due to our screens 65 k colors.
But launcherpro fixes the banding problems on widgets But on some gingerbread roms it does not.
I have not made this fix. But I have tested it on some roms. Im am just sharing this. credit goes to Tytung who took his time and fixed this in his latest 2.5 rom and GPC + other developers that may have found this already.
I have tried it on Tyweens cm7 rom, Tytungs rom and some other. But it "maybe" works on others to? Like gpc's one?
= When using launcher pro with this fix. The launcher will have no banding problems on widgets and on the homescreen. But other banding problems will still be there like it was before.
So without fix ,the clock widget will look like crap in launcher pro in tyweens cm7 rom. But with the fix it will look smooth.
The zip changes the libsurfaceflinger.so.
Flash in cwm.

Thank God, at last! Great stuff

works on tyween cm7.

thank you! this is the main reason i switch some roms lol

will this work on other HD2 NAND roms using launcherpro? like using hyperdroid CM7?

The source code
If you are a developer of source code maker, the following is my fix for banding issue. (NOT Tytung, i don't know how he fix it )
The source code path :
/frameworks/base/services/surfaceflinger/SurfaceFlinger.cpp
Function position:
Code:
sp<Layer> SurfaceFlinger::createNormalSurface(
const sp<Client>& client, DisplayID display,
uint32_t w, uint32_t h, uint32_t flags,
PixelFormat& format)
{
// initialize the surfaces
switch (format) { // TODO: take h/w into account
case PIXEL_FORMAT_TRANSPARENT:
case PIXEL_FORMAT_TRANSLUCENT:
format = PIXEL_FORMAT_RGBA_8888;
break;
case PIXEL_FORMAT_OPAQUE:
//format = PIXEL_FORMAT_RGBX_8888;
format = PIXEL_FORMAT_RGB_565;
break;
}
sp<Layer> layer = new Layer(this, display, client);
status_t err = layer->setBuffers(w, h, format, flags);
if (LIKELY(err != NO_ERROR)) {
LOGE("createNormalSurfaceLocked() failed (%s)", strerror(-err));
layer.clear();
}
return layer;
}
Modified code:
Code:
case PIXEL_FORMAT_OPAQUE:
//format = PIXEL_FORMAT_RGBX_8888;
format = PIXEL_FORMAT_RGB_565;
break;
Reason:
It is caused by the display driver is not match with HD2. The gingerbread has fix it on driver level with new pixel format RGBX_8888, however it is still not working for HD2. So we have to force the default pixel format into RGB565

iamgpc said:
If you are a developer of source code maker, the following is my fix for banding issue. (NOT Tytung, i don't know how he fix it )
skip...
Click to expand...
Click to collapse
I think I need to clarify something.
Gpc sent a private message and asked me how I fixed the color banding issue on 27th March 2011, 09:50 PM.
P.S.: Admin can confirm this.
Because I was busy at that time, I replied his question by only giving him this link including libsurfaceflinger.so.
Then maybe he fixed this issue from the source code by himself, but he really got hints from me.
Let us go back about 20 days ago.
In fact, I tried to solve this color banding issue since 13th March 2011, and I shared my possible method in my thread.
http://forum.xda-developers.com/showpost.php?p=12049180&postcount=2487
When I had time, I released a modified/recompiled libsurfaceflinger.so on 21st March 2011, and requested other users to test it.
http://forum.xda-developers.com/showpost.php?p=12241393&postcount=2846
Then I included this .so file in my v2.5 ROM.
Gpc saw my change log and sent me a private message, and ...
That's the whole story.

what stops this being implemented throughout the UI (i.e. notification bar, buttons etc)?

I'm not getting 3g, only EDGE on this ROM. My APN settings are right and data is definitely on so I don't know what the problem is. I have a T-Mobile HD2 and T-Mobile. Please help.

Tried this fix, and i am truly impressed! No longer banding using ADW Ex and even XDA App! It does not seem to "fix" only launcher pro to me!
EDIT : copilot still has banding though, but not a big deal given the improvements elsewhere!

tytung said:
When I had time, I released a modified/recompiled libsurfaceflinger.so on 21st March 2011, and requested other users to test it.
http://forum.xda-developers.com/showpost.php?p=12241393&postcount=2846.
Click to expand...
Click to collapse
humm,
Do you modify the libsurfaceflinger like mine? Do you compile with BOARD_NO_RGBX_8888 := true to fix this isse?
Because my libsurfaceflinger is changed for my personal using. I also modify somewhere else for my testing, so that I cannot use your libsurfaceflinger.
I don't know what you modify in your source code, so I have to find out the root cause.
According to Google search on "android color banding", you can find a JAVA solution on color banding.
http://stuffthathappens.com/blog/2010/06/04/android-color-banding/
It says the PixelFormat will take effect on banding issue. Take a look on surfaceflinger source code, you can find out the PixelFormat.OPAQUE and PixelFormat.RGBA_8888 will cause the different result.
Finally, you just have to modify the PixelFormat.OPAQUE from RGBX_8888 to RGB_565

iamgpc said:
humm,
Do you modify the libsurfaceflinger like mine? Do you compile with BOARD_NO_RGBX_8888 := true to fix this isse?
Because my libsurfaceflinger is changed for my personal using. I also modify somewhere else for my testing, so that I cannot use your libsurfaceflinger.
I don't know what you modify in your source code, so I have to find out the root cause.
According to Google search on "android color banding", you can find a JAVA solution on color banding.
http://stuffthathappens.com/blog/2010/06/04/android-color-banding/
It says the PixelFormat will take effect on banding issue. Take a look on surfaceflinger source code, you can find out the PixelFormat.OPAQUE and PixelFormat.RGBA_8888 will cause the different result.
Finally, you just have to modify the PixelFormat.OPAQUE from RGBX_8888 to RGB_565
Click to expand...
Click to collapse
Yes, I compiled with BOARD_NO_RGBX_8888 := true to fix this issue.
BTW, you didn't know how I modified my source code because you didn't say that you want to see my modified source code in the private message.
Anyway, I only changed the color support of the config file from RGBX_8888 to RGB_565.
And you don't need to modify SurfaceFlinger.cpp because setting NO_RGBX_8888 in config file is enough.
Below is the detail.
Before Google released Gingerbread OTA 2.3.3, we could only use Froyo OTA's proprietary files to work with Gingerbread source code when we compiled AOSP Gingerbread 2.3.2 or 2.3.1.
And Froyo's proprietary files are not compatible with Gingerbread source code, so we needed to fix the RGB_565 problem by applying the following two commits at that time.
https://github.com/CyanogenMod/andr...mmit/d06cf2371b2db46ab4ecedea832e4c17f3591165
https://github.com/CyanogenMod/andr...mmit/baa078471f4198bd73819794f2713a845305a227
After Google released Gingerbread OTA 2.3.3, we used Gingerbread OTA's proprietary files to work with Gingerbread source code when we compiled AOSP Gingerbread 2.3.3.
At the same time, I removed these two commits above when compiling a new GB 2.3.3 ROM.
That's why hg3atintin (Thanks to him.) told me that my GB 2.3.3 ROM had the color banding issue but my GB 2.3.2 ROM didn't.
Finally, I added back these two commits and compiled a new surfaceflinger.so.
Then the color banding issue is improved.

it fixed my launcherpro , calculator had severe banding but its fixed too
nice job mate

How do I apply this fix to my AmericAndroid SD build? Any help would be appreciated...
P.S. I searched this thread and others and cant figure it out, please point me in the right direx... What is CWM btw because it says to flash with CWM?

How does this banding look like?

edit: sorry wrong thread

nice! gonna try this out

ludetekniq said:
How do I apply this fix to my AmericAndroid SD build? Any help would be appreciated...
P.S. I searched this thread and others and cant figure it out, please point me in the right direx... What is CWM btw because it says to flash with CWM?
Click to expand...
Click to collapse
Hi ludetekniq.
You're in the wrong place. This is NAND development forum and not SD development. You can only install this fix if you have a NAND Rom in your HD2.
EDIT: CWM = Clockworkmod Recovery. It's a tool that we use, to help flashing and recover Roms on NAND.

silly question..lol
what is the banding problem? )

alaaassem said:
silly question..lol
what is the banding problem? )
Click to expand...
Click to collapse
Well... from what I understood, its an issue related to the color depth of HD2 screens. Our HD2 Android is displaying 16 bit color insted of 32 bit because of a driver's issue... it loses quality because it's displaying less colors. With 32 bit you will see a smoother color gradient.
Please devs correct me if i'm wrong!
Cheers from Portugal!

[Q] .Smali files modifying...

Hey!
I'm trying to modify Google Search "velvet.apk" to enable Sound search but I don't find anything .xml file that needs modifying..
so I checked smali folder and there is the files but I don't know what means "Z" and "I"
If somebody knows what those means then can you please tell me..
Code:
# instance fields
.field private cachedSize:I
.field private detectedCountryCode_:Ljava/lang/String;
.field private hasDetectedCountryCode:Z
.field private hasStatusCode:Z
I don't know what I should change because I don't know what means Z, I or L or M
Thank you if you can help!

You will have better luck changing it from source.

Mach3.2 said:
You will have better luck changing it from source.
Click to expand...
Click to collapse
Thanks but I have never changed nothing from sources or even built ROM from source because my PC's & notebook CPU is not enough good for that..
and I think I can't modify its source files, if it could be possible then someone would have already made changes to the "google apps"........

manumanfred said:
Thanks but I have never changed nothing from sources or even built ROM from source because my PC's & notebook CPU is not enough good for that..
and I think I can't modify its source files, if it could be possible then someone would have already made changes to the "google apps"........
Click to expand...
Click to collapse
Wait, what the hell i'm talking about..
Google apps are closed sourced i believe, it's not available from the AOSP repo.

Find7a: Huge flickering horizontal black bar in many custom roms

I have a weird issue with many custom roms
There is a big black horizontal overlay bar that fickers where I put my thumb
And both bottom and top side of screen have a halo melted cheese effect if I push to far up or down
Here is a video about it (sorry for quality, just shot it before going to work this morning)
http://youtu.be/1AQQ5XLTHQM
Roms with issue:
CodeName Lungo
Mokee
CM11
Nameless
Rom Ok
Team EOS Revival
Each was installed like this
4wipe=>Install Rom=>Factory Reset=>Reboot
Recovery is TWRP 2.8.0.1
Any idea how can I fix this ?
Thx in advance

Same issue here too. CM11 M8 snapshot is fine and so is AICP Sept 9 Release version. Problem seems to be after the sept 20 cm nightly. Issue occurs on all cm based roms. I have not seen a fix for this yet. Besides i have decided tonot use nightlies anymore. Will wait for next aicp release.
Sent from my Find7 using Tapatalk

Not a fix, but a workaround for this bug :
Go to Developer options and check "disable hardware overlays".
Works, but you have to re-check it every time you restart the phone.

I had these problems too, but this worked for me, permanent (unless you update, because then the build.prop get's overwritten). But be careful with your build.prop, so make a backup first.
jee'sgalaxy said:
There are time when people get screen flicker problems when flashing a new ROM. This either has to do with the ROM itself, for the kernel. Until full support is givien, I have a temporary fix. This fix is basically disabling HW overlay, but disabling HW overlay in the settings does not stick on reboot and this has been really annoying.
For those who want to know what Disabling HW overlay is, it is basically making the phone's gpu render the graphics instead of the cpu. This allows for better graphical rendering of everything. This is not a proven statement, but theoretically, disabling HW overlay, may increase battery consumption... not by much though.
Finally, I am not responsible for anything that goes wrong with your phone when using my method. Please don't whine that it did not work or I messed your phone up. You are doing this at your own risk!!
My fix
Step 1 - Download a build.prop editor app from the play store (I recommend JRummy's one) and run the app. MAKE A BACKUP OF ORIGINAL build.prop!!
Step 2 - Locate these four lines
a) debug.mdpcomp.maxlayer
b) debug.composition.type
c) dev.pm.dyn_samplingrate or dev.pm.cpu_samplingrate (you may not find these values; however, if you do, change the "dyn" or "cpu" to gpu) --> dev.pm.gpu_samplingrate
**If you cannot find this value add "dev.pm.gpu_samplingrate"
d) debug.sf.hw
e) debug.egl.hw
Step 3 - Edit the values of each one
a) debug.mdpcomp.maxlayer = 0 or 1 or 2 --> READ EDIT BELOW
EDIT* --> This value can be either 0 or 1 or 2. I put mine on 0 right now and I feel like I'm getting better performance. Before, I put it at 1 or 2; so, you can try it with 2 first.
b) debug.composition.type = gpu
c) dev.pm.gpu_samplingrate = 1
d) debug.sf.hw = 1
e) debug.egl.hw = 1
f ) If you are running CM10, go to setting --> performance --> surface improvement --> disable dithering (AOKP has no option for this)
Make sure to save after each edit. The saved edit will not appear changed until you reboot your device.
After rebooting, make sure to see the changed values.
Thanks to everyone who has given me info of their device. Thanks to davietr for his input on including the "dev.pm.gpu_samplingrate" value
If this helped and work, Thanks would be appreciated.
EDIT **If it's not too much of a hassle and my fix methods worked for you, please post what ROM/Kernel you are using on this page to help others!!**
Click to expand...
Click to collapse

Seems like CM broke something, and everyone that tracks CM got broken too.
The four projects I know of that are not CM-based are:
EOS (as you've mentioned)
Gummy (they track CM for a lot of stuff, but not everything, dhacker did his own kernel rebase for example)
Omni (We track CAF on our own without doing CM's AOSP+CAF frankendisplay crap, and did our own kernel rebase)
Dirty Unicorns (uses Omni's hardware support stuff)

Temporary workaround for this is to enable developer options and remove the check boxes from Force GPU Rendering as well as Deactivate Hardware Overlay.

[KERNEL] Nexus 9 5.0.1 Stock Kernel with 2Amp Charging

Disclaimer: Im not responsible for any damage done to your device if you flash this kernel.
Nexus 9 5.0.1 Stock Kernel with 2Amp charging modification
http://www38.zippyshare.com/v/52487126/file.html
compiled from source. edited the current limits based on FIK kernel. thanks to USBHost.
https://github.com/USBhost/FIK/commit/62aa76b7e1c6e68abdcc723e7a2aabfd398cf9e4
I'm still trying to figure out how to change the kernel version name. But this is a working kernel. I'm using it on my device. The highest charging current i have achieved is 1.9amps and charges my N9 from 5% to 100% in 3.5 hours using an Apple Charger.
Feedback is appreciated.

heres a screenshot of 3c toolbox battery status

Will this be good for LTE model or just wifi

I'm not sure if the kernel for lte is the same. I only have the non lte nexus9

Seems to work just fine on my LTE version. Verified the data connection still comes up and works for me.

jonahmt21 said:
I'm still trying to figure out how to change the kernel version name.
Click to expand...
Click to collapse
You will need to edit your defconfig for that
make "your defconfig"
make menuconfig
select the first option
select the second option :: if I remember correctly
Then type what you want
Then exit and save

Can you make this as flashasble zip please

How flash this kernel? On fastboot or can use flashify?

I used flashify and it worked great. No need for a flashable zip.

fastboot install using the nexus root toolkit.

I should of known... If you removed encryption, install this kernel, your device will encrypt itself... Dag nab it..

USBhost said:
You will need to edit your defconfig for that
make "your defconfig"
make menuconfig
select the first option
select the second option :: if I remember correctly
Then type what you want
Then exit and save
Click to expand...
Click to collapse
Actually, isn't that easier to just open the Makefile at the kernel dir? "kernel/htc/flounder/Makefile"
Code:
VERSION = 3
PATCHLEVEL = 10
SUBLEVEL = 40
EXTRAVERSION = [COLOR=Green][I]ENTER HERE FREE SPACE[/I][/COLOR]
NAME = [COLOR=DarkRed]TOSSUG Baby Fish [COLOR=Green]<--Or just change the given name here[/COLOR][/COLOR]
The first blank space option prob better.
I know I am a million years late here but I don't know how many old old threads I've had to read to get stuff. So good deal. I'm still trying to get the Camera working on DirtyUnicorns on flounder. haha
I think I must have a problem with my setup cuz I am getting weird compile errors when I try to build the kernel, inline or not....Like the stupid -mlittle_endian crap. MAN! gcc or PATH issues? hmm

wantowan2 said:
Actually, isn't that easier to just open the Makefile at the kernel dir? "kernel/htc/flounder/Makefile"
Code:
VERSION = 3
PATCHLEVEL = 10
SUBLEVEL = 40
EXTRAVERSION = [COLOR=Green][I]ENTER HERE FREE SPACE[/I][/COLOR]
NAME = [COLOR=DarkRed]TOSSUG Baby Fish [COLOR=Green]<--Or just change the given name here[/COLOR][/COLOR]
The first blank space option prob better.
I know I am a million years late here but I don't know how many old old threads I've had to read to get stuff. So good deal. I'm still trying to get the Camera working on DirtyUnicorns on flounder. haha
I think I must have a problem with my setup cuz I am getting weird compile errors when I try to build the kernel, inline or not....Like the stupid -mlittle_endian crap. MAN! gcc or PATH issues? hmm
Click to expand...
Click to collapse
True you can use EXTRAVERSION one
but the other one NAME it wont show in the kernel version

Could someone compile a version of this kernel with encryption disabled?

siraltus said:
Could someone compile a version of this kernel with encryption disabled?
Click to expand...
Click to collapse
You just need to edit the ramdisk
No need to recompile

All links are dead
Sent from my SM-N920C using XDA-Developers mobile app

[TUT] How to Optimize your CM13

OPTIMIZE YOUR CM13​
PREREQUISITES:
CyanogenMod 13 ROM
Nokia X
You
First of all, this thread's purpose is to make our Marshmallow Experience better. I have been using a CM13 ROM and it's good, but it can never surpass Stock ROM in stability, smoothness and other things alike.
Now, assuming that you've already done all the things that has to be done on successfully booting the ROM (repartitioning, flashing Gapps, etc), we're gonna start .
TIPS
NO. 1
Code:
Do not use too many apps! I mean, we have a very low end phone right here and were aiming to make it better. Use only the apps that you need. Much less apps, much less lag :good:
NO. 2
Code:
If you're gonna have to flash Gapps, flash the [I]pico[/I] one. Since it's the most logical thing to use in this device.
NO. 3
Code:
Refrain from using themes. They consume RAM and lags the UI.
NO. 4
Code:
Replace Trebuchet(CM's default launcher) with any other third party launchers. *cough*Nova*cough*
NO. 5
Code:
Use other root solutions (SuperSU, Magisk etc). I had problem with CM su.
More to come
TRICKS
NO. 1
You're gonna have to enable developer options in setting (tap build no. until it's enabled). The go to Hardware accelerated rendering. Enable Force GPU rendering and Disable HW overlays. You can optionally tweak the animation speed if you like.
NO. 2
The DPI of the ROM is 240, which I think is okay for our phones. But on my opinion, the best one that suites or device is 220. You can change it in Setting > Display & lights > LCD density
NO. 3
Having only the back button working is a pain. We can enable the Navigation Bar by adding this line to /system/build.prop
Code:
[FONT="Courier New"]qemu.hw.mainkeys=0[/FONT]
NO. 3
Enable root in Settings > Developer options > Root access. Choose Apps and ADB
REMOVING CM BLOATWARES
Assuming you already have Root access, Install Terminal Emulator.
After that type:
Code:
su
Which will then prompt you with Root authentication, grant it.
Now, we can disable (not delete/uninstall) bloats using this command,
Code:
pm disable <name of the app>
Here's the list of what we don't need:
org.cyanogemod.screencast (Screen Recorder)
org.cyanogenmod.theme.chooser2 (Theme Chooser, we don't need it )
com.android.email (Do you use email?? If you do, do not include this)
com.android.exchange (Exchange Services)
All of the live wallpapers and Live wallpaper picker (i think you can find them on your own)
com.android.cellbroadcastreceiver (Cell Broadcast)
com.cyanogenmod.updater (CM Updater)
com.android.printspooler (Print Spooler)
com.svox.pico (Pico TTS)
org.cyanogenmod.screencast (Screen Recorder)
org.cyanogenmod.weather.provider (Weather Provider)
org.cyanogenmod.weather.service (Weather service)
BUILD.PROP TWEAKS
Next thing we do is to add these on build.prop
Code:
debug.performance.tuning=1
persist.sys.ui.hw=1
persist.sys.composition.type=gpu
dalvik.vm.dex2oat-filter=interpret-only
dalvik.vm.image-dex2oat-filter=interpret-only
debug.composition.type=gpu
video.accelerate.hw=1
ro.kernel.checkjni=0
profiler.force_disable_ulog=0
profiler.debugmonitor=false
debugtool.anrhistory=0
# more to come
KERNEL ADIUTOR
Install this one Kernel Adiutor and you can edit many things.
Go to CPU section, then choose ondemand as default governor since it's basically more performance driven that other governors (except performance governor ).
MORE TO COME :highfive:
XDA:DevDB Information
CM13 Optimizer, Tool/Utility for the Nokia X
Contributors
veez21, weritos
Version Information
Status: Beta
Created 2016-12-31
Last Updated 2017-05-01

Reserved

Reserved

let me add some..open kernel adiutor...
1) change io scheduler...its most important.. better choose cfq bcoz default is deadline which means single task only...that is you can't pull even status bar while an app is opening!!!
2) my CPU settings ( to prevent overheating and greater performance)
choose conservative governor
then choose its settings and set
low/min threshold=65
high/max threshold=90
its just the best setting for everything

ani00 said:
let me add some..open kernel adiutor...
1) change io scheduler...its most important.. better choose cfq bcoz default is deadline which means single task only...that is you can't pull even status bar while an app is opening!!!
2) my CPU settings ( to prevent overheating and greater performance)
choose conservative governor
then choose its settings and set
low/min threshold=65
high/max threshold=90
its just the best setting for everything
Click to expand...
Click to collapse
Thanks for the suggestion. I will add that but not now. It's almost New Year :laugh:

can you give me kenrel and boot.img and build.prop for xl

UPDATED
New Tricks
Added more build.prop tweaks
New bloats
Fixed some typos

please make a patch for nokia xl...

We Need All This Is The Most Important On Cyanogen ROM

i still not have cm13 rom....where can i get it????

abhijit1998 said:
i still not have cm13 rom....where can i get it????
Click to expand...
Click to collapse
sorry, I'm not allowed to do that, but you can actually just apply these in cm11 based roms, we have plenty of those here. :good:

veez21 said:
sorry, I'm not allowed to do that, but you can actually just apply these in cm11 based roms, we have plenty of those here. :good:
Click to expand...
Click to collapse
ok.....:crying:

veez21 said:
sorry, I'm not allowed to do that, but you can actually just apply these in cm11 based roms, we have plenty of those here. :good:
Click to expand...
Click to collapse
Do I have to bought cm13 ROM from weritos?

UPDATED
New build.prop tweaks

veez21 said:
New build.prop tweaks
Click to expand...
Click to collapse
Where to get cm13 ROM?

https://forum.xda-developers.com/an...od-ultimate-performence-blazing-fast-t3482317
just try this bro...
you will love it

ani00 said:
https://forum.xda-developers.com/an...od-ultimate-performence-blazing-fast-t3482317
just try this bro...
you will love it
Click to expand...
Click to collapse
lol, most of the scripts inside it doesn't work. Placebo of you ask me. The dev(or is he?) doesn't even know what he's doing. He was just putting things together not knowing what they do and how they work. Trust me. All guys who complimented the so called mod has no idea what's going on with the scripts inside and what they do and if they work. I don't even want to comment there.

veez21 said:
lol, most of the scripts inside it doesn't work. Placebo of you ask me. The dev(or is he?) doesn't even know what he's doing. He was just putting things together not knowing what they do and how they work. Trust me. All guys who complimented the so called mod has no idea what's going on with the scripts inside and what they do and if they work. I don't even want to comment there.
Click to expand...
Click to collapse
agreed...but bro if it works theoretically or not, doesnt matter..
what finally matter is the performance amd battery,
with 1st boot, i can feel a massive difference... i actually cant feel if its old slow nokia..
even i have tried many mod, none worked before
anyways its your opinion

ani00 said:
agreed...but bro if it works theoretically or not, doesnt matter..
what finally matter is the performance amd battery,
with 1st boot, i can feel a massive difference... i actually cant feel if its old slow nokia..
even i have tried many mod, none worked before
anyways its your opinion
Click to expand...
Click to collapse
Actually, the difference you feel comes from the cpu/governor something script, which pushes the cpu to it's limits. Every other script won't do anything, that's why they have another guy managing the beta thread because the orig guy doesn't know how to

any place for getting cm13 ROM????