Hi all
I'm sure many of you have noticed how bad dark wallpapers look on ripple lockscreen. Its a pain on all Samsung devices with this effect. The water overlay washes out blacks and makes things look generally cloudy.
Me and Dazznuts been playing with ripple renderer and found the following to remove the hazy overlay. One to remove the cloud and one to improve ripple visibility on dark walls. We just replace some values with 0x1 and 0x0.
We changed the refractiveIndex because if using a black heavy background the ripple became hard to see. Changing the refractiveIndex makes it refract a greater distance so it will usually pick up some of the colored part of the wallpaper. Using a totally black wallpaper with no image will result in ripple being invisible.
Thanks to Bombaybadboy who confirmed this works on S4 and gave some screenshots. I thought I would post it here as I think ROM makers will find it useful. Decompile android.policy.jar and open CircleUnlockRippleRenderer.smali from com/android/internal/policy/impl/keyguard/sec/....
Search for this...
Code:
const/high16 v5, 0x3fc0
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->mLightHeight:F
.line 189
const v5, 0x3f6e147b
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->refractiveIndex:F
.line 190
const v5, 0x3e051eb8
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->reflectionRatio:F
.line 191
const/high16 v5, 0x3f80
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->alphaRatio1:F
First we want to change the value put into refractiveIndex....
So change these lines....
Code:
const v5, 0x3f6e147b
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->refractiveIndex:F
...to this....
Code:
const/4 v5, 0x1
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->refractiveIndex:F
Next we remove the overlay by changing these lines....
Code:
const/high16 v5, 0x3f80
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->alphaRatio1:F
...to this....
Code:
const/4 v5, 0x0
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->alphaRatio1:F
Thats it. Simple and effective. Heres some screenshots.
Before...
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
After...
Before....
After....
Enjoy
wallpaper
Goldieking said:
Hi all
I'm sure many of you have noticed how bad dark wallpapers look on ripple lockscreen. Its a pain on all Samsung devices with this effect. The water overlay washes out blacks and makes things look generally cloudy.
Me and Dazznuts been playing with ripple renderer and found the following to remove the hazy overlay. One to remove the cloud and one to improve ripple visibility on dark walls. We just replace some values with 0x1 and 0x0.
We changed the refractiveIndex because if using a black heavy background the ripple became hard to see. Changing the refractiveIndex makes it refract a greater distance so it will usually pick up some of the colored part of the wallpaper. Using a totally black wallpaper with no image will result in ripple being invisible.
Thanks to Bombaybadboy who confirmed this works on S4 and gave some screenshots. I thought I would post it here as I think ROM makers will find it useful. Decompile android.policy.jar and open CircleUnlockRippleRenderer.smali from com/android/internal/policy/impl/keyguard/sec/....
Search for this...
Code:
const/high16 v5, 0x3fc0
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->mLightHeight:F
.line 189
const v5, 0x3f6e147b
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->refractiveIndex:F
.line 190
const v5, 0x3e051eb8
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->reflectionRatio:F
.line 191
const/high16 v5, 0x3f80
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->alphaRatio1:F
First we want to change the value put into refractiveIndex....
So change these lines....
Code:
const v5, 0x3f6e147b
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->refractiveIndex:F
...to this....
Code:
const/4 v5, 0x1
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->refractiveIndex:F
Next we remove the overlay by changing these lines....
Code:
const/high16 v5, 0x3f80
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->alphaRatio1:F
...to this....
Code:
const/4 v5, 0x0
iput v5, p0, Lcom/android/internal/policy/impl/keyguard/sec/CircleUnlockRippleRenderer;->alphaRatio1:F
Thats it. Simple and effective. Heres some screenshots.
Before...
After...
Before....
After....
Enjoy
Click to expand...
Click to collapse
i think if you could use transparent wallpaper on lock screen you would not had this problem am i write?
vazovskiiii said:
i think if you could use transparent wallpaper on lock screen you would not had this problem am i write?
Click to expand...
Click to collapse
No. You would still have this even if you could use transparent wallpaper. The overlay would still be there. This mod makes that overlay transparent.
P.s please edit your post to remove the quote of the entire OP
Sent from my GT-I9305 using Tapatalk 4
Thanks my friend Goldieking! :good:
regards
Nice to see you here goldie
Wish you best of luck
Sent from my GT-I9500 using XDA Premium 4 mobile app
» Arrow « said:
Thanks my friend Goldieking! :good:
regards
Click to expand...
Click to collapse
will u include this to ur new update arrow friend ?
Nice job old friend.
A flashable zip would be amazing.
would need every policy out there this is more for devs/people who want to learn to put in there roms
Yea a flashable zip would be awesome
Sent from my GT-I9500 using xda app-developers app
naset said:
Yea a flashable zip would be awesome
Sent from my GT-I9500 using xda app-developers app
Click to expand...
Click to collapse
Best recommend the thread to your rom chefs then so they include it.
Sent from my GT-I9305 using Tapatalk
Goldie said:
Best recommend the thread to your rom chefs then so they include it.
Sent from my GT-I9305 using Tapatalk
Click to expand...
Click to collapse
Are you bringing this to KK 4.4.2? that would be sweet.
Related
Hi all,
Since I'm new to the forum and can't really post on the development section, I've decided to share here my experience in the hope that it answers a few questions regarding this thread[1].
I've flashed with Odin the Value Pack (Czech, don't ask me why) on my terminal and it went without issues. Yes it was the first time, but it went through based on information I gathered around through Google.
Regarding the new features, I find facial recognition a cool thing to show friends, but not really something I would like to default to in normal day-to-day usage. There's a few cool new icons, the accessibility/camera options are there (no testing) and the ROM is quite polished.
In my humble opinion, my expectations were higher than the satisfaction so I feel a bit defrauded. This doesn't really replace ICS and consumers won't like it. Samsung brought shame into the game. Just the hassle of having all the Samsung stuff back on my terminal doesn't pay off for the 'Value Pack'. My gratiture to those who made available so we can check it up before it's released by my lame operator (that alongside with a few others could try to push Samsung to release ICS). I need to confirm but the battery does seem to deploy a bit faster...
I rest my hopes now on Cyanogen, and those brave people have really my gratitude.
The install of the Value pack through Odin3 was quite easy, even for a first timer.
[1] - http://forum.xda-developers.com/showthread.php?t=1570726
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
same here, long time registered but never had the time to post.
thanks for the link i'll check it out when i get home, by the way what ROM are you currently using?
Wait...the Value Pack is already out?!
@ketheriel: Can you send me the name of your grey widget in top of your screenshot??
Go Power Master... Not sure but I have my reasons to suspect this widget drains a lot of battery.
Sent from my GT-I8150 using XDA
Excuse me, an off-topic question : what date/tie/status widget are you showing in your home?
Thank you!
Edit: Sorry, I didn't read the above posts!
just courious with XXLM6 rom, then I decompile Mms.apk,
found a strange user-agent profile on res/xml/mms_config.xml: Ln 14 & 15
Code:
<string name="uaProfUrl">\h\t\t\p://wap.\samsungmobile.\com\/uaprof\/GT-I9100.\xml</string>
<string name="userAgent">SAMSUNG-GT-I9100-Mms</string>
why they use GT-I9100 mms user-agent?
also found some variable that related with word "theme".
eg: on services.jar/com/android/server/am/ActivityManagerService.smali: Ln 58273
Code:
new-instance v11, Landroid/content/Intent;
[B] const-string v4, "samsung.theme_package_changed"[/B]
invoke-direct {v11, v4}, Landroid/content/Intent;-><init>(Ljava/lang/String;)V
on framework.jar/android/app/StatusBarManager.smali
Code:
.method public updateTheme()V
.locals 2
.prologue
.line 184
:try_start_0
iget-object v1, p0, Landroid/app/StatusBarManager;->mService:Lcom/android/internal/statusbar/IStatusBarService;
invoke-interface {v1}, Lcom/android/internal/statusbar/IStatusBarService;->updateTheme()V
:try_end_0
.catch Landroid/os/RemoteException; {:try_start_0 .. :try_end_0} :catch_0
.line 189
return-void
.line 185
:catch_0
move-exception v1
move-object v0, v1
.line 187
.local v0, ex:Landroid/os/RemoteException;
new-instance v1, Ljava/lang/RuntimeException;
invoke-direct {v1, v0}, Ljava/lang/RuntimeException;-><init>(Ljava/lang/Throwable;)V
throw v1
.end method
not only services.jar, a word "theme" related also found at framework.jar and probabbly at other place.
is they really put theming features on XXLM6 rom ?
it's strange
Thanks... very nice!
I think XXLM6 is possible to theming.
I was trying to add Skins to Settings> Screen Display menu (Settings/res/xml/screen_display.xml) :
Code:
<PreferenceScreen android:title="@string/set_theme" android:key="set_theme" android:summary="">
<intent android:targetPackage="com.android.settings" android:action="android.intent.action.MAIN" android:targetClass="com.android.settings.ThemePicker3D" />
</PreferenceScreen>
also add set_theme_settings.xml to Settings/res/value/ :
Code:
<?xml version="1.0" encoding="utf-8"?>
<PreferenceScreen android:title="@string/set_theme" android:key="set_theme" android:summary=""
xmlns:android="http://schemas.android.com/apk/res/android">
<intent android:targetPackage="com.android.settings" android:action="android.intent.action.MAIN" android:targetClass="com.android.settings.ThemePicker3D" />
</PreferenceScreen>
its success add theme menu, but don't know to put customized theme.
any developer interested on it?
I've managed to 'unlock' screen mode on our US Galaxy S IIIs. However, it doesn't currently change anything, at least from what I can tell.
I'm not sure if we're missing some libs from the international model or what, but if anyone wants to download an international ROM and help figure out what's making it not work, I'd appreciate the help!
I'm attaching a flashable zip as well as instructions on how to enable this yourself.
How-to for devs:
Decompile SecSettings.apk OR extract classes.dex and decompile that.
Navigate to \com\android\settings\DisplaySettings.smali
LOOK FOR:
Code:
const-string v6, "mode"
invoke-virtual {p0, v6}, Lcom/android/settings/DisplaySettings;->findPreference(Ljava/lang/CharSequence;)Landroid/preference/Preference;
REMOVE BELOW:
Code:
invoke-virtual {v7, v6}, Landroid/preference/PreferenceScreen;->removePreference(Landroid/preference/Preference;)Z
SIDE NOTE:
You can also change the invoke-virtual from v7, v6 to v6, v9 and it will still work. However, it will make the "auto adjust screen tone" no longer appear. The key to making screen mode work will more than likely be in this file, or missing libs. Maybe.
Recompile SecSettings or classes.dex and push to phone.
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
Awesome freeza, will download stock international when I go to Wegmans lol! No WiFi at my apartment
So nothing FC's? Just doesn't change anything?
Did you post the instructions? Or have you not had time to do it yet? I didnt see it in the zip file.
fergie716 said:
Awesome freeza, will download stock international when I go to Wegmans lol! No WiFi at my apartment
So nothing FC's? Just doesn't change anything?
Click to expand...
Click to collapse
Yeah. pretty much. At first I had FCs but I solved them, now it just doesn't change anything. It doesn't even show a preview of how it would look if you tapped on one of the options.
I'm assuming either libs are missing, or maybe I just didn't do something right in smali. At any rate, at least I want to narrow down if libs are the issue so I can continue or not.
Thanks for the help, it is much appreciated
Didact74 said:
Did you post the instructions? Or have you not had time to do it yet? I didnt see it in the zip file.
Click to expand...
Click to collapse
Instructions will be in the OP in about 5 minutes.
Cool, nice work freeza!
freeza said:
Yeah. pretty much. At first I had FCs but I solved them, now it just doesn't change anything. It doesn't even show a preview of how it would look if you tapped on one of the options.
I'm assuming either libs are missing, or maybe I just didn't do something right in smali. At any rate, at least I want to narrow down if libs are the issue so I can continue or not.
Thanks for the help, it is much appreciated
Instructions will be in the OP in about 5 minutes.
Click to expand...
Click to collapse
Thanks! Will check it out man
Here is a video going through the various screen modes. I hope it's not HW dependent and it's just a lib issue
http://www.youtube.com/watch?v=0zDlaax-boY
instead of "REMOVE" do you mean "Change to"?
I cant find that second line of code in my DisplaySettings.smali
Didact74 said:
instead of "REMOVE" do you mean "Change to"?
I cant find that second line of code in my DisplaySettings.smali
Click to expand...
Click to collapse
I should have clarified. The line you wanna remove is slightly below what you look for in the beginning.
Hey freeza, here is the SecSettings.apk from the stock ICS International version
Going over the libs now
Ok so does it work just by flashing ?
Sent from my SPH-L710 using Tapatalk 2
Upstreammiami said:
Ok so does it work just by flashing ?
Sent from my SPH-L710 using Tapatalk 2
Click to expand...
Click to collapse
The options appear and you're able to change them, but nothing happens, as of yet.
freeza said:
The options appear and you're able to change them, but nothing happens, as of yet.
Click to expand...
Click to collapse
On cool thanks there's always hope lol
Sent from my SPH-L710 using Tapatalk 2
Here are all of the libs that are in the International version but are not in the Sprint version
I can upload all the libs that differentiate between the two models if you want
freeza said:
Click to expand...
Click to collapse
I dont want to get off track of this thread but i noticed you have the CRT Animation toggle in your settings. Any chace when you get time you could post up a how-to for that mod?
Thanks Freeza
Didact74 said:
I dont want to get off track of this thread but i noticed you have the CRT Animation toggle in your settings. Any chace when you get time you could post up a how-to for that mod?
Thanks Freeza
Click to expand...
Click to collapse
Haha you noticed! That's a work in progress but once it's complete i will most definitely post
freeza said:
Haha you noticed! That's a work in progress but once it's complete i will most definitely post
Click to expand...
Click to collapse
Tease!
Dup post.....sorry.
Dup Post...sorry
Can't wait for you to incorporate this into your rom!
Devices:
Samsung Galaxy S3
Asus Transformer
Motorola DroidX
Motorola Droid Bionic
Motorola Droid 1
Motorola Cliq
Please Visit www.teendroid.com
You sir are doing great work over here, I am glad you picked up an S3. So much contributed to this phone already, Thanks a lot!
Here goes another mod: this will increase your max recipient count to 200, and raise the limit of sms per hour to 1000.
NOTE: Not all steps may be required, but I did them anyway. If you see something or try this method missing steps and it works, please reply back and let me know.
First, I want to say that the reason people are having FC when selecting more than two recipients is the way the apk is decompiled/recmopiled. If you don't do it a certain way, it will FC when adding more than two recipients. I'll save that for another tutorial because this only requires editing smali.
First you want to decompile classes.dex and do the following:
Part one - increasing recipient limit
Step 1.
Navigate to and open \com\android\mms\MmsConfig.smali
Look for:
Code:
sput-boolean v1, Lcom/android/mms/MmsConfig;->mEnablePickContactLimit:Z
Change the sput-boolean from v1 to v0
Step 2.
Look for:
Code:
.method public static setRecipientLimit(I)
Remove below:
Code:
sput p0, Lcom/android/mms/MmsConfig;->mRecipientLimit:I
Step 3.
Look for:
Code:
.method public static getRecipientLimit()I
Remove below:
Code:
sget v0, Lcom/android/mms/MmsConfig;->mRecipientLimit:I
Step 4.
Look for:
Code:
.method public static getEnablePickContactLimit()Z
Remove below:
Code:
sget-boolean v0, Lcom/android/mms/MmsConfig;->mEnablePickContactLimit:Z
Save and close this file.
Step 5.
Next, navigate to and open \com\android\mms\ui\ComposeMessageFragment.smali
Look for:
Code:
.method public static getPickContactLimit()I
This may be responsible for the 200 limit as well, since 0xc8 = 200. Removing this does nothing for the 200 limit. But changing this to a higher number may increase the limit even more. I haven't bothered to find out. Report back any findings.
Remove below:
Code:
const/16 v0, 0xc8
Save and close this file.
Part two - Increasing SMS hour limit
Step 1.
Navigate and open \com\android\mms\util\RateController.smali
Look for:
Code:
.field private static final RATE_LIMIT:I = 0x64
This value is in hexadecimal format, so we see that 0x64 = 100. So, to increase this to 1000 simply change 0x64 to 0x3e8
Save and close this file.
Recompile your classes.dex and replace the one in your SecMms.apk.
NOTE: There may be more to removing this limit, but since I don't send that many messages to test it out, someone else will have to
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
awesome job like always
You
Are
A god!!!!
XDA Moderator
Every time I turn around there's a new mod from you
I got your uncompressed mod working perfectly. Its just too bad I don't have enough contacts/friends to warrant flashing this mod in recovery. 200? Howz about 8?
Do you ever stop?.... lol.
Sent from my SPH-L710 using xda app-developers app
Okay, can someone let me know if all is well?
Messeging doesn't work for me at all now
Sent from my SPH-L710 using xda app-developers app
ClevelandWheeler said:
Messeging doesn't work for me at all now
Sent from my SPH-L710 using xda app-developers app
Click to expand...
Click to collapse
Hm....okay hold please!
Thanks for your contribution .
Okay, I went ahead and just wrote the tutorial.
Awesome my friend! You are like half my ROM with all your mods! The community thanks you!
how about for aosp messaging apk
not a fan of touchwiz
i followed the old thread in general to no avail.
I can't find com folder
stas333 said:
I can't find com folder
Click to expand...
Click to collapse
How did you decompile your classes.dex
Sent from my SPH-L710 using xda app-developers app
Deleted. Because I can't refresh fast enough.
Sent from my SPH-L710 using xda premium
Can you upload a zip with this MOD? It works well in your own ROM.
Sent from my SPH-L710 using xda premium
Is there a zip from this?
Sent from my SGNote 3
ubigred said:
Is there a zip from this?
Sent from my SGNote 3
Click to expand...
Click to collapse
No
My ROM: WICKED X
Hi,
I've tried a few things but seem to be falling flat on my face so thought I'd ask for the help of someone with better skills than me!
I'm trying to remove the qaps around the quick toggles and have tried a few things:
Under Dimens in Systemui theres:
<dimen name="quick_settings_cell_gap">4.0dip</dimen>
Bingo!? No... it doesn't make a difference! Well, it didn't when I set it to 0.0
Also, my other idea if you can't remove the gap is to apply a black solid background to the whole of the tile area, I tried adding a black solid background into a few XML's but it made no difference, i.e. super_status_bar.
The idea is I'm going to make my notification bar transparent and I don't like how the transparency can be seen on the quick settings screen, so I want to remove the gap or place all the tiles into a black layout.
Any help or pointers would be appreciated!
EDIT: Within Quick_Settings.xml I've also tried: But it didn't work (in red)
<com.android.systemui.statusbar.phone.QuickSettingsContainerView android:id="@id/quick_settings_container" android:background="#ff000000" android:layout_width="fill_parent" android:layout_height="wrap_content" android:animateLayoutChanges="true" android:columnCount="@integer/quick_settings_num_columns" />
i am NOT sure how much gap you want to remove, but if you like mine i can give you the instruction
NO flashing required its just simple editing in System files
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
Muhammad.Muayad said:
i am NOT sure how much gap you want to remove, but if you like mine i can give you the instruction
NO flashing required its just simple editing in System files
Click to expand...
Click to collapse
Thanks for your offer to help. The bottom one looks like mine does now with the gap around the toggles that I'm trying to remove. its the blackness around the toggles i either want the toggles to be next to each other with no gap or the toggles sit on a black layout so the bar when transparent doesn't come through the toggles.
Maybe HTC hard coded in the border cos I would have thought the xml edit for tile gap is the right thing so I might look at aosp to see if that tag exists and I can trace back to see if HTC removed it somewhere.
nickabbott said:
Thanks for your offer to help. The bottom one looks like mine does now with the gap around the toggles that I'm trying to remove. its the blackness around the toggles i either want the toggles to be next to each other with no gap or the toggles sit on a black layout so the bar when transparent doesn't come through the toggles.
Maybe HTC hard coded in the border cos I would have thought the xml edit for tile gap is the right thing so I might look at aosp to see if that tag exists and I can trace back to see if HTC removed it somewhere.
Click to expand...
Click to collapse
or we can replace the .PNG with a bigger one and hopefully get a bigger button
you can even take a look at TrickDroid ROM it has a different kind of toggles, (Without waste of space)
I've been doing some more digging and have been looking at the following:
https://android.googlesource.com/pl...atusbar/phone/QuickSettingsContainerView.java
This defines the number of columns and the gap around the tiles, however, the variable quick_settings_cell_gap is defined in dimens under values but I don't think it's used anywhere by htc. The ID for quick_settings_cell_gap is 0x7f0d003f when decompiling renovate 4.1 and that ID is not used at all.
So, I'm thinking HTC have hard coded it into QuickSettingsContainerView.java but my smali is bad! So I'm either going to need a crash course (self taught!) or hopefully someone here can help me please! The variable quick_settings_num_columns is defined as const v1, 0x7f0c0009 in smali and there's one other smali variable which is const v1, 0x205000c and I'm guessing this is the float value which is 4.0dip.
So, how can I modify this to be 0.0dip please?!
Maybe I'm completely off base but I'll keep working on it until I get slapped from the girlfriend! :highfive:
nickabbott said:
I've been doing some more digging and have been looking at the following:
https://android.googlesource.com/pl...atusbar/phone/QuickSettingsContainerView.java
This defines the number of columns and the gap around the tiles, however, the variable quick_settings_cell_gap is defined in dimens under values but I don't think it's used anywhere by htc. The ID for quick_settings_cell_gap is 0x7f0d003f when decompiling renovate 4.1 and that ID is not used at all.
So, I'm thinking HTC have hard coded it into QuickSettingsContainerView.java but my smali is bad! So I'm either going to need a crash course (self taught!) or hopefully someone here can help me please! The variable quick_settings_num_columns is defined as const v1, 0x7f0c0009 in smali and there's one other smali variable which is const v1, 0x205000c and I'm guessing this is the float value which is 4.0dip.
So, how can I modify this to be 0.0dip please?!
Maybe I'm completely off base but I'll keep working on it until I get slapped from the girlfriend! :highfive:
Click to expand...
Click to collapse
SORTED! :laugh:
All I had to do was alter the const v1, 0x205000c to a variable that WAS 0.0dip and recompile and it's removed the gaps.
EDIT: After all that I'm not sure I like it with NO gaps, so maybe just 1.0dip gap not 4.0dip gap! Will see.
UPDATE: My main plan all along was to stop the notification bar coming between the quick toggle tiles (when transparent) and I've managed to do that perfectly I think. Removing the gap and then altering the quick_settings_tile_background from a colour in drawables to a shape xml in drawable has given me the attached screenshots
Job well done I think!
I'm looking for a way to set Smooth Motion as the default recording mode when opening the Samsung camera app. The few extra seconds it takes to set end up in missed opportunities, any info where to look.....I decompiled the camera app but see nothing in there that declares default mode. Any help or suggestions welcome.
Thanks.
***EDIT*** Gooooooooaaaaaaaalllllll !!!!
dwitherell has solved this as well as lay out the changes necessary. Make sure to thank him and enjoy the Smooth Motion Default Record Mode
btw I tested dwitherell's apk (nf1 cam) on my nb4 rom and worked fine... (in case anyone is wondering) same method may work with 4.3 but not the posted apk. Grab file from Post #8
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
Bump ! Anyone?
Would like to set smooth motion as default as well.
Bump thread.
It looks like some smali hackery could make this default. You'd need to change two areas I believe within one smali file, and it could possibly work (haven't tried, just took a peek).
/com/sec/android/app/camera/CameraSettings.smali
The notes are based on looking at the NF1 TMo based SamsungCamera2.apk, so be mindful of that - but if I'm on the right track (again, I could definitely NOT be) you want to influence the default behavior of the mRecordingMode:I entry. There are at least two places (that might be it) where you should influence things a bit.
First off, given the static final descriptors up top it looks like RECORDINGMODE_FHD_60FPS:I = 0x4 would be what you want, and it says it needs to be a value of 0x4 (as opposed to the normal setting, which is 0x0).
So the first target is the iput line for mRecordingMode:I in the constructor <init> method.
My suggestion - given how other things are done in the method - would be to change
Code:
iput v1, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
to
Code:
const/4 v0, 0x4
iput v0, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
as the v1 corresponded to 0x0, and v0 is often used as a set-as-the-method-progresses sort of variable.
There is another method that needs attention I would imagine - setSettingValuesAsDefault
Here there is another iput related to mRecordingMode:I - my suggestion for a change would be to alter
Code:
iput v7, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
to
Code:
const/4 v4, 0x4
iput v4, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
as v7 corresponds to 0x0 and v4 is overwritten right after this.
Good luck - hope this at least gets you started on the path to default smooth motion
Thankyou....thankyou.....I will take a look into that.
I really appreciate your post, thanks for taking the time !!!
dwitherell said:
It looks like some smali hackery could make this default. You'd need to change two areas I believe within one smali file, and it could possibly work (haven't tried, just took a peek).
/com/sec/android/app/camera/CameraSettings.smali
The notes are based on looking at the NF1 TMo based SamsungCamera2.apk, so be mindful of that - but if I'm on the right track (again, I could definitely NOT be) you want to influence the default behavior of the mRecordingMode:I entry. There are at least two places (that might be it) where you should influence things a bit.
First off, given the static final descriptors up top it looks like RECORDINGMODE_FHD_60FPS:I = 0x4 would be what you want, and it says it needs to be a value of 0x4 (as opposed to the normal setting, which is 0x0).
So the first target is the iput line for mRecordingMode:I in the constructor method.
My suggestion - given how other things are done in the method - would be to change
Code:
iput v1, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
to
Code:
const/4 v0, 0x4
iput v0, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
as the v1 corresponded to 0x0, and v0 is often used as a set-as-the-method-progresses sort of variable.
There is another method that needs attention I would imagine - setSettingValuesAsDefault
Here there is another iput related to mRecordingMode:I - my suggestion for a change would be to alter
Code:
iput v7, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
to
Code:
const/4 v4, 0x4
iput v4, p0, Lcom/sec/android/app/camera/CameraSettings;->mRecordingMode:I
as v7 corresponds to 0x0 and v4 is overwritten right after this.
Good luck - hope this at least gets you started on the path to default smooth motion
Click to expand...
Click to collapse
Gave it a shot, however camera app just force closes when trying to start now...Thanks again for getting me this far, I'll look around more in the smali.....any other tips would be greatly appreciated. Thanks
Btw....this is my first attempt a smali edits.....so I may have missed something....
louforgiveno said:
Gave it a shot, however camera app just force closes when trying to start now...Thanks again for getting me this far, I'll look around more in the smali.....any other tips would be greatly appreciated. Thanks
Btw....this is my first attempt a smali edits.....so I may have missed something....
Click to expand...
Click to collapse
Well if my post misled but got you tinkering, then I'd say it did well
I'll look into it and see if I can give tested specifics - this post was me just taking a peek and outlining how I would start the process, with the obvious hope that it would get you all the way there. I'll see what I can scrape up
I took a crack at actually doing the mod - it seems like it went as expected. Perhaps something went awry either in the recompile process or perhaps in the flash/pushing of the updated apk process? @louforgiveno Feel free to PM me if you want to trouble shoot the process you went through to test it out. You can also use the flashable below as a "base" of sorts for flashing things if you would like - just drop what you want to test in to the framework/app/priv-app folders
Regardless - here is that flashable. Let me know if it worked for you or not. It's based on the stock NF1 SamsungCamera2.apk and has no other mods added to it outside of the set-smooth-motion-as-default one
Default SmoothMotion NF1 SamsungCamera2.apk
dwitherell said:
I took a crack at actually doing the mod - it seems like it went as expected. Perhaps something went awry either in the recompile process or perhaps in the flash/pushing of the updated apk process? @louforgiveno Feel free to PM me if you want to trouble shoot the process you went through to test it out. You can also use the flashable below as a "base" of sorts for flashing things if you would like - just drop what you want to test in to the framework/app/priv-app folders
Regardless - here is that flashable. Let me know if it worked for you or not. It's based on the stock NF1 SamsungCamera2.apk and has no other mods added to it outside of the set-smooth-motion-as-default one
Default SmoothMotion NF1 SamsungCamera2.apk
Click to expand...
Click to collapse
NICE ! Gonna half to take a look and see if I can find what part of the process failed me. Thanks for showing me it can be done, now to learn something new :good:
I'll be pm'ing ya for sure ! You made my day btw.
louforgiveno said:
NICE ! Gonna half to take a look and see if I can find what part of the process failed me. Thanks for showing me it can be done, now to learn something new :good:
I'll be pm'ing ya for sure ! You made my day btw.
Click to expand...
Click to collapse
@dwitherell, You f*#*ing Rock !! Found my error and got my edit to work! Compression level was culprit. ...duh! Lol...thanks for teaching me something!
http://forum.xda-developers.com/showthread.php?t=2824801
2 choices.....stock bitrate & modded high bitrate apks