Develop Bugs

Magisk Install Issue - /system could not be mounted

Hey,
I unlocked and rooted my Pixel XL today using the guide below. I installed TWRP properly by fastbooting to TWRP first, and then flashing the .zip. I then rebooted back into recovery and tried to flash Magisk 10.2 and i get this error.
Failed: /system could not be mounted!
Updater process ended with ERROR: 1
Error installing zip file '/sdcard/Magisk-v10.z.zip'
Does anyone know why this would happen? I was able to flash the SU zip without any issues at all. I want to use Magisk so i can hide certain apps from root. Did i do something wrong or is this not supported?
https://forum.xda-developers.com/pixel-xl/how-to/guide-how-to-unlock-root-flash-pixel-xl-t3507886

Not working on the pixels yet

aholeinthewor1d said:
Not working on the pixels yet
Click to expand...
Click to collapse
I guess that's a good reason Thanks!

Switching partitions in fastboot? Trying to remove root so I can log into snapchat

I read in another thread that I need to 'Just reflash the original boot.img on both a and b to unroot. Log in and then reroot'...how do I do this? I can flash boot.img via fastboot no problem...but how do I switch partitions? Also, this method doesn't result any data loss correct? Was going to do the 'full unroot' option in SuperSU but with the partitions stuff I'm not sure if that will work?
I'm running TWRP RC2 and SuperSU SR3 2.79. Phone is fully setup and functioning other than Snapchat. Went to bed at 5am after taking hours to log into all my apps, configure them again, etc....would HATE to do all that over again...so much that I would stop using Snapchat to avoid it.
Any help would be appreciated.

@blueyes, I saw you help another member out with something similar but not quite...any idea?

You can simply use the in app option it works just fine. Alternatively you can install Magisk without wiping to keep root and bypass Safteynet (will allow you to use Snapchat, Android Pay, etc..) I was running a nearly identical setup to you when I did it. Here's some instructions if you want to try that route https://forum.xda-developers.com/showpost.php?p=71629390&postcount=2394

tdct12 said:
You can simply use the in app option it works just fine. Alternatively you can install Magisk without wiping to keep root and bypass Safteynet (will allow you to use Snapchat, Android Pay, etc..) I was running a nearly identical setup to you when I did it. Here's some instructions if you want to try that route https://forum.xda-developers.com/showpost.php?p=71629390&postcount=2394
Click to expand...
Click to collapse
That certainly sounds better as it will give me the perk of being able to finally use Android Pay. I'll investigate, but worst case I'll do the in-app solution and do the old method of logging in to Snapchat and then re-rooting. Thank you!

tdct12 said:
Quoted from another thread. Anyway I tried it out. Already had Pure Nexus, superuser, twrp RC2, and elementalx installed. Magisk fully working. Here are the steps I followed (no wipe)
Open SuperSu
Uninstall supersu from in app option
Reboot system
Reboot recovery
Flash Magisk zip
Wipe cache/davlik cache
Reboot system (creates bootloop back to recovery)
From twrp switch bootloader slot to the inactive slot
reboot recovery
From twrp switch back to the orignal boot slot
reboot system (these steps end the bootloop for some reason)
You might need to force close your root check app and reopen for it to detect root at first.
edit: Saftey net passed, just checked =)
Click to expand...
Click to collapse
So...I had different results.
When I remove SuperSU from in-app option, my phone was still rooted. It didn't actually unroot. Is that because I told it to not flash the boot.img?
#7 didn't result in a boot loop...proceeding on...

@IlyaKol you do need to let it reflash the original boot.img. Supersu modifies it to achieve root. Magisk is it's own root you probably shouldn't have flashed it until you verified that supersu had been removed. You can still try removing supersu from in app option I have no idea if it will effect magiskSu. After you remove supersu go the Magisk app (the zip installed it) and see if it's still rooted. If not just try reflashing the zip. All you can do is hope it works out. Once it's installed properly you go the app and enable Magisk Hide, there is a Safteynet test in status page along with root status, I will post a screenshot for clarity

tdct12 said:
@IlyaKol you do need to let it reflash the original boot.img. Supersu modifies it to achieve root. Magisk is it's own root you probably shouldn't have flashed it until you verified that supersu had been removed. You can still try removing supersu from in app option I have no idea if it will effect magiskSu. After you remove supersu go the Magisk app (the zip installed it) and see if it's still rooted. If not just try reflashing the zip. All you can do is hope it works out. Once it's installed properly you go the app and enable Magisk Hide, there is a Safteynet test in status page along with root status, I will post a screenshot for clarity
Click to expand...
Click to collapse
Okay, I'm going back to recovery, will flash the Magisk Uninstaller followed by the SuperSU installer. Then I'll go into the app and this time tell it to restore the boot image but NOT the recovery. Right? lol.
That didn't work so I'm trying other methods to remove SuperSU...I'll report back later as I need to get going and will be doing this elsewhere lol.

@IlyaKol rather than reflashing supersu since the root is not removed you should instead just downloaded the supersu apo from the playstore then try removing the supersu root from there. If you get an "error no SuperSU binaries detected" then it is already removed.

tdct12 said:
@IlyaKol rather than reflashing supersu since the root is not removed you should instead just downloaded the supersu apo from the playstore then try removing the supersu root from there. If you get an "error no SuperSU binaries detected" then it is already removed.
Click to expand...
Click to collapse
It's still there even after running other tools found on XDA to try and unroot. I'll just flash the boot image manually when I get back home. Magisk sees it as such, not the Magisk root.
Thanks for the other steps...only remaining question I have is do I need to flash the boot image to both partitions? Or is whatever fastboot defaults to enough? If I do, what's the fastboot command for that?

If you use fastboot make sure it's on your current slot. I can't imagine why the unroot wouldn't work. Did you try clearing app data on your root checking app? Did the actual supersu app from play store detect supersu binaries? You might run into some data loss trying to remove root honestly if no methods are working. If all else fails do a wipe and then just install magisk when you've reinstalled the rom of your choice. I know it's not a pleasant solution but it's a solid last resort.

Eh, @tdct12, I finally caved and just ran flash-all.bat to get back to 100% stock. Third time redoing my entire phone (copying all the data back down such as pictures/videos, music, etc. and logging into each app and signing in, etc.). First time I forgot to unlock the bootloader first, so I had to wipe (DOH!), 2nd time was I didn't log into Snapchat before rooting (DOH^2) and now this is the 3rd time. #thirdtimesacharm
Yesterday (round 2) I finished at 4:45am. It's 1:13am now...so let's see how long the third time takes lol.
This time I added unlocked the BL, flashed TWRP RC2/Magisk 11.6 (from your quote)/ElementalX 1.09 right from the beginning lol. Taking no chances.

Sweet, I hope it works for you this time around!

tdct12 said:
Sweet, I hope it works for you this time around!
Click to expand...
Click to collapse
So far so good. Magisk detected proper root and passed safetynet, allowing Snapchat to login. So I'm golden. Thanks again for the rest of the steps, etc.! Have a good one!

IlyaKol said:
So far so good. Magisk detected proper root and passed safetynet, allowing Snapchat to login. So I'm golden. Thanks again for the rest of the steps, etc.! Have a good one!
Click to expand...
Click to collapse
Glad it worked for you. Would you mind posting your steps on how to get it working. I have been having issues with Magisk passing the safety check. I have flashed to 100% stock as well. I'm also using Pure Nexus if there is something different I have to do since I'm running that. Thanks!
Edit: I have followed the steps listed above after flashing Pure Nexus and it still will not pass safety check.

IlyaKol said:
@blueyes, I saw you help another member out with something similar but not quite...any idea?
Click to expand...
Click to collapse
Are you referring to "fastboot --set-active" a(or b) CMD. Run just fastboot and you'll see the available commands. After switching slots reboot bootloader to assure that you are in the opposite slot.
There's more commands available with fastboot oem... To see those (in Linux, i don't use Windows) pull your aboot.img and run "strings aboot.img | grep oem

GallardosEggrollShop said:
Glad it worked for you. Would you mind posting your steps on how to get it working. I have been having issues with Magisk passing the safety check. I have flashed to 100% stock as well. I'm also using Pure Nexus if there is something different I have to do since I'm running that. Thanks!
Edit: I have followed the steps listed above after flashing Pure Nexus and it still will not pass safety check.
Click to expand...
Click to collapse
Basically, the gist of what I did after I gave up and accepted the fact that I'd have to go back to 100% stock and rebuild my setup again:
1) Flash to 100% stock using Flash-All.bat from the Factory Image (using ADB/Fastboot tools)
2) Boot into the OS
3) Next I enabled developer options, allowed USB debugging and allowed for the bootloader to be unlocked
4) Plugged the phone into the PC, accepted the ADB fingerprint
5) Opened the platform-tools directory in my command window
6) Rebooted to the bootloader via 'adb reboot bootloader' command
7) Booted to TWRP using the 'fastboot boot *insert TWRP image name*' command (I used one of the alpha versions)
8) First thing I did in "Temp TWRP" was I flashed TWRP RC2 permanently and rebooted back to recovery
9) I then installed Magisk v11.6 (I did not have to do any of the additional steps to fix any bootloops with changing the boot slot, etc....might be a 7.1.2 thing vs 7.1.1, etc.)
10) *Optional* I flashed ElementalX 1.09 for Pixel
11) Wiped cache/dalvik (cache doesn't seem to wipe because it can't find /cache?)
12) Rebooted to system
13) In the Magisk Manager app, go to Settings and make sure "Enable BusyBox" and "Magisk Hide" are enabled.
14) Run the SafetNet check. It should pass.
DO NOT UPDATE TO v12.0 as I guess it's not ready for Pixel's yet.
blueyes said:
Are you referring to "fastboot --set-active" a(or b) CMD. Run just fastboot and you'll see the available commands. After switching slots reboot bootloader to assure that you are in the opposite slot.
There's more commands available with fastboot oem... To see those (in Linux, i don't use Windows) pull your aboot.img and run "strings aboot.img | grep oem
Click to expand...
Click to collapse
Thanks. I ended up finding the option on how to do that in TWRP and then later fastboot as well...all is well that ends well. Loving my new phone.

How to Root Using SuperSU and TWRP on Oreo OPR6 Official Release

After a bit of trial and error, I managed to find a combination of files and actions that allowed me to successfully root my 64GB Pixel C on 8.0.0 by installing SuperSU via TWRP.
Steps:
Perform a clean installation of the official release, found here
Use the unofficial 3.0.0 TWRP release found in this thread (direct download link here) and boot to recovery ("fastboot boot [TWRP filename].img") - the latest official 3.1.1 TWRP did not work, either via flashing or booting
ADB sideload SuperSU 2.82SR3 found in this thread (direct download link here)
Hope this helps!

Stuck at TWRP after
Flashed the TWRP from the link and side loaded the SuperSU, now my Pixel C is stuck at TWRP on reboot, any idea ?

Jeff Z. said:
Flashed the TWRP from the link and side loaded the SuperSU, now my Pixel C is stuck at TWRP on reboot, any idea ?
Click to expand...
Click to collapse
The only thing I can think of is to reflash the stock recovery using the downloaded factory image. Seems like it was flashed, not simply booted into TWRP.
Sent from my Pixel XL using Tapatalk

MadManMoon said:
The only thing I can think of is to reflash the stock recovery using the downloaded factory image. Seems like it was flashed, not simply booted into TWRP.
Sent from my Pixel XL using Tapatalk
Click to expand...
Click to collapse
Thanks. My problem was my pixel kept booting to TWRP even selecting to boot the system, kind of strange. I think I missed your first step, the pad was OTA updated to 8.0 from 8.0 Beta release. I will try again with flash the factory image of 8.0 first.

Anyone else able to root their pixel c tablet on Oreo with success? I'm thinking about trying it with the original posters guide. Just thought I'd see who else has been able to make this work.

NitroSS said:
Anyone else able to root their pixel c tablet on Oreo with success? I'm thinking about trying it with the original posters guide. Just thought I'd see who else has been able to make this work.
Click to expand...
Click to collapse
Still works for me as of the September 2017 update. About to try it again with the October update.

It's driving me absolutely mad. I just got a brand new Pixel C today. It's updated to the latest Oreo but nothing else has been installed yet. I unlocked the bootloader and copied the SuperSU zip file onto the device via USB file transfer from my PC, then I set up a password. I'm booting (not flashing) TWRP because all I want is root.
When I'm prompted for a password in TWRP I'm told it's invalid. I also tried "default_password" and that's invalid, too. I looked all over for a solution and found a modified TWRP that doesn't prompt for a password but it won't decrypt the internal storage.
I'm really pulling my hair out here. I can't figure out why it's working for some people and not others.

CatThief said:
It's driving me absolutely mad. I just got a brand new Pixel C today. It's updated to the latest Oreo but nothing else has been installed yet. I unlocked the bootloader and copied the SuperSU zip file onto the device via USB file transfer from my PC, then I set up a password. I'm booting (not flashing) TWRP because all I want is root.
When I'm prompted for a password in TWRP I'm told it's invalid. I also tried "default_password" and that's invalid, too. I looked all over for a solution and found a modified TWRP that doesn't prompt for a password but it won't decrypt the internal storage.
I'm really pulling my hair out here. I can't figure out why it's working for some people and not others.
Click to expand...
Click to collapse
Try format userdata, then boot straight into twrp
Command is "fastboot format userdata"
You also have to flash SuperSU while in twrp to stop the tablet from encrypting again.

Huffy1 said:
Try format userdata, then boot straight into twrp
Command is "fastboot format userdata"
You also have to flash SuperSU while in twrp to stop the tablet from encrypting again.
Click to expand...
Click to collapse
I'm confused about "stop the tablet from encrypting again". I know TWRP needs to decrypt the data partition to access it, but are you saying encryption won't be re-enabled when I reboot the system? I had to ask because it sounds strange that installing the SuperSU zip would mess with encryption.

CatThief said:
I'm confused about "stop the tablet from encrypting again". I know TWRP needs to decrypt the data partition to access it, but are you saying encryption won't be re-enabled when I reboot the system? I had to ask because it sounds strange that installing the SuperSU zip would mess with encryption.
Click to expand...
Click to collapse
If everything goes to plan yes.
You can encrypt again if you wish through settings once the tablet is booted up

Huffy1 said:
If everything goes to plan yes.
You can encrypt again if you wish through settings once the tablet is booted up
Click to expand...
Click to collapse
Does this mean when I flash the factory images for the monthly updates and need to root the device again that I'll be wiping all userdata each time?

CatThief said:
Does this mean when I flash the factory images for the monthly updates and need to root the device again that I'll be wiping all userdata each time?
Click to expand...
Click to collapse
No just use flashfire to update and keep root, it won't encrypt the tablet. You can still boot official twrp as well after using flashfire to update as your tablet shouldn't encrypt.

Huffy1 said:
No just use flashfire to update and keep root, it won't encrypt the tablet. You can still boot official twrp as well after using flashfire to update as your tablet shouldn't encrypt.
Click to expand...
Click to collapse
Is removing encryption something everyone is doing, or is it just a workaround for the people who can't get TWRP to work? I never ran into anything like this before.

CatThief said:
Is removing encryption something everyone is doing, or is it just a workaround for the people who can't get TWRP to work? I never ran into anything like this before.
Click to expand...
Click to collapse
Use FDE then and it reportedly works.

Huffy1 said:
Use FDE then and it reportedly works.
Click to expand...
Click to collapse
Just curious though, is this a standard prerequisite for using TWRP and rooting *all* Pixel C devices?

CatThief said:
Just curious though, is this a standard prerequisite for using TWRP and rooting *all* Pixel C devices?
Click to expand...
Click to collapse
Don't know, only telling you what I did cause I had the same problem as you

Well I'm finally rooted. I didn't change the encryption, just tried a different method and after several tries it finally worked. I used adb sideload inside TWRP after canceling the password screen. Odd that it took several tries, though, to get through it without generating errors. We'll see how it goes next month.

I have had a lot of trouble with rooting Oreo...
I started out trying to use Magisk but gave up after many attempts. Every version, and every kernel I tried resulted in booting to recovery and not system. I could have tried the ADB method but I actually want to have TWRP so I didn't try that.
By the time I tried SuperSU my factory image had had an OTA and many apps & files installed so I can't say my system is "clean" but I have Fastboot flashed the stock boot image many (many) times to recover from whatever Magisk does to the kernel. I never looked all that hard for this unofficial TWRP people talk about so I used 3.1.1-1. At some point I converted to File Based Encryption because it is so much nicer to use, and so TWRP cannot decrypt my internal storage, but the workaround is to put zips and images on a USB drive. It also does not ask for a password. So far so good, I have my workarounds. I do also have this weird error where TWRP cannot unmount the system but I can flash kernels without problems. I have chosen to keep system read-only for superstitious reasons. I think it will fail if I look at it funny sometimes lol.
From this state I flashed the latest SuperSU and it booted! So I do have root. I still would like to try Magisk for the modules but it seems this isn't ready. However, my trusty old terminal app hangs at the su command... and several kernels will crash my tablet... so it's "working" but there is more to do. And literally just now I see I have an OTA. lol.

I followed the original instructions and got rooted with the latest version of Oreo. But, TWRP still wouldn't flash correctly without causing boot loops.
I finally got it resolved by using the original instructions, then loading the Official TWRP app from Google Play. I used the app to flash twrp-3.1.1-1-dragon.img.
Everything is working properly now. I have 8.0.0 (OPR1.170623.032, Nov 2017) loaded and rooted, and the Pixel C will boot into TWRP and see the encrypted data.

Is it posible to flash latest Oreo stock factory image https://developers.google.com/android/images ryu-opr1.170623.032-factory-020f1cf9.zip using stock TWRP or do I have to side load it ?
I'm getting a Invalid zip file format error in TWRP when I try and flash it

Update Failed With Magisc, Can't Pass SafteyNet

So last night I installed the November 5, 2017 security patch on my Pixel XL running Google's 8.0.0 ROM. I did have Magisk installed at the time and this is what I did:
Uninstall Magisk from Magisk Manager
Start update and wait for step 2
Go back to Magisk Manager and install in the OTA slot with force encrypt disabled
Reboot
This caused a boot loop, figuring that the Magisk flash was just bad I downloaded "marlin-opr3.170623.013" from Google and flashed the boot image in there. This fixed the bootloop but prevented my phone from passing SafteyNet, and I found that there was an update notification saying that the update failed. I attempted it again and it would not install at all.
So I downloaded the OTA package from Google and flashed as there instructions say.
Still not passing.
I then removed the -w flag from flash-all.bat to keep my data and ran that to flash my device with the factory image.
Still not passing.
What should I do about this? I can not manage to get my phone to pass SaftetyNet and I want to keep all of my data. When I had my Nexus 6p I would just reflash the system stuff with TWRP, but since TWRP does not work that is not an option here. (I also used to use a custom ROM, but don't now because TWRP is broken)

gudenau said:
So last night I installed the November 5, 2017 security patch on my Pixel XL running Google's 8.0.0 ROM. I did have Magisk installed at the time and this is what I did:
Uninstall Magisk from Magisk Manager
Start update and wait for step 2
Go back to Magisk Manager and install in the OTA slot with force encrypt disabled
Reboot
This caused a boot loop, figuring that the Magisk flash was just bad I downloaded "marlin-opr3.170623.013" from Google and flashed the boot image in there. This fixed the bootloop but prevented my phone from passing SafteyNet, and I found that there was an update notification saying that the update failed. I attempted it again and it would not install at all.
So I downloaded the OTA package from Google and flashed as there instructions say.
Still not passing.
I then removed the -w flag from flash-all.bat to keep my data and ran that to flash my device with the factory image.
Still not passing.
What should I do about this? I can not manage to get my phone to pass SaftetyNet and I want to keep all of my data. When I had my Nexus 6p I would just reflash the system stuff with TWRP, but since TWRP does not work that is not an option here. (I also used to use a custom ROM, but don't now because TWRP is broken)
Click to expand...
Click to collapse
It sounds like it's not passing after you flashed the image because you are unlocked. If you want to pass safetynet with an unlocked bootloader, you need to modify the kernel (or use one that is already modified).
Like this one: https://forum.xda-developers.com/pi...rnel-stock-kernel-safetynet-patch-dm-t3684405

mwalt2 said:
It sounds like it's not passing after you flashed the image because you are unlocked. If you want to pass safetynet with an unlocked bootloader, you need to modify the kernel (or use one that is already modified).
Like this one: https://forum.xda-developers.com/pi...rnel-stock-kernel-safetynet-patch-dm-t3684405
Click to expand...
Click to collapse
Strange, I didn't have to use a custom kernel before this patch. I guess Google did something.

gudenau said:
Strange, I didn't have to use a custom kernel before this patch. I guess Google did something.
Click to expand...
Click to collapse
I believe Magisk was hiding it for you. If I understand where you are at now Magisk is gone right?

TonikJDK said:
I believe Magisk was hiding it for you. If I understand where you are at now Magisk is gone right?
Click to expand...
Click to collapse
It passed before without Magisk. The latest update did something.

Roll Back Firmware on Fire HD 8

I performed an update for Magisk and now my Fire HD 8 2018 won't boot. I do have TWRP. I see the OS update images provided by Amazon but there are no installation instructions. Can I install those images through TWRP?

I saw that you should be able to rename the Amazon images to .zip and install through TWRP. I have the 6.3.0.1 image. It fails with "process ended with error: 7"
Does anyone know what's going on?

Figured it out. Wrong OS image. I was able to install 6.3.0.1.zip through TWRP from here:
https://forum.xda-developers.com/showpost.php?p=78893195&postcount=441

kbocek said:
I performed an update for Magisk and now my Fire HD 8 2018 won't boot. I do have TWRP. I see the OS update images provided by Amazon but there are no installation instructions. Can I install those images through TWRP?
Click to expand...
Click to collapse
I have twice had bootloops when updating Magisk though TWRP. I wonder if it is better to also download the latest Magisk uninstaller zip and flash this immediately prior to the Magisk update. It there any log file that would be useful for figuring out what causes bootloops?

MontysEvilTwin said:
I have twice had bootloops when updating Magisk though TWRP. I wonder if it is better to also download the latest Magisk uninstaller zip and flash this immediately prior to the Magisk update. It there any log file that would be useful for figuring out what causes bootloops?
Click to expand...
Click to collapse
I updated from a message in the Magisk app causing the brick. I reread the rooting instructions and it specifically mentioned later versions causing problems. So this time I installed 6.3.0.1 and immediately installed Magisk V.18. It seems to be working well. Hangouts is being slow displaying messages. But everything else is working.

kbocek said:
I updated from a message in the Magisk app causing the brick. I reread the rooting instructions and it specifically mentioned later versions causing problems. So this time I installed 6.3.0.1 and immediately installed Magisk V.18. It seems to be working well. Hangouts is being slow displaying messages. But everything else is working.
Click to expand...
Click to collapse
The later versions should work fine typically.
The real issue is that updating through magisk manager will bootloop the tablet, as magisk is not aware of the exploit. Only flash boot images through TWRP.

Kctucka said:
The later versions should work fine typically.
The real issue is that updating through magisk manager will bootloop the tablet, as magisk is not aware of the exploit. Only flash boot images through TWRP.
Click to expand...
Click to collapse
I have had two bootloops flashing updated versions of the Magisk zip through TWRP. Reflashing the OS 6.3.0.1 update followed by the Magisk zip fixed the bootloops both times.
Edit. Strictly speaking, my terminology is a bit lax. I did not get bootloops since the boot process on both occasions got to the Fire logo, but no further.

MontysEvilTwin said:
I have had two bootloops flashing updated versions of the Magisk zip through TWRP. Reflashing the OS 6.3.0.1 update followed by the Magisk zip fixed the bootloops both times.
Edit. Strictly speaking, my terminology is a bit lax. I did not get bootloops since the boot process on both occasions got to the Fire logo, but no further.
Click to expand...
Click to collapse
In OPs case, it was definitely updating through manager.
But still, that's odd, I wonder what causes that. I only have Magisk on the HD 10, but it's running 19.3. Must have to do with Nougat then?
And yeah, I use those terms pretty interchangeably myself, the general point is understood.