Does Xiaomi open source their camera blobs? - Xiaomi Redmi Note 5 Pro Questions & Answers

So normally when using Lineage OS any AOSP anything not Stock from the OEM we lose the camera binary, drivers blobs as their closed source. The camera quality then becomes bad, so is it open source for the redmi note 5? and do Xiaomi do that for any of their phones?
I no google camera ports and probably miui stock camera ports look good on AOSP, Lineage OS assuming that's more to do with camera2 api and software optimisations that they come out looking good.
With closed source camera drivers, it's more a issue all independent apps will look a lot worse while taking photos or video calls and other type of things, that can't simply be addressed by sending a photo to an app manually.
Thanks.

Related

Camera2-API fixed for 3rd-party camera apps or not?

Dear owners of an OnePlus 5T and maybe 5 too,
please grant me an answer to a really important question: Is the Camera2-API bug fixed for the OP5T or is it still valid and OnePlus didn't do anything against it?
Please do following:
Download Open Camera > Go to settings > Scroll down > Switch on Camera2-API > Cover the rear camera with your hand > Read the values at the very top of your screen:
• If ISO 799 and 1/16,7 is still here: Nothing was fixed. Please leave a reply.
• If values differ from those values (ISO 799 1/16,7) OnePlus finally fixed the Camera2 API. Please also leave a reply.
Thanks in advance.
MickyFoley said:
Dear owners of an OnePlus 5T and maybe 5 too,
please grant me an answer to a really important question: Is the Camera2-API bug fixed for the OP5T or is it still valid and OnePlus didn't do anything against it?
Please do following:
Download Open Camera > Go to settings > Scroll down > Switch on Camera2-API > Cover the rear camera with your hand > Read the values at the very top of your screen:
• If ISO 799 and 1/16,7 is still here: Nothing was fixed. Please leave a reply.
• If values differ from those values (ISO 799 1/16,7) OnePlus finally fixed the Camera2 API. Please also leave a reply.
Thanks in advance.
Click to expand...
Click to collapse
Glad I could help.
ISO 9600 and 1/16,7s
so what does this mean now exactly?!
what are the advantages, what can be accomplished? the Google Cam HDR still doesn't seem to work correctly on the 5t.
@vercetti: The reason why I'm asking it: There are several good, real camera apps out, taking advantage of the Camera2 API. I still have the 3T and OnePlus didn't fix the Camera2 API implementation for us. Neither with Oreo. With the correct implementation (thanks for the confirmation @Wilux), Open Camera, Footej Camera, A Better Camera, etc. will work correctly and a Google Camera port is more likely than with a bugged implementation of the API - like for the 3 and 3T.
OnePlus 5 also shows ISO 9600 and 1/16,7s (latest stock rom)
MickyFoley said:
@vercetti: The reason why I'm asking it: There are several good, real camera apps out, taking advantage of the Camera2 API. I still have the 3T and OnePlus didn't fix the Camera2 API implementation for us. Neither with Oreo. With the correct implementation (thanks for the confirmation @Wilux), Open Camera, Footej Camera, A Better Camera, etc. will work correctly and a Google Camera port is more likely than with a bugged implementation of the API - like for the 3 and 3T.
Click to expand...
Click to collapse
This means pictures will be lot better then on original camera app?
Would like to see some comparison from OP5t camera and OpenCamera. I still thinking to buy this great piece of tech, but its all about camera what I am focused about. Google phones not available in my country (officialy), Im getting sick over Samsungs (got them for 3 years now, too much!) as all what is good on Sammies is camera. Want to move from my s7e as there was no good flagship, but OP5t is perfect, if at least have same quality of pictures/videos as its on s7e, even if that means using 3rd party app.
@droidhd: This means, the device is theoretically able to do better images via the correct working Camera2 API. Mostly, images will be bad because of post-processing. And if you shoot RAW, mostly the hardware and the correct implemented API is significant for good photos. Maybe you'll see more grain. Maybe the colors aren't the same like you do with the standard camera app. But I'd say: Yes, they get better with more advanced camera apps.
My list of professional camera apps (No need for social media crap like filters, effects, etc.):
Open Camera: https://play.google.com/store/apps/details?id=net.sourceforge.opencamera (Simply a great piece of software!)
Snap Camera HDR (Beta): https://play.google.com/store/apps/details?id=com.marginz.snap (Looks like abandoned. Last update 1 year ago)
Manual Camera: https://play.google.com/store/apps/details?id=pl.vipek.camera2
A Better Camera Unlocked: https://play.google.com/store/apps/details?id=com.almalence.opencam_plus (Looks abandoned, but will get updates from time to time. Unsteady, but alive)
Camera FV-5 (Beta): https://play.google.com/store/apps/details?id=com.flavionet.android.camera.pro
ProShot: https://play.google.com/store/apps/details?id=com.riseupgames.proshot2
Footej Camera: https://play.google.com/store/apps/details?id=com.footej.camera
Sadly, only one for video left:
FiLMiC Pro: https://play.google.com/store/apps/developer?id=FiLMiC+Inc. (Please try Evaluator first!)
Cinema FV-5: https://play.google.com/store/apps/details?id=com.flavionet.android.cinema.pro (Seems abandoned. Last update 2 years ago)
The list isn't very long, I know. Feel free to extend it. But please: No filters, no effects, no social media like things. Those are around in thousands and nothing professional in it!
Micky, could you explain to me why it is common knowledge that picture quality is usually best when the stock rom with the stock cam is used compared to any photography app running on custom roms?
I've read in so many threads, posts... that people went back to the stock rom just because pic quality is higher than on custom rom.
is this history when camera2 API works correctly? meaning that images are identical when using open camera on stock vs opencam on custom rom? or would opencam (or any other photo app) still produce images of lesser quality when used on a custom rom?
People went back, because of the abstraction layer and because drivers are still closed source. I'd like to compare it a bit:
If you setup a new computer, you only have standard drivers for each and everything. You can use it, but only if you install the correct drivers, things get to start working like they should. Like your graphics card: Working, but you'll notice some kind of stuttering/tearing when scrolling in your browser on certain websites. If you install the driver for your card: All is smooth, like it should.
So we can say: Drivers in AOSP are more like standard. Not all functions, more workarounds, but working OK. And drivers directly from stock (OEM) will get all functions to work good and smooth (if they're implemented correctly).
But you can see, that it's possible to get great photos out of your device with mods for Google Camera even on AOSP-ROMs. Because this mod brings itself some "magic". So you see: Closed source vs. open source. If we'd have the full code of the drivers: Photos, produced by the standard camera app of every OEM would probably look like crap.
OnePlus once promised to get us at least the camera blobs, but they didn't. They say: "Too hard!". Lie, because they know, that their already scratched images would suffer more than now, because Devs like sultanxda would have kicked their butts out of the universe by producing better photos than the stock camera app.
Thx for the answer Micky, i like the comparison with the computer and missing drivers, you made it much clearer now!
But 2 questions still remain:
1.) Does a 3rd party photo app (like Open Camera or any other one) lead to the exact the same picture quality if installed on a stock rom as compared to being used on a custom rom? Or will a 3rd party app still be better on the stock rom than on a custom rom because of the drivers you explained before?
And 2.) does this whole camera2 API aspect change what you explained about the driver situation? Meaning, that there is no need anymore for the drivers that can only be found in a stock rom because camera2 API gets to use the whole potential of the camera hardware?
Just trying to figure out where the best image quality can be found. The whole thing is too confusing to me, sorry
@vercetti: Sorry for the late reply. Was kinda busy. To answer your questions:
1: Yes and no. Depends. But pictures will probably visualize it a bit better:
HAL1 (LEGACY):
HAL3 (CAMERA2):
A bit more complex explained: https://source.android.com/devices/camera/camera3
2: HAL and driver are bond together. Without a driver, you can't even get HAL1 to work . But yes: A correct working HAL3 implementation will get you to the point of using your full potential of your camera. Again depends on the driver too . Hard to explain, but the more advanced explanation at Google should answer your questions very well.

How to imporve App Camera?

Default Camera App of Xiaomi Redmi Note 5/Pro is not bad!
But when another apps using camera (such as facebook, google Duo...), the picture quality is realy bad? i khow it doen't/isn't because of sensor'quality!
So How to imporve App Camera?
Tks
I always try to take photos with the camera app and then share to other apps, rather than take from within Facebook, hangouts, Viber, WhatsApp, etc. Most of those apps will still compress the image a bit also, so better starting with the best quality image, ie straight from the actual camera app itself.
Sent from my Redmi Note 5 using Tapatalk
gsmyth said:
I always try to take photos with the camera app and then share to other apps, rather than take from within Facebook, hangouts, Viber, WhatsApp, etc. Most of those apps will still compress the image a bit also, so better starting with the best quality image, ie straight from the actual camera app itself.
Sent from my Redmi Note 5 using Tapatalk
Click to expand...
Click to collapse
But it takes many time and inconvenience. Can any one replace default csmera API for app with better one?
dynamic503 said:
But it takes many time and inconvenience. Can any one replace default csmera API for app with better one?
Click to expand...
Click to collapse
You can't change what API an application uses, some apps take advantage of camera2 api. If any of the ones your using do and you haven't enabled camera2 api with magisk or either i think it's a build.prop edit, then there likely to be defaulting to camera1 api that's my guess at least.
This assumes your using a custom rom, i'm not sure if camera2 api is enabled by default with MIUI or if it requires root.Your primary camera app can take advantage of binary, blobs drivers that the third party apps may not necessarily benefit from, no perfect solution try it and see.
gsmyth said:
I always try to take photos with the camera app and then share to other apps, rather than take from within Facebook, hangouts, Viber, WhatsApp, etc. Most of those apps will still compress the image a bit also, so better starting with the best quality image, ie straight from the actual camera app itself.
Sent from my Redmi Note 5 using Tapatalk
Click to expand...
Click to collapse
Alister. said:
You can't change what API an application uses, some apps take advantage of camera2 api. If any of the ones your using do and you haven't enabled camera2 api with magisk or either i think it's a build.prop edit, then there likely to be defaulting to camera1 api that's my guess at least.
This assumes your using a custom rom, i'm not sure if camera2 api is enabled by default with MIUI or if it requires root.Your primary camera app can take advantage of binary, blobs drivers that the third party apps may not necessarily benefit from, no perfect solution try it and see.
Click to expand...
Click to collapse
I have enabled camera api2 already. For google camera. The pic quality is very good. But how can another camera app can use that camera driver?
dynamic503 said:
I have enabled camera api2 already. For google camera. The pic quality is very good. But how can another camera app can use that camera driver?
Click to expand...
Click to collapse
I've asked this type of thing before, and had a few developers try to answer it it's messy. The idea is Samsung, LG, Xiaomi every manufacturer has there own default rom.
They call theirs stock, that's their version of stock, it's customised only AOSP is truly stock, but the manufacturers versions of their "own" stock roms include a binary also referred to as binary, blobs, it's pretty much a closed source driver each manufacturer makes so their default camera looks amazing.
A general idea is replacing stock rom from any manufacturer with any that isn't based of their "own" stock rom isn't going to include their camera driver as it's closed source, so developers can't use it, they can get the cameras working but they don't look great compared to stock with binary. Lots of people avoid custom roms lineage os aosp ect for this reason video calls, all apps using the camera look terrible.
Two exceptions google open sources there camera drivers and oneplus might be some rare others, in these cases camera quality is expected to be the same while using lineage os or aosp.
I'm not 100% sure if all apps use camera1 and camera2 api if you try look for whatsapp or google duo i couldn't confirm it for them, snapchat uses camera1 api instagram uses camera2 api, but maybe some apps don't benefit from camera2 api at all i'm unsure.
I also tried asking if google camera ports, look better on stock roms that have the binary driver from companies, compared to lineage os ect that don't have it, but that's unclear as even tho i'm 100% sure the binary from manufacturers benefit there own made camera apps, i'm not 100% if the binary benefits all third party apps, but i guess it does, as that's likely the reason all apps look worse moving away from stock roms.
Google camera ports may look great on roms without, the binary as they simply make use of camera2 api which doesn't really require anything from the closed source driver, which would explain why everyone raves about google camera ports on lineage os ect been great, before camera 2 api never saw people been overly impressed about camera apps with missing binary drivers.
Are you on MIUI or something else? you did say the stock camera app not google camera looks good and everything else looks worse, if your still on MIUI then maybe they don't have a binary or simply one that only effects there own camera app, you mentioned the camera lens quality also it's mostly software driver optimisations per individual app ect influencing it's quality.
You asked how to make other apps use google cameras driver, well google camera is benefiting from camera2 api that isn't a driver at all, however it is a requirement similar aspect to a driver it's up to each app developer if there going to make there, application benefit from camera1 api or camera2 api or not at all, so you cant force apps to use it when the developer of that app never implemented camera2 api to begin with, you enable camera2 api for google camera because custom roms and lots of phones don't have it enabled at all. Some phones sold from stores have camera2 api enabled out of the box.
I do actually wish there was a way to fix this, as i've thought about this myself, i did ask a question here about the same type of thing you can read it if you like.
https://android.stackexchange.com/questions/200073/stock-os-vs-custom-proprietary-camera
also this the different levels of camera2 api supported depending on your phone
https://www.androidexplained.com/camera2-api-support/
the only other idea, i have is if the rom you use lets you choose the stock camera app to use and you change that to google camera and whatever, but i'm sure that's wishful thinking as when you do a video call an app will likely default to it's own camera even if you do that, but couldn't hurt to try it i guess!
Alister. said:
I've asked this type of thing before, and had a few developers try to answer it it's messy. The idea is Samsung, LG, Xiaomi every manufacturer has there own default rom.
They call theirs stock, that's their version of stock, it's customised only AOSP is truly stock, but the manufacturers versions of their "own" stock roms include a binary also referred to as binary, blobs, it's pretty much a closed source driver each manufacturer makes so their default camera looks amazing.
A general idea is replacing stock rom from any manufacturer with any that isn't based of their "own" stock rom isn't going to include their camera driver as it's closed source, so developers can't use it, they can get the cameras working but they don't look great compared to stock with binary. Lots of people avoid custom roms lineage os aosp ect for this reason video calls, all apps using the camera look terrible.
Two exceptions google open sources there camera drivers and oneplus might be some rare others, in these cases camera quality is expected to be the same while using lineage os or aosp.
I'm not 100% sure if all apps use camera1 and camera2 api if you try look for whatsapp or google duo i couldn't confirm it for them, snapchat uses camera1 api instagram uses camera2 api, but maybe some apps don't benefit from camera2 api at all i'm unsure.
I also tried asking if google camera ports, look better on stock roms that have the binary driver from companies, compared to lineage os ect that don't have it, but that's unclear as even tho i'm 100% sure the binary from manufacturers benefit there own made camera apps, i'm not 100% if the binary benefits all third party apps, but i guess it does, as that's likely the reason all apps look worse moving away from stock roms.
Google camera ports may look great on roms without, the binary as they simply make use of camera2 api which doesn't really require anything from the closed source driver, which would explain why everyone raves about google camera ports on lineage os ect been great, before camera 2 api never saw people been overly impressed about camera apps with missing binary drivers.
Are you on MIUI or something else? you did say the stock camera app not google camera looks good and everything else looks worse, if your still on MIUI then maybe they don't have a binary or simply one that only effects there own camera app, you mentioned the camera lens quality also it's mostly software driver optimisations per individual app ect influencing it's quality.
You asked how to make other apps use google cameras driver, well google camera is benefiting from camera2 api that isn't a driver at all, however it is a requirement similar aspect to a driver it's up to each app developer if there going to make there, application benefit from camera1 api or camera2 api or not at all, so you cant force apps to use it when the developer of that app never implemented camera2 api to begin with, you enable camera2 api for google camera because custom roms and lots of phones don't have it enabled at all. Some phones sold from stores have camera2 api enabled out of the box.
I do actually wish there was a way to fix this, as i've thought about this myself, i did ask a question here about the same type of thing you can read it if you like.
https://android.stackexchange.com/questions/200073/stock-os-vs-custom-proprietary-camera
also this the different levels of camera2 api supported depending on your phone
https://www.androidexplained.com/camera2-api-support/
the only other idea, i have is if the rom you use lets you choose the stock camera app to use and you change that to google camera and whatever, but i'm sure that's wishful thinking as when you do a video call an app will likely default to it's own camera even if you do that, but couldn't hurt to try it i guess!
Click to expand...
Click to collapse
Thankyou very much. But sad. Because many cheaper phone have better facebook messenger video call quality.
dynamic503 said:
Thankyou very much. But sad. Because many cheaper phone have better facebook messenger video call quality.
Click to expand...
Click to collapse
Your welcome, hmm what phones have you seen with better video call quality on facebook messenger? i assume you have compared to more expensive phones.
That just becomes confusing, since for example just because a bunch of apps use camera2 api doesn't mean they will all be the same, software optimisations determine if it looks better or worse.
I would have assumed facebook's software was exactly the same for each phone it has been put on, unless it's simply the case these cheaper phones your speaking of are benefiting from a closed source driver, and for some crazy reason xiaomi phones don't have a binary for it, guess i'll look into that at some point.
Now that i've got this phone, yes xiaomi's camera app in particular is very good photo quality, better then any camera app i've seen on any custom rom very adjustable.
Worth noting i installed lineage os that had the xiaomi's default camera included in the rom i compared the quality to when i was using stock camera on miui itself, i couldn't see any differences in picture quality, which suggests to me perhaps xiaomi's camera isn't using any closed source driver, binary at all and it's quality is simply optimisations and the fact there's no binary driver is why there other apps look worse.
Just guessing at this point, but that's about the only scenario i think makes sense.
Just remembered there's a new thing called Project Treble the note 5 pro can upgrade to be treble compatible i have the note 5 ai so i got treble out of the box the crux is, if you flash a rom well a treble rom is called a GSI, generic system image a benefit of this, if it allows you to keep the vendor partition untouched while using custom roms, the vendor partition is where the closed source driver is and does mean a custom rom can use those drivers as they haven't been removed.
So it would mean custom roms with good camera/videos of course Treble is so new, so who noes if that's working properly yet! and it would assume xiaomis phones had closed drivers, if your not using miui and camera is bad then no surprise try go back to miui you never said what you use.
anyways you can read about that here.
https://www.androidpolice.com/2018/05/13/project-treble-impact-android-custom-rom-community/
it points out the stuff about cameras and roms.
Alister. said:
Your welcome, hmm what phones have you seen with better video call quality on facebook messenger? i assume you have compared to more expensive phones.
That just becomes confusing, since for example just because a bunch of apps use camera2 api doesn't mean they will all be the same, software optimisations determine if it looks better or worse.
I would have assumed facebook's software was exactly the same for each phone it has been put on, unless it's simply the case these cheaper phones your speaking of are benefiting from a closed source driver, and for some crazy reason xiaomi phones don't have a binary for it, guess i'll look into that at some point.
Now that i've got this phone, yes xiaomi's camera app in particular is very good photo quality, better then any camera app i've seen on any custom rom very adjustable.
Worth noting i installed lineage os that had the xiaomi's default camera included in the rom i compared the quality to when i was using stock camera on miui itself, i couldn't see any differences in picture quality, which suggests to me perhaps xiaomi's camera isn't using any closed source driver, binary at all and it's quality is simply optimisations and the fact there's no binary driver is why there other apps look worse.
Just guessing at this point, but that's about the only scenario i think makes sense.
Just remembered there's a new thing called Project Treble the note 5 pro can upgrade to be treble compatible i have the note 5 ai so i got treble out of the box the crux is, if you flash a rom well a treble rom is called a GSI, generic system image a benefit of this, if it allows you to keep the vendor partition untouched while using custom roms, the vendor partition is where the closed source driver is and does mean a custom rom can use those drivers as they haven't been removed.
So it would mean custom roms with good camera/videos of course Treble is so new, so who noes if that's working properly yet! and it would assume xiaomis phones had closed drivers, if your not using miui and camera is bad then no surprise try go back to miui you never said what you use.
anyways you can read about that here.
https://www.androidpolice.com/2018/05/13/project-treble-impact-android-custom-rom-community/
it points out the stuff about cameras and roms.
Click to expand...
Click to collapse
Vivo V9 ... have better facebook video call quality...
Thankyou for your information
Camera performance in WhatsApp is very poor for rn5 pro selfie camera. How it could be improved ?
mjnabi said:
Camera performance in WhatsApp is very poor for rn5 pro selfie camera. How it could be improved ?
Click to expand...
Click to collapse
No way now. Plz all of us report to Xiaomi
Yes plz report to Xiaomi

Will I loose quallity i camera/photo if I go from stock to LineageOS?

As the title says. I have a Google Pixel with well known good camera. Will I loose photo quality by install LineageOS?
I guess that yes, default camera of LineageOS is inferior to camera app on Google Pixel. I'm wondering if default Google Camera APK would work without any issues (or maybe there is already a GCam mod for that combination of OS and hardware available?)

General OnePlus limits which camera sensors GCam can access in OxygenOS 12

OnePlus limits which sensors Google Camera mods can access in OxygenOS 12
By Arol Wright
For years, non-Pixel phones have been able to enjoy some of Google's camera magic, thanks to Google Camera ports/mods. Because a good part of the Pixel camera experience comes down to software, developers have figured out ways to bring parts of that experience to other devices. Among the root-and-ROM crowd, it's a popular practice that can let you enjoy Pixel camera features and enhanced processing on non-Pixel devices. Now a seemingly arbitrary restriction by OnePlus will keep Google Camera mods (and all third party camera apps) from accessing auxiliary cameras on the company's phones.
If you aren't familiar with the concept, a handful of popular developers (including folks like cstark27, BSG, and Arnova8G2) port and modify versions of the Pixel's Google Camera app to third-party devices. It can take some research to track down a version that plays nice on your particular phone, and there are usually a couple broken features and some bugs, but you can often get much better photo results from these modified camera apps than you can on the app your phone shipped with, as well as enjoy some of those Pixel-specific camera features on your non-Pixel phone.
As of OxygenOS 12, the auxiliary cameras (read: the non-primary ultrawide, macro, or telephoto lens) are no longer accessible outside of OnePlus' own camera app, as reported on the Google Camera Port Updates Telegram group. This means that if you were to install a Google Camera mod on your OnePlus phone running Android 12, you'd only be able to use the primary camera/sensor with it. And, if it wasn't clear, that means other apps won't have access to the other sensors either, including those you might download from the Play Store.
The OxygenOS 12 update that delivers this change has already been controversial among fans for other reasons. Not only is it essentially just Oppo's ColorOS with a handful of OnePlus-specific tweaks, but it's also absolutely loaded with bugs, something that eventually made OnePlus halt the update's rollout.
Notably, this auxiliary camera restriction is also present in Oppo phones running ColorOS. While it's unfortunate, that could mean the change is intentional, and we might not see this behavior revert back to a GCam-friendly practice if and when the update starts rolling out again.
If you have a OnePlus phone and want to keep using a Google Camera port or mod with all of your phone's sensors, consider holding off on the OxygenOS 12 update when it starts rolling out again. And if OnePlus doesn't bring the feature back, you can always try a ROM — they're relatively easy to install on OnePlus phones.
https://www.androidpolice.com/oxygenos-12-update-breaks-auxiliary-google-camera/

Question 12 Bit RAW on AOSP roms?

I've thought of moving to LOS since for a while now but i have found no things regarding the camera performance on the RAW imaging side.
Love the camera performance on stock with the 12 bit raw functionality but with recent privacy concerns i want to move to LOS, so i wonder if there is a way to keep the camera sensors full potential with something that supports 12 Bit raw capture like GCam or open camera? or is this something that is yet to be implemented in any app, as i have not seen any OOS cam ports as of yet.
TLDR: are 12 Bit raw images achievable on AOSP roms or is this something that would be lost in the transition.
Tbh you should look better
Most ROMs now have OOS cam build in, it's most of the times also in the title on this thread.
Lineage OS doesn't have it by default but crDroid/Nameless etc have it build in and are built on Lineage so I guess that's what you are looking for

Categories

Resources