[20.Jul.12][DEV] Lights Library v2 w/ correct LED color & notification while charging
If you don't know what a lights library is or what it does, then please move on. This topic is not for you.
Lights library with correct LED color & dual LED support
This lights library is based on the Pyramid lights library (HTC Sensation) by the CyanogenMod Project.
Differences to the normal lights lib we are currently using:
Based on HTC Pyramid lights lib from CyanogenMod Project
Show correct battery state
Add support for alternating LEDs (dual LED support)
Show correct battery state:
By default AOSP-based ROMs already report the devices as fully charged (green LED) even though the device is only at 90% of its battery capacity. This lights library will still show the amber LED until the kernel reports the battery as full.
Add support for flashing LED while charging:
Version 2 contains a changed behavior in comparison to the older version. The description of the older verison can be found below.
In the new version the LED will flash in the same color of your current charge state if you get a notification while charging, i.e.:
Charging & you get a notification --> Amber LED flashing
Fully charged & you get a notification --> Green LED flashing
The old behavior has a main disadvantage that the dual LEDs might not work correctly if the device goes into deep sleep. This is hardware related. The newer version doesn't have such a limitation as it uses the hardware supported modes.
Old behavior:
marc1706 said:
Add support for alternating LEDs:
It is something that has been bugging me for a while now.The scenario is simple:
Your phone is lying on the table and you are getting a short message, mail or maybe miss a call. Once you get back it will normally blink the notification led and you'll know that you missed something. What if you are charging your phone though? The phone will just show the charging LED and there is no way to tell you missed something unless you unlock your phone.
I've been missing a feature that'll show the charging LED while shortly flashing with a different LED color in order to notify you of a missed short message, mail, etc.
While the Leo has support for something similar it is actually somewhat weird:
First the amber LED shortly turns on and then after a small pause the green LED turns on for an instant. Afterwards there is a rather long pause and then it starts over. This is actually more or less an amber colored notification followed by a green colored notification. As the purpose of dual LED support is to show that we have a notification while charging this is not properly met by the native support the Leo has.
Thus I decided to add my own implementation that'll show one LED first (color depends on the charge level) and switch to the other LED color and then after one second back to the original color. This way the LEDs will always be on and thus correctly represent the fact that the device is charging while it's also able to show that there is a notification.
Click to expand...
Click to collapse
Works with:
Ice Cream Sandwich Builds
Take a look here: http://forum.xda-developers.com/showpost.php?p=27607351&postcount=2
You tell me
Source:
https://github.com/marc1706/android_device_htc_leo
Download:
View attachment lights.htcleo_v2.zip
Old version:
View attachment lights.htcleo.zip
Notes:
If you don't know how you can use the attached file then this topic is probably not for you.
Confirmed to be working on the following ROMs:
NexusHD2-ICS-4.0.4-CM9-HWA V2.3
IceCreamTosti v1.1 [AOKP B36 ]
Dorimanx-ROM-HIGH-END 3.1.9
Confirmed to not work on the following ROMs:
Any Gingerbread Sense ROMs
awesome thanks Marc
works perfectly
thanks Marc !
My test result:
after the power over 90% LED lamps do not appear（sense3.5）
Sorry, forgot to add that I only tested it on a ICS Rom. As far as I know it should also work on AOSP-based Gingerbread ROMs without issues.
I haven't had any time to play around on Sense ROMs but it'll probably won't work correctly on Sense ROMs.
What a pity!!!
it doesn't work on GB.
I'm on MIUI. will try on ICS then
Thank you
Try on Tytung's ICS 2.3 rom and it works! Thanks.
Exactly what i felt about missed notifications while on charge. Will test it out tonight and let you know.
Edit: Tried this on the rom I m using now (GB2.3.3 + Sense2.1). All my lights stopped working including display (toggle got disabled also. so couldn't adjust level) which remained full bright and hardware button lights didn't light up at all. So this isn't compatible with my ROM atleast.
Thankx though man. If you have time please consider making this compatible for GB sense. Would be great to see notification light blink while on charge too.
Thank you Marc!!!
Question: is this lib supporting the "auto-brightness custom levels" functions of CM7 and CM9?
Cheers!
Do I have to do something special? I copied it to \system\lib\hw set permissions, cleared Dalvik cache and rebooted. Charging light comes on fine. Called the phone to do a miss call. No blinking?
Using AOKP rom like in sig.
Installation should be as easy as copy/paste and setting the correct permissions (644).
Custom auto-brightness levels work with CM9.
@bipinsen: Did you touch the phone before it went back to sleep after you called?
marc1706 said:
Installation should be as easy as copy/paste and setting the correct permissions (644).
Custom auto-brightness levels work with CM9.
@bipinsen: Did you touch the phone before it went back to sleep after you called?
Click to expand...
Click to collapse
Here is what I do:
- Phone is sleeping; screen off; plugged in; LED light amber
- Call the phone; screen lights up; shows caller ID; LED light amber
- Call goes into voicemail; screen turns off; LED light amber
I'm looking at the phone now with the screen off and charging light *still* amber. I wake up the phone to the lockscreen and I see the missed call icon on the statusbar.
Edit: Full disclosure on the install. I still have the original file sitting in the \hw directory as "lights.htcleo.so.bak." I'm assuming that doesn't harm anything.
Weird. I'll see when I have time to test it on the ROM you are using.
Works very, very well! Exactly what I've been hoping for. Tested it while plugged in, and made a missed call. Lights changed accordingly to green flashes so I no longer have to wake up the screen in bed and kill my night vision to check for notifications. Thanks!
Marc, THANKS THANKS THANKS again!!!!
Just tested on GB ROM (Dorimanx Rom, see my sig) and everything IS working as you described!
Great JOB!!!!
marc1706, thanks for finally fixing lights library
I have one little request: could you please take a look when you have some spare time at this bug?
Thanks.
Marc1706,
As the late great comedian Chris Farley would say..."holy schnikes".
I have been waiting for something like this since the first Froyo roms on SD. Wow. Long ago, I almost had a workaround using LedMeKnow but it had GB issues and high battery drain. LedMeKnow inspired me to create a Tasker Profile that while plugged into the charger, if I missed a call or sms, my BUTTON lights would flash rapidly and dismissed upon screen unlock. I still use this profile and it's a very effective workaround.
SO...What the heck took so long? Not you specifically but I always thought this was a MUST have feature...it bugged me too like it did you. Very pleased to see you have provided this Lib. Thanks so much. Here is a quick report with Dorimanx rom 3.1.2 and Kernel 7.2.
1) 1st Handcent sms test...didn't work past 5 secs (but either did my button lights...weird) But when I turned screen on, it worked again but for only 5secs after the screen turned off.
2) missed call test...worked without stopping this time. Normally I would get RED flashing led...but with this LIB I get solid green for 2sec and red for 1sec or less. Works...but a bit odd. No complaints because the idea is working.
3) 2nd Handcent sms test...works like #2 above.
4) Pulled out of charger while flashing from #3 and I got my normal red led ON/OFF blinking.
5) Rebooted and tested Handcent and worked fine. I might have noticed the odd time when it went from red...to green...then briefly to black.
I get no blinking led while phone is plugged in the charger.
I use clk and latest ics rom from tytung V2.3.
I changed the lights.htcleo.so and changed permissions like it was on the old file. Then restarted the phone.
My phone is plugged on the charger. Phone is fully charged (100%). LED stays green all the time. Then i phoned myself with another phone.
But phone still stays green. No blinking. Screen is off. If i wake up my phone, i can see the missed call in the upper taskbar.
Where is the problem? Did i something wrong? Do i have to set up blinking led somewhere?
EDIT:
Strange behaviour: Now my led is blinking green and red. I did nothing, my phone was still in the charger...
My phone is still charging so I can't comment on the 90% issue but I'll edit my post once it does. Pertaining the missed call notification, mine is doing something weird.
*Edit Charging at 90% works fine.
I called my phone to test the missed call notification while charging and what it does is that it stays on amber for a minute and then its turns green for about a minute and twenty seconds then starts all over doing the same thing. What I noticed though is if I turn my screen on to where I have to put in my pattern lock it works like stated otherwise it does what I mentioned above.
I did as follows:
Moved lights.htcleo.so to \system\lib\hw with root explorer, set 644 as permissions,
(rw-r--r--) wiped dalvik cache, fixed permissions.
*edit: Using NexusHD2 v2.3
By the way, would it be possible for you to change the blinking so it could pulsate like in tytungs nexushd2 v2.2 when there was a missed call it would quickly blink amber and green and 2 secs later it would do the same? Here is the lights.htcleo.so libs that tytung used if need be:
http://code.google.com/p/nexus-hd2/downloads/list?q=label:lights.htcleo.so
All ok !
Confirm ALL worked on EU HD2 with Hiperdroid CM7
90% charge and etc.
I have a problem...
Every notification is working fine, just the one for low battery is not working.
Tried it with LED setting in SGS3 menu on and off, also changing the color has no effect.
Curious: Test mode for low battery works with every color, but live it doesn't.
Any suggestions? Did I miss something in settings?
Edit: Also notification does not work with the low battery setting ...
Cheers
Hello!
I love my OneX but its annoying sometimes to have the charging light on.. as it doesnt show other notifications. Is there a way to turn it off?
Thanks it advance!
This annoys me as well because I miss notifications due to that. Maybe a dev can cook up a flashable zip to disable it ?
It does show other notifications. At least on most AOSP ROMs.
Charging - Solid orange light
Charging and pending notification - Blinking orange light
Doesnt do that on stock based roms like ARHD
Hey all, I've just got a OnePlus 5T, at the moment i'm running the stock OxygenOS.
I see that I can control the colour of the notification led, however is there a way to make it so the LED doesn't blink and is always on?
If not I might just flash LinageOS, however I was thinking of keeping the phone stock for now if at all possible.
Edit - I found this could be done with an app called Light Manager, however it always had to have a notification saying the app was running.
In the end I found I was missing various other tweaks from LinageOS, so have just flashed that and am really enjoying the phone so far!
The problem is only in LED Notification - I have not LED notification ( led notification lamp in a front panel not work ) I restore the factory setting but there was no change. A few days ago, the LED lamp worked but only for a few hours...
I use MIUI 10.2.1 Stable ( OEIMIXM )
Does not work during charging does not work during hardware test.
If some of you have an idea let me help.
Regards!
I flash a few ROMs, but it did not work the LED notification light!
I flash xiaomi.eu 9.1.24 , Pixel Experience ROM and China Developer 10.2.2.0 but it is not work LED notification ligth.
Please help me to resolve the issue.